Re: [patch 2/3] kcmp: Add KCMP_EPOLL_TFD mode to compare epoll target files

2017-03-13 Thread Cyrill Gorcunov
On Mon, Mar 13, 2017 at 10:37:24AM -0700, Andrei Vagin wrote: > > Here is one question inline. > > Acked-by: Andrei Vagin Thanks! > > + > > + files = get_files_struct(task2); > > + if (!files) > > + return -EBADF; > > + > > + spin_lock(&files->file_lock); > > + filp_epoll = f

Re: [patch 2/3] kcmp: Add KCMP_EPOLL_TFD mode to compare epoll target files

2017-03-13 Thread Andrei Vagin
On Fri, Mar 10, 2017 at 11:16:57AM +0300, Cyrill Gorcunov wrote: > With current epoll architecture target files are addressed > with file_struct and file descriptor number, where the last > is not unique. Moreover files can be transferred from another > process via unix socket, added into queue and

Re: [patch 2/3] kcmp: Add KCMP_EPOLL_TFD mode to compare epoll target files

2017-03-13 Thread Cyrill Gorcunov
On Fri, Mar 10, 2017 at 11:16:57AM +0300, Cyrill Gorcunov wrote: > With current epoll architecture target files are addressed > with file_struct and file descriptor number, where the last > is not unique. Moreover files can be transferred from another > process via unix socket, added into queue and

[patch 2/3] kcmp: Add KCMP_EPOLL_TFD mode to compare epoll target files

2017-03-10 Thread Cyrill Gorcunov
With current epoll architecture target files are addressed with file_struct and file descriptor number, where the last is not unique. Moreover files can be transferred from another process via unix socket, added into queue and closed then so we won't find this descriptor in the task fdinfo list. T