Re: [patch 2/4] mm: memcontrol: don't pass a NULL memcg to mem_cgroup_end_move()

2014-10-22 Thread Vladimir Davydov
On Tue, Oct 21, 2014 at 04:21:34PM -0400, Johannes Weiner wrote: > mem_cgroup_end_move() checks if the passed memcg is NULL, along with a > lengthy comment to explain why this seemingly non-sensical situation > is even possible. > > Check in cancel_attach() itself whether can_attach() set up the

Re: [patch 2/4] mm: memcontrol: don't pass a NULL memcg to mem_cgroup_end_move()

2014-10-22 Thread Vladimir Davydov
On Tue, Oct 21, 2014 at 04:21:34PM -0400, Johannes Weiner wrote: mem_cgroup_end_move() checks if the passed memcg is NULL, along with a lengthy comment to explain why this seemingly non-sensical situation is even possible. Check in cancel_attach() itself whether can_attach() set up the move

[patch 2/4] mm: memcontrol: don't pass a NULL memcg to mem_cgroup_end_move()

2014-10-21 Thread Johannes Weiner
mem_cgroup_end_move() checks if the passed memcg is NULL, along with a lengthy comment to explain why this seemingly non-sensical situation is even possible. Check in cancel_attach() itself whether can_attach() set up the move context or not, it's a lot more obvious from there. Then remove the

[patch 2/4] mm: memcontrol: don't pass a NULL memcg to mem_cgroup_end_move()

2014-10-21 Thread Johannes Weiner
mem_cgroup_end_move() checks if the passed memcg is NULL, along with a lengthy comment to explain why this seemingly non-sensical situation is even possible. Check in cancel_attach() itself whether can_attach() set up the move context or not, it's a lot more obvious from there. Then remove the