Re: [patch 2/5] setup_per_zone_lowmem_reserve() oops fix

2005-03-07 Thread Andrea Arcangeli
On Mon, Mar 07, 2005 at 12:20:48AM -0800, Andrew Morton wrote: > I haven't thought about it yet, but there must be some way to avoid leaving > huge amounts of lowmem free. It should be OK to allow lowmem to be fully > used, as long as there's sufficent reclaimable stuff in there - slab, >

Re: [patch 2/5] setup_per_zone_lowmem_reserve() oops fix

2005-03-07 Thread Andrea Arcangeli
On Mon, Mar 07, 2005 at 07:10:05PM +1100, Nick Piggin wrote: > [EMAIL PROTECTED] wrote: > >If you do 'echo 0 0 > /proc/sys/vm/lowmem_reserve_ratio' the kernel gets a > >divide-by-zero. > > > >Prevent that, and fiddle with some whitespace too. > > > >Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>

Re: [patch 2/5] setup_per_zone_lowmem_reserve() oops fix

2005-03-07 Thread Andrew Morton
Nick Piggin <[EMAIL PROTECTED]> wrote: > > [EMAIL PROTECTED] wrote: > > If you do 'echo 0 0 > /proc/sys/vm/lowmem_reserve_ratio' the kernel gets a > > divide-by-zero. > > > > Prevent that, and fiddle with some whitespace too. > > > > Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> > > Can we

Re: [patch 2/5] setup_per_zone_lowmem_reserve() oops fix

2005-03-07 Thread Nick Piggin
[EMAIL PROTECTED] wrote: If you do 'echo 0 0 > /proc/sys/vm/lowmem_reserve_ratio' the kernel gets a divide-by-zero. Prevent that, and fiddle with some whitespace too. Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> Can we instead have a patch that makes the value zero turn off the lowmem reserve

Re: [patch 2/5] setup_per_zone_lowmem_reserve() oops fix

2005-03-07 Thread Nick Piggin
[EMAIL PROTECTED] wrote: If you do 'echo 0 0 /proc/sys/vm/lowmem_reserve_ratio' the kernel gets a divide-by-zero. Prevent that, and fiddle with some whitespace too. Signed-off-by: Andrew Morton [EMAIL PROTECTED] Can we instead have a patch that makes the value zero turn off the lowmem reserve

Re: [patch 2/5] setup_per_zone_lowmem_reserve() oops fix

2005-03-07 Thread Andrew Morton
Nick Piggin [EMAIL PROTECTED] wrote: [EMAIL PROTECTED] wrote: If you do 'echo 0 0 /proc/sys/vm/lowmem_reserve_ratio' the kernel gets a divide-by-zero. Prevent that, and fiddle with some whitespace too. Signed-off-by: Andrew Morton [EMAIL PROTECTED] Can we instead have a patch

Re: [patch 2/5] setup_per_zone_lowmem_reserve() oops fix

2005-03-07 Thread Andrea Arcangeli
On Mon, Mar 07, 2005 at 07:10:05PM +1100, Nick Piggin wrote: [EMAIL PROTECTED] wrote: If you do 'echo 0 0 /proc/sys/vm/lowmem_reserve_ratio' the kernel gets a divide-by-zero. Prevent that, and fiddle with some whitespace too. Signed-off-by: Andrew Morton [EMAIL PROTECTED] Can we

Re: [patch 2/5] setup_per_zone_lowmem_reserve() oops fix

2005-03-07 Thread Andrea Arcangeli
On Mon, Mar 07, 2005 at 12:20:48AM -0800, Andrew Morton wrote: I haven't thought about it yet, but there must be some way to avoid leaving huge amounts of lowmem free. It should be OK to allow lowmem to be fully used, as long as there's sufficent reclaimable stuff in there - slab, blockdev

Re: [patch 2/5] setup_per_zone_lowmem_reserve() oops fix

2005-03-06 Thread Greg KH
On Fri, Mar 04, 2005 at 01:16:55PM -0800, [EMAIL PROTECTED] wrote: > > > If you do 'echo 0 0 > /proc/sys/vm/lowmem_reserve_ratio' the kernel gets a > divide-by-zero. > > Prevent that, and fiddle with some whitespace too. Due to the whitespace fiddling, I'd say no to this patch, based on the

Re: [patch 2/5] setup_per_zone_lowmem_reserve() oops fix

2005-03-06 Thread Greg KH
On Fri, Mar 04, 2005 at 01:16:55PM -0800, [EMAIL PROTECTED] wrote: If you do 'echo 0 0 /proc/sys/vm/lowmem_reserve_ratio' the kernel gets a divide-by-zero. Prevent that, and fiddle with some whitespace too. Due to the whitespace fiddling, I'd say no to this patch, based on the criteria.

[patch 2/5] setup_per_zone_lowmem_reserve() oops fix

2005-03-04 Thread akpm
If you do 'echo 0 0 > /proc/sys/vm/lowmem_reserve_ratio' the kernel gets a divide-by-zero. Prevent that, and fiddle with some whitespace too. Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- 25-akpm/mm/page_alloc.c | 21 +++-- 1 files changed, 15 insertions(+), 6

[patch 2/5] setup_per_zone_lowmem_reserve() oops fix

2005-03-04 Thread akpm
If you do 'echo 0 0 /proc/sys/vm/lowmem_reserve_ratio' the kernel gets a divide-by-zero. Prevent that, and fiddle with some whitespace too. Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- 25-akpm/mm/page_alloc.c | 21 +++-- 1 files changed, 15 insertions(+), 6