Re: [patch 2.6] remove PCI_BRIDGE_CTL_VGA handling from setup-bus.c

2005-07-18 Thread Grant Grundler
On Thu, Jul 14, 2005 at 02:53:27PM +0100, Russell King wrote: > On Thu, Jul 14, 2005 at 03:53:44PM +0400, Ivan Kokshaysky wrote: > > The setup-bus code doesn't work correctly for configurations > > with more than one display adapter in the same PCI domain. > > This stuff actually is a leftover of a

Re: [patch 2.6] remove PCI_BRIDGE_CTL_VGA handling from setup-bus.c

2005-07-15 Thread Benjamin Herrenschmidt
On Fri, 2005-07-15 at 01:46 +0400, Ivan Kokshaysky wrote: > On Thu, Jul 14, 2005 at 10:07:34AM -0400, Jon Smirl wrote: > > I'm don't think it has ever been working in the 2.6 series. If you are > > getting rid of it get rid of the #define PCI_BRIDGE_CTL_VGA in pci.h > > too since this code was the

Re: [patch 2.6] remove PCI_BRIDGE_CTL_VGA handling from setup-bus.c

2005-07-14 Thread Ivan Kokshaysky
On Thu, Jul 14, 2005 at 06:42:30PM -0400, Jon Smirl wrote: > You need to take this code into account, from arch/i386/pci/fixup.c Yes, I've seen that (nice code, btw :-). But my code snippet has nothing to do with x86 or any particular architecture - it just shows that some hypothetical platform th

Re: [patch 2.6] remove PCI_BRIDGE_CTL_VGA handling from setup-bus.c

2005-07-14 Thread Ivan Kokshaysky
On Thu, Jul 14, 2005 at 06:39:43PM -0400, Jon Smirl wrote: > I had the wrong define, this is the one I was thinking of > IORESOURCE_BUS_HAS_VGA Oh, I definitely agree about that one. It's been unused for a couple of years, at least. Let's kill it, please. Ivan. - To unsubscribe from this list: s

Re: [patch 2.6] remove PCI_BRIDGE_CTL_VGA handling from setup-bus.c

2005-07-14 Thread Jon Smirl
On 7/14/05, Ivan Kokshaysky <[EMAIL PROTECTED]> wrote: > It shouldn't be a problem. These days we have a lot of arch hooks > in the PCI layer. I'd probably start with the following: You need to take this code into account, from arch/i386/pci/fixup.c /* * Fixup to mark boot BIOS video selected by

Re: [patch 2.6] remove PCI_BRIDGE_CTL_VGA handling from setup-bus.c

2005-07-14 Thread Jon Smirl
On 7/14/05, Ivan Kokshaysky <[EMAIL PROTECTED]> wrote: > On Thu, Jul 14, 2005 at 10:07:34AM -0400, Jon Smirl wrote: > > I'm don't think it has ever been working in the 2.6 series. If you are > > getting rid of it get rid of the #define PCI_BRIDGE_CTL_VGA in pci.h > > too since this code was the onl

Re: [patch 2.6] remove PCI_BRIDGE_CTL_VGA handling from setup-bus.c

2005-07-14 Thread Ivan Kokshaysky
On Thu, Jul 14, 2005 at 10:07:34AM -0400, Jon Smirl wrote: > I'm don't think it has ever been working in the 2.6 series. If you are > getting rid of it get rid of the #define PCI_BRIDGE_CTL_VGA in pci.h > too since this code was the only user. No. The PCI_BRIDGE_CTL_VGA is not something artificial

Re: [patch 2.6] remove PCI_BRIDGE_CTL_VGA handling from setup-bus.c

2005-07-14 Thread Ivan Kokshaysky
On Thu, Jul 14, 2005 at 02:53:27PM +0100, Russell King wrote: > What happens when there is no firmware? It shouldn't be a problem. These days we have a lot of arch hooks in the PCI layer. I'd probably start with the following: static void __init pcibios_enable_p2p_vga_fwd(struct pci_dev *dev) {

Re: [patch 2.6] remove PCI_BRIDGE_CTL_VGA handling from setup-bus.c

2005-07-14 Thread Jon Smirl
On 7/14/05, Russell King <[EMAIL PROTECTED]> wrote: > On Thu, Jul 14, 2005 at 03:53:44PM +0400, Ivan Kokshaysky wrote: > > The setup-bus code doesn't work correctly for configurations > > with more than one display adapter in the same PCI domain. > > This stuff actually is a leftover of an early 2.

Re: [patch 2.6] remove PCI_BRIDGE_CTL_VGA handling from setup-bus.c

2005-07-14 Thread Russell King
On Thu, Jul 14, 2005 at 03:53:44PM +0400, Ivan Kokshaysky wrote: > The setup-bus code doesn't work correctly for configurations > with more than one display adapter in the same PCI domain. > This stuff actually is a leftover of an early 2.4 PCI setup code > and apparently it stopped working after s

Re: [patch 2.6] remove PCI_BRIDGE_CTL_VGA handling from setup-bus.c

2005-07-14 Thread Jon Smirl
On 7/14/05, Ivan Kokshaysky <[EMAIL PROTECTED]> wrote: > The setup-bus code doesn't work correctly for configurations > with more than one display adapter in the same PCI domain. > This stuff actually is a leftover of an early 2.4 PCI setup code > and apparently it stopped working after some "bridg

[patch 2.6] remove PCI_BRIDGE_CTL_VGA handling from setup-bus.c

2005-07-14 Thread Ivan Kokshaysky
The setup-bus code doesn't work correctly for configurations with more than one display adapter in the same PCI domain. This stuff actually is a leftover of an early 2.4 PCI setup code and apparently it stopped working after some "bridge_ctl" changes. So the best thing we can do is just to remove i