Re: [patch 2.6.21-rc5-git 1/2] fix hotplug for legacy platform drivers

2007-04-03 Thread Cornelia Huck
On Mon, 2 Apr 2007 09:59:28 -0700, David Brownell <[EMAIL PROTECTED]> wrote: > But long term, I wonder. Isn't "no kevents issued" an extremely > blunt tool, which could cause lots of damage? It might be better > to have selective filters, one per event family: core (add/remove), >

Re: [patch 2.6.21-rc5-git 1/2] fix hotplug for legacy platform drivers

2007-04-03 Thread Cornelia Huck
On Mon, 2 Apr 2007 09:59:28 -0700, David Brownell [EMAIL PROTECTED] wrote: But long term, I wonder. Isn't no kevents issued an extremely blunt tool, which could cause lots of damage? It might be better to have selective filters, one per event family: core (add/remove), online/offline,

Re: [patch 2.6.21-rc5-git 1/2] fix hotplug for legacy platform drivers

2007-04-02 Thread David Brownell
On Monday 02 April 2007 1:10 pm, Dmitry Torokhov wrote: > On 3/31/07, David Brownell <[EMAIL PROTECTED]> wrote: > > @@ -349,6 +360,13 @@ EXPORT_SYMBOL_GPL(platform_device_unregi > > * memory allocated for the device allows drivers using such devices > > * to be unloaded iwithout waiting

Re: [patch 2.6.21-rc5-git 1/2] fix hotplug for legacy platform drivers

2007-04-02 Thread Dmitry Torokhov
On 3/31/07, David Brownell <[EMAIL PROTECTED]> wrote: @@ -349,6 +360,13 @@ EXPORT_SYMBOL_GPL(platform_device_unregi * memory allocated for the device allows drivers using such devices * to be unloaded iwithout waiting for the last reference to the device * to be dropped. + * + *

Re: [patch 2.6.21-rc5-git 1/2] fix hotplug for legacy platform drivers

2007-04-02 Thread David Brownell
On Monday 02 April 2007 3:55 am, Russell King wrote: > On Sat, Mar 31, 2007 at 02:55:38PM -0700, David Brownell wrote: > > --- g26.orig/drivers/pcmcia/pxa2xx_mainstone.c 2007-03-30 > > 16:44:04.0 -0700 > > +++ g26/drivers/pcmcia/pxa2xx_mainstone.c 2007-03-31 14:23:56.0 > >

Re: [patch 2.6.21-rc5-git 1/2] fix hotplug for legacy platform drivers

2007-04-02 Thread David Brownell
On Monday 02 April 2007 3:49 am, Cornelia Huck wrote: > On Sat, 31 Mar 2007 14:55:38 -0700, > David Brownell <[EMAIL PROTECTED]> wrote: > > > This fix uses the newish per-device flag controlling issuance of "add" > > events. > > (A previous version of this patch used a per-device "driver can

Re: [patch 2.6.21-rc5-git 1/2] fix hotplug for legacy platform drivers

2007-04-02 Thread Russell King
On Sat, Mar 31, 2007 at 02:55:38PM -0700, David Brownell wrote: > --- g26.orig/drivers/pcmcia/pxa2xx_mainstone.c2007-03-30 > 16:44:04.0 -0700 > +++ g26/drivers/pcmcia/pxa2xx_mainstone.c 2007-03-31 14:23:56.0 > -0700 > @@ -175,6 +175,8 @@ static int __init

Re: [patch 2.6.21-rc5-git 1/2] fix hotplug for legacy platform drivers

2007-04-02 Thread Cornelia Huck
On Sat, 31 Mar 2007 14:55:38 -0700, David Brownell <[EMAIL PROTECTED]> wrote: > This fix uses the newish per-device flag controlling issuance of "add" events. > (A previous version of this patch used a per-device "driver can hotplug" flag, > which only scrubbed $MODALIAS from the environment

Re: [patch 2.6.21-rc5-git 1/2] fix hotplug for legacy platform drivers

2007-04-02 Thread Cornelia Huck
On Sat, 31 Mar 2007 14:55:38 -0700, David Brownell [EMAIL PROTECTED] wrote: This fix uses the newish per-device flag controlling issuance of add events. (A previous version of this patch used a per-device driver can hotplug flag, which only scrubbed $MODALIAS from the environment rather than

Re: [patch 2.6.21-rc5-git 1/2] fix hotplug for legacy platform drivers

2007-04-02 Thread Russell King
On Sat, Mar 31, 2007 at 02:55:38PM -0700, David Brownell wrote: --- g26.orig/drivers/pcmcia/pxa2xx_mainstone.c2007-03-30 16:44:04.0 -0700 +++ g26/drivers/pcmcia/pxa2xx_mainstone.c 2007-03-31 14:23:56.0 -0700 @@ -175,6 +175,8 @@ static int __init

Re: [patch 2.6.21-rc5-git 1/2] fix hotplug for legacy platform drivers

2007-04-02 Thread David Brownell
On Monday 02 April 2007 3:55 am, Russell King wrote: On Sat, Mar 31, 2007 at 02:55:38PM -0700, David Brownell wrote: --- g26.orig/drivers/pcmcia/pxa2xx_mainstone.c 2007-03-30 16:44:04.0 -0700 +++ g26/drivers/pcmcia/pxa2xx_mainstone.c 2007-03-31 14:23:56.0 -0700

Re: [patch 2.6.21-rc5-git 1/2] fix hotplug for legacy platform drivers

2007-04-02 Thread David Brownell
On Monday 02 April 2007 3:49 am, Cornelia Huck wrote: On Sat, 31 Mar 2007 14:55:38 -0700, David Brownell [EMAIL PROTECTED] wrote: This fix uses the newish per-device flag controlling issuance of add events. (A previous version of this patch used a per-device driver can hotplug flag,

Re: [patch 2.6.21-rc5-git 1/2] fix hotplug for legacy platform drivers

2007-04-02 Thread Dmitry Torokhov
On 3/31/07, David Brownell [EMAIL PROTECTED] wrote: @@ -349,6 +360,13 @@ EXPORT_SYMBOL_GPL(platform_device_unregi * memory allocated for the device allows drivers using such devices * to be unloaded iwithout waiting for the last reference to the device * to be dropped. + * + *

Re: [patch 2.6.21-rc5-git 1/2] fix hotplug for legacy platform drivers

2007-04-02 Thread David Brownell
On Monday 02 April 2007 1:10 pm, Dmitry Torokhov wrote: On 3/31/07, David Brownell [EMAIL PROTECTED] wrote: @@ -349,6 +360,13 @@ EXPORT_SYMBOL_GPL(platform_device_unregi * memory allocated for the device allows drivers using such devices * to be unloaded iwithout waiting for the

[patch 2.6.21-rc5-git 1/2] fix hotplug for legacy platform drivers

2007-03-31 Thread David Brownell
We've had various reports of some legacy "probe the hardware" style platform drivers having nasty problems with hotplug support. The core issue is that those legacy drivers don't fully conform to the driver model. They assume a role that should be the responsibility of infrastructure code:

[patch 2.6.21-rc5-git 1/2] fix hotplug for legacy platform drivers

2007-03-31 Thread David Brownell
We've had various reports of some legacy probe the hardware style platform drivers having nasty problems with hotplug support. The core issue is that those legacy drivers don't fully conform to the driver model. They assume a role that should be the responsibility of infrastructure code: