Re: [patch 25/29] xen: Add the Xen virtual network device driver.

2007-05-07 Thread Rusty Russell
On Mon, 2007-05-07 at 23:30 -0700, Jeremy Fitzhardinge wrote: > Rusty Russell wrote: > > Looks good, you can slightly improve it to be the model use of new > > module_param types by calling your functions param_set_rx_mode and > > param_get_rx_mode, then simply using "module_param(rx_mode, rx_mode,

Re: [patch 25/29] xen: Add the Xen virtual network device driver.

2007-05-07 Thread Jeremy Fitzhardinge
Rusty Russell wrote: > Looks good, you can slightly improve it to be the model use of new > module_param types by calling your functions param_set_rx_mode and > param_get_rx_mode, then simply using "module_param(rx_mode, rx_mode, > 0400)" > Cute. I tried it out, but it doesn't yield an obvious

Re: [patch 25/29] xen: Add the Xen virtual network device driver.

2007-05-07 Thread Rusty Russell
On Mon, 2007-05-07 at 14:11 -0700, Jeremy Fitzhardinge wrote: > Christoph Hellwig wrote: > > On Fri, May 04, 2007 at 04:21:16PM -0700, Jeremy Fitzhardinge wrote: > > > >> +/* > >> + * Mutually-exclusive module options to select receive data path: > >> + * rx_copy : Packets are copied by network

Re: [patch 25/29] xen: Add the Xen virtual network device driver.

2007-05-07 Thread Jeremy Fitzhardinge
Christoph Hellwig wrote: > On Fri, May 04, 2007 at 04:21:16PM -0700, Jeremy Fitzhardinge wrote: > >> +/* >> + * Mutually-exclusive module options to select receive data path: >> + * rx_copy : Packets are copied by network backend into local memory >> + * rx_flip : Page containing packet data i

Re: [patch 25/29] xen: Add the Xen virtual network device driver.

2007-05-07 Thread Jeremy Fitzhardinge
Herbert Xu wrote: > On Sat, May 05, 2007 at 03:05:07AM -0700, Jeremy Fitzhardinge wrote: > >> Sorry, I forgot about it. I was waiting to hear back from network >> people about what this is actually for, and whether we really need it. >> > > We should just change this to use netif_device_a

Re: [patch 25/29] xen: Add the Xen virtual network device driver.

2007-05-05 Thread Herbert Xu
On Sat, May 05, 2007 at 03:05:07AM -0700, Jeremy Fitzhardinge wrote: > > Sorry, I forgot about it. I was waiting to hear back from network > people about what this is actually for, and whether we really need it. We should just change this to use netif_device_attach and netif_device_detach. Chee

Re: [patch 25/29] xen: Add the Xen virtual network device driver.

2007-05-05 Thread Jeremy Fitzhardinge
Christoph Hellwig wrote: > There only seems to be a module description but no actual paramter for > this. I wish people would have listened to me back then and made the > description part of the modular_param statement.. > Uh, what did I miss? Oh, I see, I need a module_param(rx_mode, int, 06

Re: [patch 25/29] xen: Add the Xen virtual network device driver.

2007-05-05 Thread Rusty Russell
On Sat, 2007-05-05 at 10:16 +0100, Christoph Hellwig wrote: > I wish people would have listened to me back then and made the > description part of the modular_param statement.. Sometimes we weary of change. However, come up with a decent name and implement it and we can deprecate module_param() b

Re: [patch 25/29] xen: Add the Xen virtual network device driver.

2007-05-05 Thread Christoph Hellwig
On Fri, May 04, 2007 at 04:21:16PM -0700, Jeremy Fitzhardinge wrote: > +/* > + * Mutually-exclusive module options to select receive data path: > + * rx_copy : Packets are copied by network backend into local memory > + * rx_flip : Page containing packet data is transferred to our ownership > + *

[patch 25/29] xen: Add the Xen virtual network device driver.

2007-05-04 Thread Jeremy Fitzhardinge
The network device frontend driver allows the kernel to access network devices exported exported by a virtual machine containing a physical network device driver. * * * use skb.cb for storing private data Netfront's use of nh.raw and h.raw for storing page+offset is a bit hinky, and it breaks wit