[patch 3/3] mm: make read_cache_page synchronous

2007-02-08 Thread Nick Piggin
Ensure pages are uptodate after returning from read_cache_page, which allows us to cut out most of the filesystem-internal PageUptodate_NoLock calls. I didn't have a great look down the call chains, but this appears to fixes 7 possible use-before uptodate in hfs, 2 in hfsplus, 1 in jfs, a few in

[patch 3/3] mm: make read_cache_page synchronous

2007-02-08 Thread Nick Piggin
Ensure pages are uptodate after returning from read_cache_page, which allows us to cut out most of the filesystem-internal PageUptodate_NoLock calls. I didn't have a great look down the call chains, but this appears to fixes 7 possible use-before uptodate in hfs, 2 in hfsplus, 1 in jfs, a few in

Re: [patch 3/3] mm: make read_cache_page synchronous

2007-02-06 Thread Nick Piggin
On Tue, Feb 06, 2007 at 12:28:39AM -0800, Andrew Morton wrote: > > > > Also, a memory leak in sys_swapon(). > > Separate patch? Gack, I'm an idiot, there is no memory leak :P - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED]

Re: [patch 3/3] mm: make read_cache_page synchronous

2007-02-06 Thread Nick Piggin
Andrew Morton wrote: On Tue, 6 Feb 2007 09:02:33 +0100 (CET) Nick Piggin <[EMAIL PROTECTED]> wrote: Ensure pages are uptodate after returning from read_cache_page, which allows us to cut out most of the filesystem-internal PageUptodate_NoLock calls. Normally it's good to rename functions

Re: [patch 3/3] mm: make read_cache_page synchronous

2007-02-06 Thread Andrew Morton
On Tue, 6 Feb 2007 09:02:33 +0100 (CET) Nick Piggin <[EMAIL PROTECTED]> wrote: > Ensure pages are uptodate after returning from read_cache_page, which allows > us to cut out most of the filesystem-internal PageUptodate_NoLock calls. Normally it's good to rename functions when we change their

[patch 3/3] mm: make read_cache_page synchronous

2007-02-06 Thread Nick Piggin
Ensure pages are uptodate after returning from read_cache_page, which allows us to cut out most of the filesystem-internal PageUptodate_NoLock calls. I didn't have a great look down the call chains, but this appears to fixes 7 possible use-before uptodate in hfs, 2 in hfsplus, 1 in jfs, a few in

[patch 3/3] mm: make read_cache_page synchronous

2007-02-06 Thread Nick Piggin
Ensure pages are uptodate after returning from read_cache_page, which allows us to cut out most of the filesystem-internal PageUptodate_NoLock calls. I didn't have a great look down the call chains, but this appears to fixes 7 possible use-before uptodate in hfs, 2 in hfsplus, 1 in jfs, a few in

Re: [patch 3/3] mm: make read_cache_page synchronous

2007-02-06 Thread Andrew Morton
On Tue, 6 Feb 2007 09:02:33 +0100 (CET) Nick Piggin [EMAIL PROTECTED] wrote: Ensure pages are uptodate after returning from read_cache_page, which allows us to cut out most of the filesystem-internal PageUptodate_NoLock calls. Normally it's good to rename functions when we change their

Re: [patch 3/3] mm: make read_cache_page synchronous

2007-02-06 Thread Nick Piggin
Andrew Morton wrote: On Tue, 6 Feb 2007 09:02:33 +0100 (CET) Nick Piggin [EMAIL PROTECTED] wrote: Ensure pages are uptodate after returning from read_cache_page, which allows us to cut out most of the filesystem-internal PageUptodate_NoLock calls. Normally it's good to rename functions

Re: [patch 3/3] mm: make read_cache_page synchronous

2007-02-06 Thread Nick Piggin
On Tue, Feb 06, 2007 at 12:28:39AM -0800, Andrew Morton wrote: Also, a memory leak in sys_swapon(). Separate patch? Gack, I'm an idiot, there is no memory leak :P - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More