Re: [patch 3/4] mm: memcontrol: remove unnecessary PCG_MEM memory charge flag

2014-10-22 Thread Vladimir Davydov
On Mon, Oct 20, 2014 at 11:22:11AM -0400, Johannes Weiner wrote: > PCG_MEM is a remnant from an earlier version of 0a31bc97c80c ("mm: > memcontrol: rewrite uncharge API"), used to tell whether migration > cleared a charge while leaving pc->mem_cgroup valid and PCG_USED set. > But in the final versi

Re: [patch 3/4] mm: memcontrol: remove unnecessary PCG_MEM memory charge flag

2014-10-22 Thread Michal Hocko
On Mon 20-10-14 11:22:11, Johannes Weiner wrote: > PCG_MEM is a remnant from an earlier version of 0a31bc97c80c ("mm: > memcontrol: rewrite uncharge API"), used to tell whether migration > cleared a charge while leaving pc->mem_cgroup valid and PCG_USED set. > But in the final version, mem_cgroup_m

Re: [patch 3/4] mm: memcontrol: remove unnecessary PCG_MEM memory charge flag

2014-10-21 Thread Kamezawa Hiroyuki
(2014/10/21 0:22), Johannes Weiner wrote: > PCG_MEM is a remnant from an earlier version of 0a31bc97c80c ("mm: > memcontrol: rewrite uncharge API"), used to tell whether migration > cleared a charge while leaving pc->mem_cgroup valid and PCG_USED set. > But in the final version, mem_cgroup_migrate(

[patch 3/4] mm: memcontrol: remove unnecessary PCG_MEM memory charge flag

2014-10-20 Thread Johannes Weiner
PCG_MEM is a remnant from an earlier version of 0a31bc97c80c ("mm: memcontrol: rewrite uncharge API"), used to tell whether migration cleared a charge while leaving pc->mem_cgroup valid and PCG_USED set. But in the final version, mem_cgroup_migrate() directly uncharges the source page, rendering th