Re: [patch 3/6] Cleanup efi_enter_virtual_mode function

2013-11-01 Thread Borislav Petkov
On Fri, Nov 01, 2013 at 09:18:25AM +0800, Dave Young wrote: > Great, thank you. BTW, I have managed to test original patch set on a > Macboot Air of my friend with usb boot, it works ok. Ok, that's actually a very good news - the apples tend to be special wrt uefi implementation. --

Re: [patch 3/6] Cleanup efi_enter_virtual_mode function

2013-11-01 Thread Borislav Petkov
On Fri, Nov 01, 2013 at 09:18:25AM +0800, Dave Young wrote: Great, thank you. BTW, I have managed to test original patch set on a Macboot Air of my friend with usb boot, it works ok. Ok, that's actually a very good news - the apples tend to be special wrt uefi implementation. --

Re: [patch 3/6] Cleanup efi_enter_virtual_mode function

2013-10-31 Thread Dave Young
On 10/31/13 at 11:44am, Borislav Petkov wrote: > Dear Mr. Young, > > On Thu, Oct 31, 2013 at 10:07:14AM +0800, Dave Young wrote: > > > But Frankly I'd like to see them in list instead even with only small > > > fixes > > > beacuse in this way there might be more people to review it carefully. >

Re: [patch 3/6] Cleanup efi_enter_virtual_mode function

2013-10-31 Thread Dave Young
On 10/31/13 at 11:45am, Borislav Petkov wrote: > On Wed, Oct 30, 2013 at 08:07:45PM -0700, H. Peter Anvin wrote: > > You can use git for your own purposes, still. > > git mk-coffee --refill --now Ccing Jonathan Corbet ;) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: [patch 3/6] Cleanup efi_enter_virtual_mode function

2013-10-31 Thread Borislav Petkov
On Wed, Oct 30, 2013 at 08:07:45PM -0700, H. Peter Anvin wrote: > You can use git for your own purposes, still. git mk-coffee --refill --now -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. -- -- To unsubscribe from this list: send the line "unsubscribe

Re: [patch 3/6] Cleanup efi_enter_virtual_mode function

2013-10-31 Thread Borislav Petkov
Dear Mr. Young, On Thu, Oct 31, 2013 at 10:07:14AM +0800, Dave Young wrote: > > But Frankly I'd like to see them in list instead even with only small fixes > > beacuse in this way there might be more people to review it carefully. > > There's another shorcoming for keeping new patches in git is

Re: [patch 3/6] Cleanup efi_enter_virtual_mode function

2013-10-31 Thread Borislav Petkov
Dear Mr. Young, On Thu, Oct 31, 2013 at 10:07:14AM +0800, Dave Young wrote: But Frankly I'd like to see them in list instead even with only small fixes beacuse in this way there might be more people to review it carefully. There's another shorcoming for keeping new patches in git is that

Re: [patch 3/6] Cleanup efi_enter_virtual_mode function

2013-10-31 Thread Borislav Petkov
On Wed, Oct 30, 2013 at 08:07:45PM -0700, H. Peter Anvin wrote: You can use git for your own purposes, still. git mk-coffee --refill --now -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. -- -- To unsubscribe from this list: send the line unsubscribe

Re: [patch 3/6] Cleanup efi_enter_virtual_mode function

2013-10-31 Thread Dave Young
On 10/31/13 at 11:45am, Borislav Petkov wrote: On Wed, Oct 30, 2013 at 08:07:45PM -0700, H. Peter Anvin wrote: You can use git for your own purposes, still. git mk-coffee --refill --now Ccing Jonathan Corbet ;) -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the

Re: [patch 3/6] Cleanup efi_enter_virtual_mode function

2013-10-31 Thread Dave Young
On 10/31/13 at 11:44am, Borislav Petkov wrote: Dear Mr. Young, On Thu, Oct 31, 2013 at 10:07:14AM +0800, Dave Young wrote: But Frankly I'd like to see them in list instead even with only small fixes beacuse in this way there might be more people to review it carefully. There's

Re: [patch 3/6] Cleanup efi_enter_virtual_mode function

2013-10-30 Thread H. Peter Anvin
On 10/30/2013 07:07 PM, Dave Young wrote: > On 10/31/13 at 10:04am, Dave Young wrote: >> On 10/30/13 at 11:47am, Borislav Petkov wrote: >>> On Wed, Oct 30, 2013 at 10:03:49AM +0800, Dave Young wrote: Will try, but please keep the posted patches in mailing list up-to-date, >>> >>> Would you

Re: [patch 3/6] Cleanup efi_enter_virtual_mode function

2013-10-30 Thread Dave Young
On 10/31/13 at 10:04am, Dave Young wrote: > On 10/30/13 at 11:47am, Borislav Petkov wrote: > > On Wed, Oct 30, 2013 at 10:03:49AM +0800, Dave Young wrote: > > > Will try, but please keep the posted patches in mailing list up-to-date, > > > > Would you like me to send them to you privately? > >

Re: [patch 3/6] Cleanup efi_enter_virtual_mode function

2013-10-30 Thread Dave Young
On 10/30/13 at 11:47am, Borislav Petkov wrote: > On Wed, Oct 30, 2013 at 10:03:49AM +0800, Dave Young wrote: > > Will try, but please keep the posted patches in mailing list up-to-date, > > Would you like me to send them to you privately? Thanks, do not bother to send me privately I can get it

Re: [patch 3/6] Cleanup efi_enter_virtual_mode function

2013-10-30 Thread Borislav Petkov
On Wed, Oct 30, 2013 at 10:03:49AM +0800, Dave Young wrote: > Will try, but please keep the posted patches in mailing list up-to-date, Would you like me to send them to you privately? > I'm an old-fashioned person, do not tend to depend on git. Really? You should change that - you're missing

Re: [patch 3/6] Cleanup efi_enter_virtual_mode function

2013-10-30 Thread Borislav Petkov
On Wed, Oct 30, 2013 at 10:03:49AM +0800, Dave Young wrote: Will try, but please keep the posted patches in mailing list up-to-date, Would you like me to send them to you privately? I'm an old-fashioned person, do not tend to depend on git. Really? You should change that - you're missing out

Re: [patch 3/6] Cleanup efi_enter_virtual_mode function

2013-10-30 Thread Dave Young
On 10/30/13 at 11:47am, Borislav Petkov wrote: On Wed, Oct 30, 2013 at 10:03:49AM +0800, Dave Young wrote: Will try, but please keep the posted patches in mailing list up-to-date, Would you like me to send them to you privately? Thanks, do not bother to send me privately I can get it from

Re: [patch 3/6] Cleanup efi_enter_virtual_mode function

2013-10-30 Thread Dave Young
On 10/31/13 at 10:04am, Dave Young wrote: On 10/30/13 at 11:47am, Borislav Petkov wrote: On Wed, Oct 30, 2013 at 10:03:49AM +0800, Dave Young wrote: Will try, but please keep the posted patches in mailing list up-to-date, Would you like me to send them to you privately? Thanks, do

Re: [patch 3/6] Cleanup efi_enter_virtual_mode function

2013-10-30 Thread H. Peter Anvin
On 10/30/2013 07:07 PM, Dave Young wrote: On 10/31/13 at 10:04am, Dave Young wrote: On 10/30/13 at 11:47am, Borislav Petkov wrote: On Wed, Oct 30, 2013 at 10:03:49AM +0800, Dave Young wrote: Will try, but please keep the posted patches in mailing list up-to-date, Would you like me to send

Re: [patch 3/6] Cleanup efi_enter_virtual_mode function

2013-10-29 Thread Dave Young
On 10/29/13 at 02:43pm, Borislav Petkov wrote: > On Tue, Oct 29, 2013 at 10:32:03AM +0800, Dave Young wrote: > > I remember I tried your efi branch, but the code is different from > > what you sent to list, thus I turned to use the mbox patches. > > Yeah, please use the #efi branch as I keep

Re: [patch 3/6] Cleanup efi_enter_virtual_mode function

2013-10-29 Thread Borislav Petkov
On Tue, Oct 29, 2013 at 10:32:03AM +0800, Dave Young wrote: > I remember I tried your efi branch, but the code is different from > what you sent to list, thus I turned to use the mbox patches. Yeah, please use the #efi branch as I keep refreshing it with the newest changes. They're hopefully not

Re: [patch 3/6] Cleanup efi_enter_virtual_mode function

2013-10-29 Thread Borislav Petkov
On Tue, Oct 29, 2013 at 10:32:03AM +0800, Dave Young wrote: I remember I tried your efi branch, but the code is different from what you sent to list, thus I turned to use the mbox patches. Yeah, please use the #efi branch as I keep refreshing it with the newest changes. They're hopefully not

Re: [patch 3/6] Cleanup efi_enter_virtual_mode function

2013-10-29 Thread Dave Young
On 10/29/13 at 02:43pm, Borislav Petkov wrote: On Tue, Oct 29, 2013 at 10:32:03AM +0800, Dave Young wrote: I remember I tried your efi branch, but the code is different from what you sent to list, thus I turned to use the mbox patches. Yeah, please use the #efi branch as I keep refreshing

Re: [patch 3/6] Cleanup efi_enter_virtual_mode function

2013-10-28 Thread Dave Young
> > > > 3. Then I merged the 'efi' branch of > > git://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git ontop. > > I used the patches from mailbox directly. > Fixed an conflict and merge them one by one. I remember I tried your efi branch, but the code is different from what you sent to list,

Re: [patch 3/6] Cleanup efi_enter_virtual_mode function

2013-10-28 Thread Dave Young
On 10/28/13 at 03:58pm, Borislav Petkov wrote: > On Mon, Oct 28, 2013 at 07:24:58PM +0800, Dave Young wrote: > > I use linus tree, git pull Matt's efi-next tree, then apply your 12 > > patches and my patches. I applied your previous 11 patches + the last > > update patch 12/12, but the last one

Re: [patch 3/6] Cleanup efi_enter_virtual_mode function

2013-10-28 Thread Borislav Petkov
On Mon, Oct 28, 2013 at 07:24:58PM +0800, Dave Young wrote: > I use linus tree, git pull Matt's efi-next tree, then apply your 12 > patches and my patches. I applied your previous 11 patches + the last > update patch 12/12, but the last one does not apply, I manually shift > a hunk to make it

Re: [patch 3/6] Cleanup efi_enter_virtual_mode function

2013-10-28 Thread Dave Young
On 10/28/13 at 12:20pm, Borislav Petkov wrote: > On Mon, Oct 28, 2013 at 06:10:11PM +0800, Dave Young wrote: > > Sorry, I have not any public git account. Attached the patch I applied > > with git > > Still doesn't work: > > $ patch -p1 --dry-run -i

Re: [patch 3/6] Cleanup efi_enter_virtual_mode function

2013-10-28 Thread Borislav Petkov
On Mon, Oct 28, 2013 at 06:10:11PM +0800, Dave Young wrote: > Sorry, I have not any public git account. Attached the patch I applied > with git Still doesn't work: $ patch -p1 --dry-run -i /tmp/02-efi-enter-virtual-mode-cleanup-1.patch.new checking file arch/x86/platform/efi/efi.c Hunk #1

Re: [patch 3/6] Cleanup efi_enter_virtual_mode function

2013-10-28 Thread Dave Young
On 10/28/13 at 06:10pm, Dave Young wrote: > On 10/28/13 at 11:04am, Borislav Petkov wrote: > > On Mon, Oct 28, 2013 at 05:51:17PM +0800, Dave Young wrote: > > > It does have a warning, but it applied successfully, no idea though: > > > patches/02-efi-enter-virtual-mode-cleanup.patch > > >

Re: [patch 3/6] Cleanup efi_enter_virtual_mode function

2013-10-28 Thread Dave Young
On 10/28/13 at 11:04am, Borislav Petkov wrote: > On Mon, Oct 28, 2013 at 05:51:17PM +0800, Dave Young wrote: > > It does have a warning, but it applied successfully, no idea though: > > patches/02-efi-enter-virtual-mode-cleanup.patch > > Applying: Cleanup efi_enter_virtual_mode function > >

Re: [patch 3/6] Cleanup efi_enter_virtual_mode function

2013-10-28 Thread Borislav Petkov
On Mon, Oct 28, 2013 at 05:51:17PM +0800, Dave Young wrote: > It does have a warning, but it applied successfully, no idea though: > patches/02-efi-enter-virtual-mode-cleanup.patch > Applying: Cleanup efi_enter_virtual_mode function > /home/dave/git/efi/.git/rebase-apply/patch:42: space before

Re: [patch 3/6] Cleanup efi_enter_virtual_mode function

2013-10-28 Thread Dave Young
On 10/28/13 at 05:40pm, Dave Young wrote: > On 10/28/13 at 10:32am, Borislav Petkov wrote: > > On Sun, Oct 27, 2013 at 11:47:16AM +0800, dyo...@redhat.com wrote: > > > Add two small functions: > > > efi_merge_regions and efi_map_regions, efi_enter_virtual_mode > > > calls them instead of embedding

Re: [patch 3/6] Cleanup efi_enter_virtual_mode function

2013-10-28 Thread Dave Young
On 10/28/13 at 10:32am, Borislav Petkov wrote: > On Sun, Oct 27, 2013 at 11:47:16AM +0800, dyo...@redhat.com wrote: > > Add two small functions: > > efi_merge_regions and efi_map_regions, efi_enter_virtual_mode > > calls them instead of embedding two long for loop. > > > > Signed-off-by: Dave

Re: [patch 3/6] Cleanup efi_enter_virtual_mode function

2013-10-28 Thread Borislav Petkov
On Sun, Oct 27, 2013 at 11:47:16AM +0800, dyo...@redhat.com wrote: > Add two small functions: > efi_merge_regions and efi_map_regions, efi_enter_virtual_mode > calls them instead of embedding two long for loop. > > Signed-off-by: Dave Young > --- > arch/x86/platform/efi/efi.c | 83 >

Re: [patch 3/6] Cleanup efi_enter_virtual_mode function

2013-10-28 Thread Borislav Petkov
On Sun, Oct 27, 2013 at 11:47:16AM +0800, dyo...@redhat.com wrote: Add two small functions: efi_merge_regions and efi_map_regions, efi_enter_virtual_mode calls them instead of embedding two long for loop. Signed-off-by: Dave Young dyo...@redhat.com --- arch/x86/platform/efi/efi.c | 83

Re: [patch 3/6] Cleanup efi_enter_virtual_mode function

2013-10-28 Thread Dave Young
On 10/28/13 at 10:32am, Borislav Petkov wrote: On Sun, Oct 27, 2013 at 11:47:16AM +0800, dyo...@redhat.com wrote: Add two small functions: efi_merge_regions and efi_map_regions, efi_enter_virtual_mode calls them instead of embedding two long for loop. Signed-off-by: Dave Young

Re: [patch 3/6] Cleanup efi_enter_virtual_mode function

2013-10-28 Thread Dave Young
On 10/28/13 at 05:40pm, Dave Young wrote: On 10/28/13 at 10:32am, Borislav Petkov wrote: On Sun, Oct 27, 2013 at 11:47:16AM +0800, dyo...@redhat.com wrote: Add two small functions: efi_merge_regions and efi_map_regions, efi_enter_virtual_mode calls them instead of embedding two long

Re: [patch 3/6] Cleanup efi_enter_virtual_mode function

2013-10-28 Thread Borislav Petkov
On Mon, Oct 28, 2013 at 05:51:17PM +0800, Dave Young wrote: It does have a warning, but it applied successfully, no idea though: patches/02-efi-enter-virtual-mode-cleanup.patch Applying: Cleanup efi_enter_virtual_mode function /home/dave/git/efi/.git/rebase-apply/patch:42: space before tab in

Re: [patch 3/6] Cleanup efi_enter_virtual_mode function

2013-10-28 Thread Dave Young
On 10/28/13 at 11:04am, Borislav Petkov wrote: On Mon, Oct 28, 2013 at 05:51:17PM +0800, Dave Young wrote: It does have a warning, but it applied successfully, no idea though: patches/02-efi-enter-virtual-mode-cleanup.patch Applying: Cleanup efi_enter_virtual_mode function

Re: [patch 3/6] Cleanup efi_enter_virtual_mode function

2013-10-28 Thread Dave Young
On 10/28/13 at 06:10pm, Dave Young wrote: On 10/28/13 at 11:04am, Borislav Petkov wrote: On Mon, Oct 28, 2013 at 05:51:17PM +0800, Dave Young wrote: It does have a warning, but it applied successfully, no idea though: patches/02-efi-enter-virtual-mode-cleanup.patch Applying: Cleanup

Re: [patch 3/6] Cleanup efi_enter_virtual_mode function

2013-10-28 Thread Borislav Petkov
On Mon, Oct 28, 2013 at 06:10:11PM +0800, Dave Young wrote: Sorry, I have not any public git account. Attached the patch I applied with git Still doesn't work: $ patch -p1 --dry-run -i /tmp/02-efi-enter-virtual-mode-cleanup-1.patch.new checking file arch/x86/platform/efi/efi.c Hunk #1

Re: [patch 3/6] Cleanup efi_enter_virtual_mode function

2013-10-28 Thread Dave Young
On 10/28/13 at 12:20pm, Borislav Petkov wrote: On Mon, Oct 28, 2013 at 06:10:11PM +0800, Dave Young wrote: Sorry, I have not any public git account. Attached the patch I applied with git Still doesn't work: $ patch -p1 --dry-run -i /tmp/02-efi-enter-virtual-mode-cleanup-1.patch.new

Re: [patch 3/6] Cleanup efi_enter_virtual_mode function

2013-10-28 Thread Borislav Petkov
On Mon, Oct 28, 2013 at 07:24:58PM +0800, Dave Young wrote: I use linus tree, git pull Matt's efi-next tree, then apply your 12 patches and my patches. I applied your previous 11 patches + the last update patch 12/12, but the last one does not apply, I manually shift a hunk to make it apply.

Re: [patch 3/6] Cleanup efi_enter_virtual_mode function

2013-10-28 Thread Dave Young
On 10/28/13 at 03:58pm, Borislav Petkov wrote: On Mon, Oct 28, 2013 at 07:24:58PM +0800, Dave Young wrote: I use linus tree, git pull Matt's efi-next tree, then apply your 12 patches and my patches. I applied your previous 11 patches + the last update patch 12/12, but the last one does not

Re: [patch 3/6] Cleanup efi_enter_virtual_mode function

2013-10-28 Thread Dave Young
3. Then I merged the 'efi' branch of git://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git ontop. I used the patches from mailbox directly. Fixed an conflict and merge them one by one. I remember I tried your efi branch, but the code is different from what you sent to list, thus I

[patch 3/6] Cleanup efi_enter_virtual_mode function

2013-10-26 Thread dyoung
Add two small functions: efi_merge_regions and efi_map_regions, efi_enter_virtual_mode calls them instead of embedding two long for loop. Signed-off-by: Dave Young --- arch/x86/platform/efi/efi.c | 83 +++- 1 file changed, 52 insertions(+), 31

[patch 3/6] Cleanup efi_enter_virtual_mode function

2013-10-26 Thread dyoung
Add two small functions: efi_merge_regions and efi_map_regions, efi_enter_virtual_mode calls them instead of embedding two long for loop. Signed-off-by: Dave Young dyo...@redhat.com --- arch/x86/platform/efi/efi.c | 83 +++- 1 file changed, 52