Re: [patch 32/37] CRYPTO: api: scatterwalk_copychunks() fails to advance through scatterlist

2007-03-31 Thread J. Bruce Fields
On Sat, Mar 31, 2007 at 12:14:37PM +1000, Herbert Xu wrote: > Indeed. That patch was buggy. Sorry for not catching this earlier. Yep, thanks for the fix. I used the wrong length, then tested with a case where nbytes would always be less than PAGE_SIZE, which doesn't hit this problem. Apologies

Re: [patch 32/37] CRYPTO: api: scatterwalk_copychunks() fails to advance through scatterlist

2007-03-30 Thread Herbert Xu
On Fri, Mar 30, 2007 at 08:11:29PM -0700, Greg KH wrote: > > Is this an "add-on" patch, or a replacement one? This is an add-on. In case you want a replacement, here it is: Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://

Re: [patch 32/37] CRYPTO: api: scatterwalk_copychunks() fails to advance through scatterlist

2007-03-30 Thread Greg KH
On Sat, Mar 31, 2007 at 12:14:37PM +1000, Herbert Xu wrote: > On Sat, Mar 31, 2007 at 03:41:32AM +0200, Patrick McHardy wrote: > > > > > [CRYPTO] api: scatterwalk_copychunks() fails to advance through > > > scatterlist > > > > This patch seems to cause some problems, I get reproducable freezes >

Re: [patch 32/37] CRYPTO: api: scatterwalk_copychunks() fails to advance through scatterlist

2007-03-30 Thread Patrick McHardy
Herbert Xu wrote: > Indeed. That patch was buggy. Sorry for not catching this earlier. > > This should fix the problem. Works fine, thanks Herbert. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at ht

Re: [patch 32/37] CRYPTO: api: scatterwalk_copychunks() fails to advance through scatterlist

2007-03-30 Thread Herbert Xu
On Sat, Mar 31, 2007 at 03:41:32AM +0200, Patrick McHardy wrote: > > > [CRYPTO] api: scatterwalk_copychunks() fails to advance through scatterlist > > This patch seems to cause some problems, I get reproducable freezes > on the receiving system with net-2.6.22 when sending IPsec packets > larger t

Re: [patch 32/37] CRYPTO: api: scatterwalk_copychunks() fails to advance through scatterlist

2007-03-30 Thread Patrick McHardy
Greg KH wrote: > -stable review patch. If anyone has any objections, please let us know. > > -- > From: J. Bruce Fields <[EMAIL PROTECTED]> > > [CRYPTO] api: scatterwalk_copychunks() fails to advance through scatterlist This patch seems to cause some problems, I get reproducabl

[patch 32/37] CRYPTO: api: scatterwalk_copychunks() fails to advance through scatterlist

2007-03-30 Thread Greg KH
-stable review patch. If anyone has any objections, please let us know. -- From: J. Bruce Fields <[EMAIL PROTECTED]> [CRYPTO] api: scatterwalk_copychunks() fails to advance through scatterlist In the loop in scatterwalk_copychunks(), if walk->offset is zero, then scatterwalk_pag