Re: [patch 4/4] media: cx231xx: Consolidate dmesg output

2020-10-16 Thread kernel test robot
Hi Thomas, I love your patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on linus/master linux/master v5.9 next-20201016] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to

Re: [patch 4/4] media: cx231xx: Consolidate dmesg output

2020-10-14 Thread Thomas Gleixner
On Wed, Oct 14 2020 at 22:36, kernel test robot wrote: >drivers/media/usb/cx231xx/cx231xx-vbi.c: In function > 'cx231xx_init_vbi_isoc': >>> drivers/media/usb/cx231xx/cx231xx-vbi.c:411:5: warning: format '%s' expects >>> a matching 'char *' argument [-Wformat=] > 411 | "unable to allo

Re: [patch 4/4] media: cx231xx: Consolidate dmesg output

2020-10-14 Thread kernel test robot
Hi Thomas, I love your patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on linus/master linux/master v5.9 next-20201013] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to

[patch 4/4] media: cx231xx: Consolidate dmesg output

2020-10-13 Thread Thomas Gleixner
The memory allocations in cx231xx_init_*() happen all in task context with GFP_KERNEL. Therefore a dev_err() trying to deduce whether this is called from task or interrupt context is pretty useless. Remove these historical leftovers. Signed-off-by: Thomas Gleixner Cc: Mauro Carvalho Chehab Cc: