Re: [patch 4/7] ps3: Storage Driver Probing

2007-05-26 Thread Geert Uytterhoeven
On Sat, 26 May 2007, Benjamin Herrenschmidt wrote: > On Fri, 2007-05-25 at 18:18 +0200, Arnd Bergmann wrote: > > > +static u64 ps3stor_wait_for_completion(u64 devid, u64 tag, > > > +unsigned int timeout) > > > +{ > > > + unsigned int retries = 0; > > > +

Re: [patch 4/7] ps3: Storage Driver Probing

2007-05-25 Thread Benjamin Herrenschmidt
On Fri, 2007-05-25 at 21:48 +0200, Geert Uytterhoeven wrote: > > > + msleep_interruptible(ms); > > > + if (ms < 6) > > > + ms <<= 1; > > > > Is this timeout only for the disk spinup, or also for detecting > media > > added at run time, like inserting a DVD

Re: [patch 4/7] ps3: Storage Driver Probing

2007-05-25 Thread Benjamin Herrenschmidt
On Fri, 2007-05-25 at 18:18 +0200, Arnd Bergmann wrote: > > +static u64 ps3stor_wait_for_completion(u64 devid, u64 tag, > > +unsigned int timeout) > > +{ > > + unsigned int retries = 0; > > + u64 res = -1, status; > > + > > + for (retries = 0; retries

Re: [patch 4/7] ps3: Storage Driver Probing

2007-05-25 Thread Geert Uytterhoeven
On Fri, 25 May 2007, Arnd Bergmann wrote: > On Friday 25 May 2007, [EMAIL PROTECTED] wrote: > > +static u64 ps3stor_wait_for_completion(u64 devid, u64 tag, > > + unsigned int timeout) > > +{ > > + unsigned int retries = 0; > > + u64 res = -1, status; > > + > > +

Re: [patch 4/7] ps3: Storage Driver Probing

2007-05-25 Thread Geoff Levand
Hi. Arnd Bergmann wrote: >> +switch (dev_type) { >> +case PS3_DEV_TYPE_STOR_DISK: >> +match_id = PS3_MATCH_ID_STOR_DISK; >> +break; >> + >> +case PS3_DEV_TYPE_STOR_ROM: >> +match_id = PS3_MATCH_ID_STOR_ROM; >> +break; >> + >> +case PS

Re: [patch 4/7] ps3: Storage Driver Probing

2007-05-25 Thread Arnd Bergmann
On Friday 25 May 2007, [EMAIL PROTECTED] wrote: > Add storage driver probing. > New storage devices are detected and added by a kthread. Hi Geert, the driver looks pretty good, just a few details I noticed: > +static u64 ps3stor_wait_for_completion(u64 devid, u64 tag, > +

[patch 4/7] ps3: Storage Driver Probing

2007-05-25 Thread Geert . Uytterhoeven
Add storage driver probing. New storage devices are detected and added by a kthread. Signed-off-by: Geert Uytterhoeven <[EMAIL PROTECTED]> --- arch/powerpc/platforms/ps3/device-init.c | 344 +++ 1 files changed, 344 insertions(+) --- a/arch/powerpc/platforms/ps3/devi