Re: [patch 4 15/22] timer: Remove slack leftovers

2016-07-22 Thread Jason A. Donenfeld
On Fri, Jul 22, 2016 at 5:18 PM, Jason A. Donenfeld wrote: > Hi Thomas, > > On Fri, Jul 22, 2016 at 3:04 PM, Thomas Gleixner wrote: >> >> Well, this really depends on the TIMEOUT value you have. The code now does >> implicit batching for larger timeouts by queueing the timers into wheels with >>

Re: [patch 4 15/22] timer: Remove slack leftovers

2016-07-22 Thread Jason A. Donenfeld
Hi Thomas, On Fri, Jul 22, 2016 at 3:04 PM, Thomas Gleixner wrote: > > Well, this really depends on the TIMEOUT value you have. The code now does > implicit batching for larger timeouts by queueing the timers into wheels with > coarse grained granularity. As long as your new TIMEOUT value ends up

Re: [patch 4 15/22] timer: Remove slack leftovers

2016-07-22 Thread Thomas Gleixner
On Fri, 22 Jul 2016, Jason A. Donenfeld wrote: > Thomas Gleixner writes: > > We now have implicit batching in the timer wheel. The slack is not longer > > used. Remove it. > >From a brief look at timer.c, it looked like __mod_timer was rather > expensive. So, as an optimization, I wanted the "time

Re: [patch 4 15/22] timer: Remove slack leftovers

2016-07-22 Thread Jason A. Donenfeld
Hi Thomas, Thomas Gleixner writes: > We now have implicit batching in the timer wheel. The slack is not longer > used. Remove it. > - set_timer_slack(&ev->dwork.timer, intv / 4); > - set_timer_slack(&host->timeout_timer, HZ); > - set_timer_slack(&di->work.timer, poll_interval * HZ / 4); > - set_t

[patch 4 15/22] timer: Remove slack leftovers

2016-07-04 Thread Thomas Gleixner
We now have implicit batching in the timer wheel. The slack is not longer used. Remove it. Signed-off-by: Thomas Gleixner Cc: Peter Zijlstra Cc: Frederic Weisbecker Cc: Chris Mason Cc: Eric Dumazet Cc: r...@linutronix.de Cc: "Paul E. McKenney" Cc: Arjan van de Ven --- block/genhd.c