Re: [patch 5/8] Immediate Values - x86 Optimization (simplified)

2007-11-20 Thread Mathieu Desnoyers
* Rusty Russell ([EMAIL PROTECTED]) wrote: > On Tuesday 20 November 2007 01:28:03 Mathieu Desnoyers wrote: > > * Rusty Russell ([EMAIL PROTECTED]) wrote: > > > I think it would be easier to just fast-path the num_online_cpus == 1 > > > case, even if you want to keep this "update_early" interface. >

Re: [patch 5/8] Immediate Values - x86 Optimization (simplified)

2007-11-19 Thread Rusty Russell
On Tuesday 20 November 2007 01:28:03 Mathieu Desnoyers wrote: > * Rusty Russell ([EMAIL PROTECTED]) wrote: > > I think it would be easier to just fast-path the num_online_cpus == 1 > > case, even if you want to keep this "update_early" interface. > > Nope, that could lead to problems. I call core_i

Re: [patch 5/8] Immediate Values - x86 Optimization (simplified)

2007-11-19 Thread Mathieu Desnoyers
* Rusty Russell ([EMAIL PROTECTED]) wrote: [...] > > +++ linux-2.6-lttng/arch/x86/kernel/immediate.c 2007-11-16 > > 08:56:22.0 -0500 @@ -0,0 +1,143 @@ > > +/* > > + * Immediate Value - x86 architecture specific code. > > This is now almost entirely generic code, but I suppose we can le

Re: [patch 5/8] Immediate Values - x86 Optimization (simplified)

2007-11-19 Thread Mathieu Desnoyers
* Rusty Russell ([EMAIL PROTECTED]) wrote: > On Saturday 17 November 2007 01:03:35 Mathieu Desnoyers wrote: > > x86 optimization of the immediate values which uses a movl with code > > patching to set/unset the value used to populate the register used as > > variable source. > > Since immediate va

Re: [patch 5/8] Immediate Values - x86 Optimization (simplified)

2007-11-18 Thread Rusty Russell
On Saturday 17 November 2007 01:03:35 Mathieu Desnoyers wrote: > x86 optimization of the immediate values which uses a movl with code > patching to set/unset the value used to populate the register used as > variable source. Since immediate values are by definition an optimization, I think it make

Re: [patch 5/8] Immediate Values - x86 Optimization (simplified)

2007-11-16 Thread Mathieu Desnoyers
* Rusty Russell ([EMAIL PROTECTED]) wrote: > On Thursday 15 November 2007 16:37:51 Mathieu Desnoyers wrote: > > * Rusty Russell ([EMAIL PROTECTED]) wrote: > > > On Thursday 15 November 2007 15:06:10 Mathieu Desnoyers wrote: > > > > A - the NMI or MCE code calls any external kernel code (printk, > >