Re: [patch 5/8] x86_64:Dont do broadcast IPIs when hotplug is enabled in flat mode.

On Thu, Aug 04, 2005 at 12:51:07PM +0200, Andi Kleen wrote: > > static void flat_send_IPI_allbutself(int vector) > > { > > +#ifndef CONFIG_HOTPLUG_CPU > > if (((num_online_cpus()) - 1) >= 1) > > __send_IPI_shortcut(APIC_DEST_ALLBUT, vector,APIC_DEST_LOGICAL); > > +#else > > + cp

Re: [patch 5/8] x86_64:Dont do broadcast IPIs when hotplug is enabled in flat mode.

On Thu, Aug 04, 2005 at 12:51:07PM +0200, Andi Kleen wrote: > > static void flat_send_IPI_allbutself(int vector) > > { > > +#ifndef CONFIG_HOTPLUG_CPU > > if (((num_online_cpus()) - 1) >= 1) > > __send_IPI_shortcut(APIC_DEST_ALLBUT, vector,APIC_DEST_LOGICAL); > > +#else > > + cp

Re: [patch 5/8] x86_64:Dont do broadcast IPIs when hotplug is enabled in flat mode.

> static void flat_send_IPI_allbutself(int vector) > { > +#ifndef CONFIG_HOTPLUG_CPU > if (((num_online_cpus()) - 1) >= 1) > __send_IPI_shortcut(APIC_DEST_ALLBUT, vector,APIC_DEST_LOGICAL); > +#else > + cpumask_t allbutme = cpu_online_map; > + int me = get_cpu(); /* En

[patch 5/8] x86_64:Dont do broadcast IPIs when hotplug is enabled in flat mode.

the use of non-shortcut version of routines breaking CPU hotplug. The option to select this via cmdline also is deleted with the physflat patch, hence directly placing this code under CONFIG_HOTPLUG_CPU. We dont want to use broadcast mode IPI's when hotplug is enabled. This causes bad effects in s