Re: [patch 7/9] mm: memcontrol: do not acquire page_cgroup lock for kmem pages

2014-05-28 Thread Michal Hocko
On Tue 27-05-14 15:53:42, Johannes Weiner wrote: > On Fri, May 23, 2014 at 03:39:38PM +0200, Michal Hocko wrote: [...] > > > if (!PageCgroupUsed(pc)) > > > return; > > > > > > - lock_page_cgroup(pc); > > > - if (PageCgroupUsed(pc)) { > > > - memcg = pc->mem_cgroup; > > > -

Re: [patch 7/9] mm: memcontrol: do not acquire page_cgroup lock for kmem pages

2014-05-27 Thread Johannes Weiner
On Fri, May 23, 2014 at 03:39:38PM +0200, Michal Hocko wrote: > I am adding Vladimir to CC > > On Wed 30-04-14 16:25:41, Johannes Weiner wrote: > > Kmem page charging and uncharging is serialized by means of exclusive > > access to the page. Do not take the page_cgroup lock and don't set > > pc->

Re: [patch 7/9] mm: memcontrol: do not acquire page_cgroup lock for kmem pages

2014-05-23 Thread Vladimir Davydov
On Fri, May 23, 2014 at 03:39:38PM +0200, Michal Hocko wrote: > I am adding Vladimir to CC > > On Wed 30-04-14 16:25:41, Johannes Weiner wrote: > > Kmem page charging and uncharging is serialized by means of exclusive > > access to the page. Do not take the page_cgroup lock and don't set > > pc->

Re: [patch 7/9] mm: memcontrol: do not acquire page_cgroup lock for kmem pages

2014-05-23 Thread Michal Hocko
On Fri 23-05-14 15:39:38, Michal Hocko wrote: > I am adding Vladimir to CC And now for real > > On Wed 30-04-14 16:25:41, Johannes Weiner wrote: > > Kmem page charging and uncharging is serialized by means of exclusive > > access to the page. Do not take the page_cgroup lock and don't set > > pc

Re: [patch 7/9] mm: memcontrol: do not acquire page_cgroup lock for kmem pages

2014-05-23 Thread Michal Hocko
I am adding Vladimir to CC On Wed 30-04-14 16:25:41, Johannes Weiner wrote: > Kmem page charging and uncharging is serialized by means of exclusive > access to the page. Do not take the page_cgroup lock and don't set > pc->flags atomically. > > Signed-off-by: Johannes Weiner The patch is corre

[patch 7/9] mm: memcontrol: do not acquire page_cgroup lock for kmem pages

2014-04-30 Thread Johannes Weiner
Kmem page charging and uncharging is serialized by means of exclusive access to the page. Do not take the page_cgroup lock and don't set pc->flags atomically. Signed-off-by: Johannes Weiner --- mm/memcontrol.c | 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a