Re: [patch V2 2/5] x86/kaiser: Simplify disabling of global pages

2017-11-27 Thread Thomas Gleixner
On Mon, 27 Nov 2017, Dave Hansen wrote: > On 11/26/2017 03:14 PM, Thomas Gleixner wrote: > > +static void enable_global_pages(void) > > +{ > > +#ifndef CONFIG_KAISER > > + __supported_pte_mask |= _PAGE_GLOBAL; > > +#endif > > +} > > + > > static void __init probe_page_size_mask(void) > > { >

Re: [patch V2 2/5] x86/kaiser: Simplify disabling of global pages

2017-11-27 Thread Thomas Gleixner
On Mon, 27 Nov 2017, Dave Hansen wrote: > On 11/26/2017 03:14 PM, Thomas Gleixner wrote: > > +static void enable_global_pages(void) > > +{ > > +#ifndef CONFIG_KAISER > > + __supported_pte_mask |= _PAGE_GLOBAL; > > +#endif > > +} > > + > > static void __init probe_page_size_mask(void) > > { >

Re: [patch V2 2/5] x86/kaiser: Simplify disabling of global pages

2017-11-27 Thread Dave Hansen
On 11/26/2017 03:14 PM, Thomas Gleixner wrote: > +static void enable_global_pages(void) > +{ > +#ifndef CONFIG_KAISER > + __supported_pte_mask |= _PAGE_GLOBAL; > +#endif > +} > + > static void __init probe_page_size_mask(void) > { > /* > @@ -179,11 +186,11 @@ static void __init

Re: [patch V2 2/5] x86/kaiser: Simplify disabling of global pages

2017-11-27 Thread Dave Hansen
On 11/26/2017 03:14 PM, Thomas Gleixner wrote: > +static void enable_global_pages(void) > +{ > +#ifndef CONFIG_KAISER > + __supported_pte_mask |= _PAGE_GLOBAL; > +#endif > +} > + > static void __init probe_page_size_mask(void) > { > /* > @@ -179,11 +186,11 @@ static void __init

Re: [patch V2 2/5] x86/kaiser: Simplify disabling of global pages

2017-11-27 Thread Thomas Gleixner
On Mon, 27 Nov 2017, Thomas Gleixner wrote: > /* > @@ -179,11 +186,11 @@ static void __init probe_page_size_mask( > cr4_set_bits_and_update_boot(X86_CR4_PSE); > > /* Enable PGE if available */ > + __supported_pte_mask |= _PAGE_GLOBAL; Bah. Late night reject fixup

Re: [patch V2 2/5] x86/kaiser: Simplify disabling of global pages

2017-11-27 Thread Thomas Gleixner
On Mon, 27 Nov 2017, Thomas Gleixner wrote: > /* > @@ -179,11 +186,11 @@ static void __init probe_page_size_mask( > cr4_set_bits_and_update_boot(X86_CR4_PSE); > > /* Enable PGE if available */ > + __supported_pte_mask |= _PAGE_GLOBAL; Bah. Late night reject fixup

[patch V2 2/5] x86/kaiser: Simplify disabling of global pages

2017-11-26 Thread Thomas Gleixner
The current way of disabling global pages at compile time prevents boot time disabling of kaiser and creates unnecessary indirections. Global pages can be supressed by __supported_pte_mask as well. The shadow mappings set PAGE_GLOBAL for the minimal kernel mappings which are required for

[patch V2 2/5] x86/kaiser: Simplify disabling of global pages

2017-11-26 Thread Thomas Gleixner
The current way of disabling global pages at compile time prevents boot time disabling of kaiser and creates unnecessary indirections. Global pages can be supressed by __supported_pte_mask as well. The shadow mappings set PAGE_GLOBAL for the minimal kernel mappings which are required for