Re: [patch V2 43/67] leds/trigger/cpu: Convert to hotplug state machine

2016-07-18 Thread Jacek Anaszewski
Hi Sebastian, On 07/15/2016 04:10 PM, Sebastian Andrzej Siewior wrote: * Jacek Anaszewski | 2016-07-14 13:55:26 [+0200]: On 07/14/2016 01:33 PM, Thomas Gleixner wrote: That does not explain WHY this needs to happen in the low level bringup phase of the CPU with interrupts disabled and can't

Re: [patch V2 43/67] leds/trigger/cpu: Convert to hotplug state machine

2016-07-18 Thread Jacek Anaszewski
Hi Sebastian, On 07/15/2016 04:10 PM, Sebastian Andrzej Siewior wrote: * Jacek Anaszewski | 2016-07-14 13:55:26 [+0200]: On 07/14/2016 01:33 PM, Thomas Gleixner wrote: That does not explain WHY this needs to happen in the low level bringup phase of the CPU with interrupts disabled and can't

Re: [patch V2 43/67] leds/trigger/cpu: Convert to hotplug state machine

2016-07-15 Thread Sebastian Andrzej Siewior
* Jacek Anaszewski | 2016-07-14 13:55:26 [+0200]: >On 07/14/2016 01:33 PM, Thomas Gleixner wrote: >>That does not explain WHY this needs to happen in the low level bringup phase >>of the CPU with interrupts disabled and can't be done from the normal ONLINE >>callbacks in thread context. > >It was

Re: [patch V2 43/67] leds/trigger/cpu: Convert to hotplug state machine

2016-07-15 Thread Sebastian Andrzej Siewior
* Jacek Anaszewski | 2016-07-14 13:55:26 [+0200]: >On 07/14/2016 01:33 PM, Thomas Gleixner wrote: >>That does not explain WHY this needs to happen in the low level bringup phase >>of the CPU with interrupts disabled and can't be done from the normal ONLINE >>callbacks in thread context. > >It was

Re: [patch V2 43/67] leds/trigger/cpu: Convert to hotplug state machine

2016-07-14 Thread Jacek Anaszewski
On 07/14/2016 01:33 PM, Thomas Gleixner wrote: On Thu, 14 Jul 2016, Jacek Anaszewski wrote: On 07/14/2016 11:41 AM, Peter Zijlstra wrote: On Thu, Jul 14, 2016 at 10:10:55AM +0200, Jacek Anaszewski wrote: On 07/14/2016 09:47 AM, Ingo Molnar wrote: * Jacek Anaszewski

Re: [patch V2 43/67] leds/trigger/cpu: Convert to hotplug state machine

2016-07-14 Thread Jacek Anaszewski
On 07/14/2016 01:33 PM, Thomas Gleixner wrote: On Thu, 14 Jul 2016, Jacek Anaszewski wrote: On 07/14/2016 11:41 AM, Peter Zijlstra wrote: On Thu, Jul 14, 2016 at 10:10:55AM +0200, Jacek Anaszewski wrote: On 07/14/2016 09:47 AM, Ingo Molnar wrote: * Jacek Anaszewski wrote: @@ -133,7

Re: [patch V2 43/67] leds/trigger/cpu: Convert to hotplug state machine

2016-07-14 Thread Thomas Gleixner
On Thu, 14 Jul 2016, Jacek Anaszewski wrote: > On 07/14/2016 11:41 AM, Peter Zijlstra wrote: > > On Thu, Jul 14, 2016 at 10:10:55AM +0200, Jacek Anaszewski wrote: > > > On 07/14/2016 09:47 AM, Ingo Molnar wrote: > > > > > > > > * Jacek Anaszewski wrote: > > > > > > > >

Re: [patch V2 43/67] leds/trigger/cpu: Convert to hotplug state machine

2016-07-14 Thread Thomas Gleixner
On Thu, 14 Jul 2016, Jacek Anaszewski wrote: > On 07/14/2016 11:41 AM, Peter Zijlstra wrote: > > On Thu, Jul 14, 2016 at 10:10:55AM +0200, Jacek Anaszewski wrote: > > > On 07/14/2016 09:47 AM, Ingo Molnar wrote: > > > > > > > > * Jacek Anaszewski wrote: > > > > > > > > > > @@ -133,7 +125,13 @@

Re: [patch V2 43/67] leds/trigger/cpu: Convert to hotplug state machine

2016-07-14 Thread Jacek Anaszewski
On 07/14/2016 11:41 AM, Peter Zijlstra wrote: On Thu, Jul 14, 2016 at 10:10:55AM +0200, Jacek Anaszewski wrote: On 07/14/2016 09:47 AM, Ingo Molnar wrote: * Jacek Anaszewski wrote: @@ -133,7 +125,13 @@ static int __init ledtrig_cpu_init(void) }

Re: [patch V2 43/67] leds/trigger/cpu: Convert to hotplug state machine

2016-07-14 Thread Jacek Anaszewski
On 07/14/2016 11:41 AM, Peter Zijlstra wrote: On Thu, Jul 14, 2016 at 10:10:55AM +0200, Jacek Anaszewski wrote: On 07/14/2016 09:47 AM, Ingo Molnar wrote: * Jacek Anaszewski wrote: @@ -133,7 +125,13 @@ static int __init ledtrig_cpu_init(void) }

Re: [patch V2 43/67] leds/trigger/cpu: Convert to hotplug state machine

2016-07-14 Thread Peter Zijlstra
On Thu, Jul 14, 2016 at 10:10:55AM +0200, Jacek Anaszewski wrote: > On 07/14/2016 09:47 AM, Ingo Molnar wrote: > > > >* Jacek Anaszewski wrote: > > > >>>@@ -133,7 +125,13 @@ static int __init ledtrig_cpu_init(void) > >>> } > >>> > >>>

Re: [patch V2 43/67] leds/trigger/cpu: Convert to hotplug state machine

2016-07-14 Thread Peter Zijlstra
On Thu, Jul 14, 2016 at 10:10:55AM +0200, Jacek Anaszewski wrote: > On 07/14/2016 09:47 AM, Ingo Molnar wrote: > > > >* Jacek Anaszewski wrote: > > > >>>@@ -133,7 +125,13 @@ static int __init ledtrig_cpu_init(void) > >>> } > >>> > >>> register_syscore_ops(_cpu_syscore_ops); > >>>-

Re: [patch V2 43/67] leds/trigger/cpu: Convert to hotplug state machine

2016-07-14 Thread Jacek Anaszewski
On 07/14/2016 09:47 AM, Ingo Molnar wrote: * Jacek Anaszewski wrote: @@ -133,7 +125,13 @@ static int __init ledtrig_cpu_init(void) } register_syscore_ops(_cpu_syscore_ops); - register_cpu_notifier(_cpu_nb); + + /* + * FIXME: Why needs

Re: [patch V2 43/67] leds/trigger/cpu: Convert to hotplug state machine

2016-07-14 Thread Jacek Anaszewski
On 07/14/2016 09:47 AM, Ingo Molnar wrote: * Jacek Anaszewski wrote: @@ -133,7 +125,13 @@ static int __init ledtrig_cpu_init(void) } register_syscore_ops(_cpu_syscore_ops); - register_cpu_notifier(_cpu_nb); + + /* + * FIXME: Why needs this to happen in the

Re: [patch V2 43/67] leds/trigger/cpu: Convert to hotplug state machine

2016-07-14 Thread Ingo Molnar
* Jacek Anaszewski wrote: > > @@ -133,7 +125,13 @@ static int __init ledtrig_cpu_init(void) > > } > > > > register_syscore_ops(_cpu_syscore_ops); > > - register_cpu_notifier(_cpu_nb); > > + > > + /* > > + * FIXME: Why needs this to happen in

Re: [patch V2 43/67] leds/trigger/cpu: Convert to hotplug state machine

2016-07-14 Thread Ingo Molnar
* Jacek Anaszewski wrote: > > @@ -133,7 +125,13 @@ static int __init ledtrig_cpu_init(void) > > } > > > > register_syscore_ops(_cpu_syscore_ops); > > - register_cpu_notifier(_cpu_nb); > > + > > + /* > > + * FIXME: Why needs this to happen in the interrupt disabled > > +

Re: [patch V2 43/67] leds/trigger/cpu: Convert to hotplug state machine

2016-07-14 Thread Jacek Anaszewski
Hi Anna, On 07/13/2016 07:16 PM, Anna-Maria Gleixner wrote: > Original Message > Subject: [patch V2 43/67] leds/trigger/cpu: Convert to hotplug state machine > Date: Wed, 13 Jul 2016 17:16:45 + > From: Anna-Maria Gleixner <anna-ma...@linutronix.de>

Re: [patch V2 43/67] leds/trigger/cpu: Convert to hotplug state machine

2016-07-14 Thread Jacek Anaszewski
Hi Anna, On 07/13/2016 07:16 PM, Anna-Maria Gleixner wrote: > Original Message > Subject: [patch V2 43/67] leds/trigger/cpu: Convert to hotplug state machine > Date: Wed, 13 Jul 2016 17:16:45 + > From: Anna-Maria Gleixner > To: LKML > CC: Peter Zijl

[patch V2 43/67] leds/trigger/cpu: Convert to hotplug state machine

2016-07-13 Thread Anna-Maria Gleixner
From: Richard Cochran This is a straightforward conversion. We place this callback last in the list so that the LED illuminates only after a successful bring up sequence. Signed-off-by: Richard Cochran Reviewed-by: Sebastian Andrzej Siewior

[patch V2 43/67] leds/trigger/cpu: Convert to hotplug state machine

2016-07-13 Thread Anna-Maria Gleixner
From: Richard Cochran This is a straightforward conversion. We place this callback last in the list so that the LED illuminates only after a successful bring up sequence. Signed-off-by: Richard Cochran Reviewed-by: Sebastian Andrzej Siewior Cc: Jacek Anaszewski Cc: Linus Torvalds Cc: Linus