Re: [patch V4 part 1 03/36] sched: Clean up scheduler_ipi()

2020-05-06 Thread Paul E. McKenney
On Wed, May 06, 2020 at 08:37:03PM +0200, Peter Zijlstra wrote: > On Wed, May 06, 2020 at 11:28:56AM -0700, Paul E. McKenney wrote: > > I still see warnings of the form "leave instruction with modified stack > > frame" from older complilers and of the form "undefined stack state" > > from newer

Re: [patch V4 part 1 03/36] sched: Clean up scheduler_ipi()

2020-05-06 Thread Peter Zijlstra
On Wed, May 06, 2020 at 11:28:56AM -0700, Paul E. McKenney wrote: > I still see warnings of the form "leave instruction with modified stack > frame" from older complilers and of the form "undefined stack state" > from newer compilers. I am running stock objtool versions, so I am > guessing that

Re: [patch V4 part 1 03/36] sched: Clean up scheduler_ipi()

2020-05-06 Thread Paul E. McKenney
On Wed, May 06, 2020 at 05:33:00PM +0200, Peter Zijlstra wrote: > On Wed, May 06, 2020 at 02:37:19PM +0200, Alexandre Chartre wrote: > > On 5/5/20 3:16 PM, Thomas Gleixner wrote: > > > @@ -650,6 +655,16 @@ static inline bool got_nohz_idle_kick(vo > > > return false; > > > } > > >

Re: [patch V4 part 1 03/36] sched: Clean up scheduler_ipi()

2020-05-06 Thread Peter Zijlstra
On Wed, May 06, 2020 at 02:37:19PM +0200, Alexandre Chartre wrote: > On 5/5/20 3:16 PM, Thomas Gleixner wrote: > > @@ -650,6 +655,16 @@ static inline bool got_nohz_idle_kick(vo > > return false; > > } > > +static void nohz_csd_func(void *info) > > +{ > > + struct rq *rq = info; > > + > > +

Re: [patch V4 part 1 03/36] sched: Clean up scheduler_ipi()

2020-05-06 Thread Thomas Gleixner
Alexandre Chartre writes: > On 5/5/20 3:16 PM, Thomas Gleixner wrote: >> @@ -10009,12 +10009,11 @@ static void kick_ilb(unsigned int flags) >> return; >> >> /* >> - * Use smp_send_reschedule() instead of resched_cpu(). >> - * This way we generate a sched IPI on the

Re: [patch V4 part 1 03/36] sched: Clean up scheduler_ipi()

2020-05-06 Thread Alexandre Chartre
On 5/5/20 3:16 PM, Thomas Gleixner wrote: The scheduler IPI has grown weird and wonderful over the years, time for spring cleaning. Move all the non-trivial stuff out of it and into a regular smp function call IPI. This then reduces the schedule_ipi() to most of it's former MOP glory and

Re: [patch V4 part 1 03/36] sched: Clean up scheduler_ipi()

2020-05-06 Thread Borislav Petkov
On Wed, May 06, 2020 at 11:12:35AM +0200, Thomas Gleixner wrote: > It was NOP long ago. Now it's Minimal OPeration :) LOL, a new instruction: MOP. I can think of a couple of x86 instructions which can be MOPs. :-P -- Regards/Gruss, Boris.

Re: [patch V4 part 1 03/36] sched: Clean up scheduler_ipi()

2020-05-06 Thread Thomas Gleixner
Borislav Petkov writes: > On Tue, May 05, 2020 at 03:16:05PM +0200, Thomas Gleixner wrote: >> The scheduler IPI has grown weird and wonderful over the years, time >> for spring cleaning. >> >> Move all the non-trivial stuff out of it and into a regular smp function >> call IPI. This then

Re: [patch V4 part 1 03/36] sched: Clean up scheduler_ipi()

2020-05-06 Thread Borislav Petkov
On Tue, May 05, 2020 at 03:16:05PM +0200, Thomas Gleixner wrote: > The scheduler IPI has grown weird and wonderful over the years, time > for spring cleaning. > > Move all the non-trivial stuff out of it and into a regular smp function > call IPI. This then reduces the schedule_ipi() to most of

Re: [patch V4 part 1 03/36] sched: Clean up scheduler_ipi()

2020-05-06 Thread Thomas Gleixner
Thomas Gleixner writes: Bah. I managed to lose the From: Peterz line somehow.

[patch V4 part 1 03/36] sched: Clean up scheduler_ipi()

2020-05-05 Thread Thomas Gleixner
The scheduler IPI has grown weird and wonderful over the years, time for spring cleaning. Move all the non-trivial stuff out of it and into a regular smp function call IPI. This then reduces the schedule_ipi() to most of it's former MOP glory and ensures to keep the interrupt vector lean and