Re: [patch V4 part 3 04/29] x86/traps: Make interrupt enable/disable symmetric in C code

2020-05-08 Thread Andy Lutomirski
On Tue, May 5, 2020 at 7:15 AM Thomas Gleixner wrote: > > Traps enable interrupts conditionally but rely on the ASM return code to > disable them again. That results in redundant interrupt disable and trace > calls. > > Make the trap handlers disable interrupts before returning to avoid that, >

Re: [patch V4 part 3 04/29] x86/traps: Make interrupt enable/disable symmetric in C code

2020-05-07 Thread Thomas Gleixner
Alexandre Chartre writes: > On 5/5/20 3:43 PM, Thomas Gleixner wrote: >> Traps enable interrupts conditionally but rely on the ASM return code to >> disable them again. That results in redundant interrupt disable and trace >> calls. >> >> Make the trap handlers disable interrupts before

Re: [patch V4 part 3 04/29] x86/traps: Make interrupt enable/disable symmetric in C code

2020-05-07 Thread Alexandre Chartre
On 5/5/20 3:43 PM, Thomas Gleixner wrote: Traps enable interrupts conditionally but rely on the ASM return code to disable them again. That results in redundant interrupt disable and trace calls. Make the trap handlers disable interrupts before returning to avoid that, which allows

[patch V4 part 3 04/29] x86/traps: Make interrupt enable/disable symmetric in C code

2020-05-05 Thread Thomas Gleixner
Traps enable interrupts conditionally but rely on the ASM return code to disable them again. That results in redundant interrupt disable and trace calls. Make the trap handlers disable interrupts before returning to avoid that, which allows simplification of the ASM entry code. Originally-by: