Re: [patch V6 36/37] x86/entry: Move paranoid irq tracing out of ASM code

2020-05-20 Thread Thomas Gleixner
Andy Lutomirski writes: > On Wed, May 20, 2020 at 8:17 AM Thomas Gleixner wrote: >> >> Andy Lutomirski writes: >> >> > On Fri, May 15, 2020 at 5:11 PM Thomas Gleixner wrote: >> > >> > I think something's missing here. With this patch applied, don't we >> > get to exc_debug_kernel() ->

Re: [patch V6 36/37] x86/entry: Move paranoid irq tracing out of ASM code

2020-05-20 Thread Andy Lutomirski
On Wed, May 20, 2020 at 8:17 AM Thomas Gleixner wrote: > > Andy Lutomirski writes: > > > On Fri, May 15, 2020 at 5:11 PM Thomas Gleixner wrote: > > > > I think something's missing here. With this patch applied, don't we > > get to exc_debug_kernel() -> handle_debug() without doing > >

Re: [patch V6 36/37] x86/entry: Move paranoid irq tracing out of ASM code

2020-05-20 Thread Thomas Gleixner
Andy Lutomirski writes: > On Fri, May 15, 2020 at 5:11 PM Thomas Gleixner wrote: > > I think something's missing here. With this patch applied, don't we > get to exc_debug_kernel() -> handle_debug() without doing > idtentry_enter() or equivalent? And that can even enable IRQs. > > Maybe

Re: [patch V6 36/37] x86/entry: Move paranoid irq tracing out of ASM code

2020-05-19 Thread Andy Lutomirski
On Fri, May 15, 2020 at 5:11 PM Thomas Gleixner wrote: > I think something's missing here. With this patch applied, don't we get to exc_debug_kernel() -> handle_debug() without doing idtentry_enter() or equivalent? And that can even enable IRQs. Maybe exc_debug_kernel() should wrap

[patch V6 36/37] x86/entry: Move paranoid irq tracing out of ASM code

2020-05-15 Thread Thomas Gleixner
Signed-off-by: Thomas Gleixner --- arch/x86/entry/entry_64.S | 13 - arch/x86/kernel/nmi.c |3 +++ 2 files changed, 3 insertions(+), 13 deletions(-) --- a/arch/x86/entry/entry_64.S +++ b/arch/x86/entry/entry_64.S @@ -16,7 +16,6 @@ * * Some macro usage: * -