Re: [patch core/stackprotector] stackprotector: Fix build when compiler lacks support

2014-01-05 Thread Sam Ravnborg
Hi all. > > > > config CC_SUPPORTS_STACKPROTECTOR_STRONG > > bool > > option exec="$CC -fstack-protector-strong -c empty.c" > > > > or something like that. No? > > This is an implementation detail, but the original patch expected the > result to be 'y' or 'n' (or empty=='n') on st

Re: [patch core/stackprotector] stackprotector: Fix build when compiler lacks support

2014-01-01 Thread Yann E. MORIN
Linus, All, On 2014-01-01 11:33 -0800, Linus Torvalds spake thusly: > On Wed, Jan 1, 2014 at 3:42 AM, Yann E. MORIN wrote: > > > > On 2013-12-31 16:16 -0800, Linus Torvalds spake thusly: > >> > >> What we really really want to do is to have some way to add config > >> options based on shell scrip

Re: [patch core/stackprotector] stackprotector: Fix build when compiler lacks support

2014-01-01 Thread H. Peter Anvin
On 01/01/2014 11:33 AM, Linus Torvalds wrote: > > Ack. Looks good to me. I've wanted this for a long time for other > reasons, we should finally just do it. > Yes, we keep avoiding doing this by layering hack upon hack, but really... it needs to be done. The chief objection I've heard is that i

Re: [patch core/stackprotector] stackprotector: Fix build when compiler lacks support

2014-01-01 Thread Linus Torvalds
On Wed, Jan 1, 2014 at 3:42 AM, Yann E. MORIN wrote: > > On 2013-12-31 16:16 -0800, Linus Torvalds spake thusly: >> >> What we really really want to do is to have some way to add config >> options based on shell scripts and compiler support. That would also >> get rid of a lot of Makefile trickery

Re: [patch core/stackprotector] stackprotector: Fix build when compiler lacks support

2014-01-01 Thread Yann E. MORIN
Linus, All, On 2013-12-31 16:16 -0800, Linus Torvalds spake thusly: > On Mon, Dec 30, 2013 at 4:45 PM, Kees Cook wrote: > > > > NAK. If you have selected CONFIG_CC_STACKPROTECTOR_STRONG, the build > > the fail hard. Without this, it means you'll end up with kernels that > > build and show a stack

Re: [patch core/stackprotector] stackprotector: Fix build when compiler lacks support

2013-12-31 Thread Linus Torvalds
On Mon, Dec 30, 2013 at 4:45 PM, Kees Cook wrote: > > NAK. If you have selected CONFIG_CC_STACKPROTECTOR_STRONG, the build > the fail hard. Without this, it means you'll end up with kernels that > build and show a stackprotector option in their config, which is > false. What we really really want

Re: [patch core/stackprotector] stackprotector: Fix build when compiler lacks support

2013-12-31 Thread Arjan van de Ven
On 12/30/2013 1:37 PM, David Rientjes wrote: 8779657d29c0 ("stackprotector: Introduce CONFIG_CC_STACKPROTECTOR_STRONG") causes the build to break when the compiler doesn't support -fstack-protector-strong: cc1: error: unrecognized command line option ‘-fstack-protector-strong’ cc

Re: [patch core/stackprotector] stackprotector: Fix build when compiler lacks support

2013-12-30 Thread Kees Cook
On Mon, Dec 30, 2013 at 1:37 PM, David Rientjes wrote: > 8779657d29c0 ("stackprotector: Introduce CONFIG_CC_STACKPROTECTOR_STRONG") > causes the build to break when the compiler doesn't support > -fstack-protector-strong: > > cc1: error: unrecognized command line option > ‘-fstack-protect

[patch core/stackprotector] stackprotector: Fix build when compiler lacks support

2013-12-30 Thread David Rientjes
8779657d29c0 ("stackprotector: Introduce CONFIG_CC_STACKPROTECTOR_STRONG") causes the build to break when the compiler doesn't support -fstack-protector-strong: cc1: error: unrecognized command line option ‘-fstack-protector-strong’ cc1: error: unrecognized command line option ‘-