Re: [patch for-3.7] fs, xattr: fix bug when removing a name not in xattr list

2012-10-18 Thread Aristeu Rozanski
On Wed, Oct 17, 2012 at 08:41:15PM -0700, David Rientjes wrote: > Commit 38f38657444d ("xattr: extract simple_xattr code from tmpfs") moved > some code from tmpfs but introduced a subtle bug along the way. > > If the name passed to simple_xattr_remove() does not exist in the list of > xattrs, then

Re: [patch for-3.7] fs, xattr: fix bug when removing a name not in xattr list

2012-10-18 Thread Hillf Danton
Hi David, On Thu, Oct 18, 2012 at 11:41 AM, David Rientjes wrote: > Commit 38f38657444d ("xattr: extract simple_xattr code from tmpfs") moved > some code from tmpfs but introduced a subtle bug along the way. > That commit is fine but you did revert commit b9d6cfdeaf67(xattr: mark variable as unin

Re: [patch for-3.7] fs, xattr: fix bug when removing a name not in xattr list

2012-10-17 Thread Al Viro
On Wed, Oct 17, 2012 at 08:55:49PM -0700, Hugh Dickins wrote: > On Wed, 17 Oct 2012, David Rientjes wrote: > > > Commit 38f38657444d ("xattr: extract simple_xattr code from tmpfs") moved > > some code from tmpfs but introduced a subtle bug along the way. > > > > If the name passed to simple_xattr

Re: [patch for-3.7] fs, xattr: fix bug when removing a name not in xattr list

2012-10-17 Thread Hugh Dickins
On Wed, 17 Oct 2012, David Rientjes wrote: > Commit 38f38657444d ("xattr: extract simple_xattr code from tmpfs") moved > some code from tmpfs but introduced a subtle bug along the way. > > If the name passed to simple_xattr_remove() does not exist in the list of > xattrs, then it is possible to c

[patch for-3.7] fs, xattr: fix bug when removing a name not in xattr list

2012-10-17 Thread David Rientjes
Commit 38f38657444d ("xattr: extract simple_xattr code from tmpfs") moved some code from tmpfs but introduced a subtle bug along the way. If the name passed to simple_xattr_remove() does not exist in the list of xattrs, then it is possible to call kfree(new_xattr) when new_xattr is actually initia