Re: [patch for-3.8] fs, dlm: fix build error when EXPERIMENTAL is disabled

2013-02-12 Thread David Rientjes
On Tue, 12 Feb 2013, Linus Torvalds wrote: > On Tue, Feb 12, 2013 at 1:50 AM, Steven Whitehouse > wrote: > > > > That doesn't seem right to me... DLM has not been experimental for a > > long time now. Why not just select CRC32 in addition to IP_SCTP ? > > Hmm. IP_SCTP already does a "select lib

Re: [patch for-3.8] fs, dlm: fix build error when EXPERIMENTAL is disabled

2013-02-12 Thread Linus Torvalds
On Tue, Feb 12, 2013 at 1:50 AM, Steven Whitehouse wrote: > > That doesn't seem right to me... DLM has not been experimental for a > long time now. Why not just select CRC32 in addition to IP_SCTP ? Hmm. IP_SCTP already does a "select libcrc32c". So why doesn't that end up working?

Re: [patch for-3.8] fs, dlm: fix build error when EXPERIMENTAL is disabled

2013-02-12 Thread Steven Whitehouse
Hi, On Mon, 2013-02-11 at 13:48 -0800, David Rientjes wrote: > CONFIG_IP_SCTP relies on being able to select things like CONFIG_CRC32C to > build. Thus, nothing should be selecting CONFIG_IP_SCTP that does not > meet its requirements. > > For example, if CONFIG_EXPERIMENTAL is disabled and CON

[patch for-3.8] fs, dlm: fix build error when EXPERIMENTAL is disabled

2013-02-11 Thread David Rientjes
CONFIG_IP_SCTP relies on being able to select things like CONFIG_CRC32C to build. Thus, nothing should be selecting CONFIG_IP_SCTP that does not meet its requirements. For example, if CONFIG_EXPERIMENTAL is disabled and CONFIG_DLM is enabled, the build fails at link time: net/built-in