[patch for-4.7] mm, compaction: prevent VM_BUG_ON when terminating freeing scanner fix

2016-07-11 Thread David Rientjes
On Wed, 6 Jul 2016, Joonsoo Kim wrote: > > diff --git a/mm/compaction.c b/mm/compaction.c > > --- a/mm/compaction.c > > +++ b/mm/compaction.c > > @@ -1009,8 +1009,6 @@ static void isolate_freepages(struct compact_control > > *cc) > > block_end_pfn = block_start_pfn, >

[patch for-4.7] mm, compaction: prevent VM_BUG_ON when terminating freeing scanner fix

2016-07-11 Thread David Rientjes
On Wed, 6 Jul 2016, Joonsoo Kim wrote: > > diff --git a/mm/compaction.c b/mm/compaction.c > > --- a/mm/compaction.c > > +++ b/mm/compaction.c > > @@ -1009,8 +1009,6 @@ static void isolate_freepages(struct compact_control > > *cc) > > block_end_pfn = block_start_pfn, >

Re: [patch for-4.7] mm, compaction: prevent VM_BUG_ON when terminating freeing scanner

2016-07-06 Thread Minchan Kim
On Wed, Jun 29, 2016 at 02:47:20PM -0700, David Rientjes wrote: > It's possible to isolate some freepages in a pageblock and then fail > split_free_page() due to the low watermark check. In this case, we hit > VM_BUG_ON() because the freeing scanner terminated early without a > contended lock

Re: [patch for-4.7] mm, compaction: prevent VM_BUG_ON when terminating freeing scanner

2016-07-06 Thread Minchan Kim
On Wed, Jun 29, 2016 at 02:47:20PM -0700, David Rientjes wrote: > It's possible to isolate some freepages in a pageblock and then fail > split_free_page() due to the low watermark check. In this case, we hit > VM_BUG_ON() because the freeing scanner terminated early without a > contended lock

Re: [patch for-4.7] mm, compaction: prevent VM_BUG_ON when terminating freeing scanner

2016-07-05 Thread Minchan Kim
On Wed, Jul 06, 2016 at 10:41:09AM +0900, Joonsoo Kim wrote: < snip > > > Do you have any objection to this fix for 4.7? > > > > Joonson and/or Minchan, does this address the issue that you reported? > > Unfortunately, I have no test case to trigger it. But, I think that > this patch will

Re: [patch for-4.7] mm, compaction: prevent VM_BUG_ON when terminating freeing scanner

2016-07-05 Thread Minchan Kim
On Wed, Jul 06, 2016 at 10:41:09AM +0900, Joonsoo Kim wrote: < snip > > > Do you have any objection to this fix for 4.7? > > > > Joonson and/or Minchan, does this address the issue that you reported? > > Unfortunately, I have no test case to trigger it. But, I think that > this patch will

Re: [patch for-4.7] mm, compaction: prevent VM_BUG_ON when terminating freeing scanner

2016-07-05 Thread Joonsoo Kim
On Tue, Jul 05, 2016 at 02:01:29PM -0700, David Rientjes wrote: > On Thu, 30 Jun 2016, Vlastimil Babka wrote: > > > > Note: I really dislike the low watermark check in split_free_page() and > > > consider it poor software engineering. The function should split a free > > > page, nothing more.

Re: [patch for-4.7] mm, compaction: prevent VM_BUG_ON when terminating freeing scanner

2016-07-05 Thread Joonsoo Kim
On Tue, Jul 05, 2016 at 02:01:29PM -0700, David Rientjes wrote: > On Thu, 30 Jun 2016, Vlastimil Babka wrote: > > > > Note: I really dislike the low watermark check in split_free_page() and > > > consider it poor software engineering. The function should split a free > > > page, nothing more.

Re: [patch for-4.7] mm, compaction: prevent VM_BUG_ON when terminating freeing scanner

2016-07-05 Thread Joonsoo Kim
On Wed, Jun 29, 2016 at 02:47:20PM -0700, David Rientjes wrote: > It's possible to isolate some freepages in a pageblock and then fail > split_free_page() due to the low watermark check. In this case, we hit > VM_BUG_ON() because the freeing scanner terminated early without a > contended lock

Re: [patch for-4.7] mm, compaction: prevent VM_BUG_ON when terminating freeing scanner

2016-07-05 Thread Joonsoo Kim
On Wed, Jun 29, 2016 at 02:47:20PM -0700, David Rientjes wrote: > It's possible to isolate some freepages in a pageblock and then fail > split_free_page() due to the low watermark check. In this case, we hit > VM_BUG_ON() because the freeing scanner terminated early without a > contended lock

Re: [patch for-4.7] mm, compaction: prevent VM_BUG_ON when terminating freeing scanner

2016-07-05 Thread Vlastimil Babka
On 07/05/2016 11:01 PM, David Rientjes wrote: > On Thu, 30 Jun 2016, Vlastimil Babka wrote: > >>> Note: I really dislike the low watermark check in split_free_page() and >>> consider it poor software engineering. The function should split a free >>> page, nothing more. Terminating memory

Re: [patch for-4.7] mm, compaction: prevent VM_BUG_ON when terminating freeing scanner

2016-07-05 Thread Vlastimil Babka
On 07/05/2016 11:01 PM, David Rientjes wrote: > On Thu, 30 Jun 2016, Vlastimil Babka wrote: > >>> Note: I really dislike the low watermark check in split_free_page() and >>> consider it poor software engineering. The function should split a free >>> page, nothing more. Terminating memory

Re: [patch for-4.7] mm, compaction: prevent VM_BUG_ON when terminating freeing scanner

2016-07-05 Thread David Rientjes
On Thu, 30 Jun 2016, Vlastimil Babka wrote: > > Note: I really dislike the low watermark check in split_free_page() and > > consider it poor software engineering. The function should split a free > > page, nothing more. Terminating memory compaction because of a low > > watermark check when

Re: [patch for-4.7] mm, compaction: prevent VM_BUG_ON when terminating freeing scanner

2016-07-05 Thread David Rientjes
On Thu, 30 Jun 2016, Vlastimil Babka wrote: > > Note: I really dislike the low watermark check in split_free_page() and > > consider it poor software engineering. The function should split a free > > page, nothing more. Terminating memory compaction because of a low > > watermark check when

Re: [patch for-4.7] mm, compaction: prevent VM_BUG_ON when terminating freeing scanner

2016-06-30 Thread Vlastimil Babka
On 06/29/2016 11:47 PM, David Rientjes wrote: It's possible to isolate some freepages in a pageblock and then fail split_free_page() due to the low watermark check. In this case, we hit VM_BUG_ON() because the freeing scanner terminated early without a contended lock or enough freepages. This

Re: [patch for-4.7] mm, compaction: prevent VM_BUG_ON when terminating freeing scanner

2016-06-30 Thread Vlastimil Babka
On 06/29/2016 11:47 PM, David Rientjes wrote: It's possible to isolate some freepages in a pageblock and then fail split_free_page() due to the low watermark check. In this case, we hit VM_BUG_ON() because the freeing scanner terminated early without a contended lock or enough freepages. This

Re: [patch for-4.7] mm, compaction: prevent VM_BUG_ON when terminating freeing scanner

2016-06-29 Thread Greg KH
On Wed, Jun 29, 2016 at 02:47:20PM -0700, David Rientjes wrote: > It's possible to isolate some freepages in a pageblock and then fail > split_free_page() due to the low watermark check. In this case, we hit > VM_BUG_ON() because the freeing scanner terminated early without a > contended lock

Re: [patch for-4.7] mm, compaction: prevent VM_BUG_ON when terminating freeing scanner

2016-06-29 Thread Greg KH
On Wed, Jun 29, 2016 at 02:47:20PM -0700, David Rientjes wrote: > It's possible to isolate some freepages in a pageblock and then fail > split_free_page() due to the low watermark check. In this case, we hit > VM_BUG_ON() because the freeing scanner terminated early without a > contended lock

[patch for-4.7] mm, compaction: prevent VM_BUG_ON when terminating freeing scanner

2016-06-29 Thread David Rientjes
It's possible to isolate some freepages in a pageblock and then fail split_free_page() due to the low watermark check. In this case, we hit VM_BUG_ON() because the freeing scanner terminated early without a contended lock or enough freepages. This should never have been a VM_BUG_ON() since

[patch for-4.7] mm, compaction: prevent VM_BUG_ON when terminating freeing scanner

2016-06-29 Thread David Rientjes
It's possible to isolate some freepages in a pageblock and then fail split_free_page() due to the low watermark check. In this case, we hit VM_BUG_ON() because the freeing scanner terminated early without a contended lock or enough freepages. This should never have been a VM_BUG_ON() since