Re: [patch ide-dev 8/9] make ide_task_ioctl() use REQ_DRIVE_TASKFILE

2005-03-02 Thread Jeff Garzik
Bartlomiej Zolnierkiewicz wrote: On Wed, 02 Mar 2005 01:08:56 -0500, Jeff Garzik <[EMAIL PROTECTED]> wrote: Bartlomiej Zolnierkiewicz wrote: Yes but it seems that you've assumed that ioctl == flagged taskfile and fs/internal == normal taskfile which is _not_ what I aim for. I want fully-flagged tas

Re: [patch ide-dev 8/9] make ide_task_ioctl() use REQ_DRIVE_TASKFILE

2005-03-02 Thread Mark Lord
SATA, PATA, or anything else: if it has to cross the PCI bus, a simple readX()/writeX() can stall the CPU for the equivalent of hundreds of instructions. I agree with Jeff, it is always worth even moderately complex logic to avoid I/O. Note that an isolated write{bwl}() *may* be almost free in mo

Re: [patch ide-dev 8/9] make ide_task_ioctl() use REQ_DRIVE_TASKFILE

2005-03-02 Thread Bartlomiej Zolnierkiewicz
On Wed, 02 Mar 2005 01:08:56 -0500, Jeff Garzik <[EMAIL PROTECTED]> wrote: > Bartlomiej Zolnierkiewicz wrote: > > Yes but it seems that you've assumed that ioctl == flagged taskfile > > and fs/internal == normal taskfile which is _not_ what I aim for. > > > > I want fully-flagged taskfile handling

Re: [patch ide-dev 8/9] make ide_task_ioctl() use REQ_DRIVE_TASKFILE

2005-03-01 Thread Jeff Garzik
Bartlomiej Zolnierkiewicz wrote: Yes but it seems that you've assumed that ioctl == flagged taskfile and fs/internal == normal taskfile which is _not_ what I aim for. I want fully-flagged taskfile handling like flagged_taskfile() and "hot path" simpler taskfile handling like do_rw_taskfile() (at le

Re: [patch ide-dev 8/9] make ide_task_ioctl() use REQ_DRIVE_TASKFILE

2005-03-01 Thread Bartlomiej Zolnierkiewicz
On Tue, 1 Mar 2005 18:29:15 +0900, Tejun Heo <[EMAIL PROTECTED]> wrote: > Hello, > > On Tue, Mar 01, 2005 at 09:42:18AM +0100, Bartlomiej Zolnierkiewicz wrote: > > Hello, > > > > On Tue, 1 Mar 2005 13:21:16 +0900, Tejun Heo <[EMAIL PROTECTED]> wrote: > > > > > > So, how do you like the following

Re: [patch ide-dev 8/9] make ide_task_ioctl() use REQ_DRIVE_TASKFILE

2005-03-01 Thread Tejun Heo
Hello, On Tue, Mar 01, 2005 at 09:42:18AM +0100, Bartlomiej Zolnierkiewicz wrote: > Hello, > > On Tue, 1 Mar 2005 13:21:16 +0900, Tejun Heo <[EMAIL PROTECTED]> wrote: > > > > So, how do you like the following set of TFLAG's? > > > > /* struct ata_taskfile flags */ > > > > /* The following si

Re: [patch ide-dev 8/9] make ide_task_ioctl() use REQ_DRIVE_TASKFILE

2005-03-01 Thread Bartlomiej Zolnierkiewicz
Hello, On Tue, 1 Mar 2005 13:21:16 +0900, Tejun Heo <[EMAIL PROTECTED]> wrote: > Hello, Bartlomiej. > Hello, Jeff. > > On Mon, Feb 28, 2005 at 05:14:55PM +0100, Bartlomiej Zolnierkiewicz wrote: > > On Monday 28 February 2005 16:24, Tejun Heo wrote: > > > Bartlomiej Zolnierkiewicz wrote: > > > > >

Re: [patch ide-dev 8/9] make ide_task_ioctl() use REQ_DRIVE_TASKFILE

2005-02-28 Thread Tejun Heo
Oh, Bartlomiej, one more thing. If it isn't too much trouble, can you please set up a bk repository which contains the patches you've posted and whatever you're working on but hasn't yet made into ide-dev tree? So that we don't have to juggle patches back and forth. If you maintain your up-t

Re: [patch ide-dev 8/9] make ide_task_ioctl() use REQ_DRIVE_TASKFILE

2005-02-28 Thread Tejun Heo
Hello, Bartlomiej. Hello, Jeff. On Mon, Feb 28, 2005 at 05:14:55PM +0100, Bartlomiej Zolnierkiewicz wrote: > On Monday 28 February 2005 16:24, Tejun Heo wrote: > > Bartlomiej Zolnierkiewicz wrote: > > > > > > Nope, it works just fine because REQ_DRIVE_TASK used only > > > no-data protocol, please

Re: [patch ide-dev 8/9] make ide_task_ioctl() use REQ_DRIVE_TASKFILE

2005-02-28 Thread Bartlomiej Zolnierkiewicz
Hi, On Monday 28 February 2005 16:24, Tejun Heo wrote: > Hi, > > Bartlomiej Zolnierkiewicz wrote: > > On Sunday 27 February 2005 08:36, Tejun Heo wrote: > > > >> Hello, Bartlomiej. > >> > >> This patch should be modified to use flagged taskfile if the > >>task_end_request_fix patch isn't appl

Re: [patch ide-dev 8/9] make ide_task_ioctl() use REQ_DRIVE_TASKFILE

2005-02-28 Thread Tejun Heo
Hi, Bartlomiej Zolnierkiewicz wrote: On Sunday 27 February 2005 08:36, Tejun Heo wrote: Hello, Bartlomiej. This patch should be modified to use flagged taskfile if the task_end_request_fix patch isn't applied. As non-flagged taskfile won't return valid result registers, TASK ioctl users won't get

Re: [patch ide-dev 8/9] make ide_task_ioctl() use REQ_DRIVE_TASKFILE

2005-02-28 Thread Bartlomiej Zolnierkiewicz
On Sunday 27 February 2005 08:36, Tejun Heo wrote: > Hello, Bartlomiej. > > This patch should be modified to use flagged taskfile if the > task_end_request_fix patch isn't applied. As non-flagged taskfile > won't return valid result registers, TASK ioctl users won't get the > correct register

Re: [patch ide-dev 8/9] make ide_task_ioctl() use REQ_DRIVE_TASKFILE

2005-02-26 Thread Tejun Heo
Hello, Bartlomiej. This patch should be modified to use flagged taskfile if the task_end_request_fix patch isn't applied. As non-flagged taskfile won't return valid result registers, TASK ioctl users won't get the correct register output. IMHO, this flag-to-get-result-registers thing is way t

[patch ide-dev 8/9] make ide_task_ioctl() use REQ_DRIVE_TASKFILE

2005-02-24 Thread Bartlomiej Zolnierkiewicz
ide_task_ioctl() rewritten to use taskfile transport. This is the last user of REQ_DRIVE_TASK. bart: ported to recent IDE changes by me Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> diff -Nru a/drivers/ide/ide-taskfile.c b/drivers/ide/ide-taskfile.c --- a/drivers/ide/ide-taskfile.c2005-0