Re: [patch v2] mfd: vexpress: fix error handling vexpress_syscfg_regmap_init()

2014-06-13 Thread Arnd Bergmann
On Wednesday 11 June 2014, Pawel Moll wrote: > On Wed, 2014-06-11 at 11:17 +0100, Dan Carpenter wrote: > > This function should be returning an ERR_PTR() on failure instead of > > NULL. Also there is a use after free bug if regmap_init() fails because > > we free "func" and then dereference doing

Re: [patch v2] mfd: vexpress: fix error handling vexpress_syscfg_regmap_init()

2014-06-13 Thread Arnd Bergmann
On Wednesday 11 June 2014, Pawel Moll wrote: On Wed, 2014-06-11 at 11:17 +0100, Dan Carpenter wrote: This function should be returning an ERR_PTR() on failure instead of NULL. Also there is a use after free bug if regmap_init() fails because we free func and then dereference doing the

Re: [patch v2] mfd: vexpress: fix error handling vexpress_syscfg_regmap_init()

2014-06-11 Thread Pawel Moll
On Wed, 2014-06-11 at 18:12 +0100, Greg Kroah-Hartman wrote: > I can queue it up. Cool, thanks! Pawel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [patch v2] mfd: vexpress: fix error handling vexpress_syscfg_regmap_init()

2014-06-11 Thread Greg Kroah-Hartman
On Wed, Jun 11, 2014 at 11:33:20AM +0100, Pawel Moll wrote: > On Wed, 2014-06-11 at 11:17 +0100, Dan Carpenter wrote: > > This function should be returning an ERR_PTR() on failure instead of > > NULL. Also there is a use after free bug if regmap_init() fails because > > we free "func" and then

Re: [patch v2] mfd: vexpress: fix error handling vexpress_syscfg_regmap_init()

2014-06-11 Thread Pawel Moll
On Wed, 2014-06-11 at 11:17 +0100, Dan Carpenter wrote: > This function should be returning an ERR_PTR() on failure instead of > NULL. Also there is a use after free bug if regmap_init() fails because > we free "func" and then dereference doing the return. > > Signed-off-by: Dan Carpenter > >

[patch v2] mfd: vexpress: fix error handling vexpress_syscfg_regmap_init()

2014-06-11 Thread Dan Carpenter
This function should be returning an ERR_PTR() on failure instead of NULL. Also there is a use after free bug if regmap_init() fails because we free "func" and then dereference doing the return. Signed-off-by: Dan Carpenter diff --git a/drivers/misc/vexpress-syscfg.c

[patch v2] mfd: vexpress: fix error handling vexpress_syscfg_regmap_init()

2014-06-11 Thread Dan Carpenter
This function should be returning an ERR_PTR() on failure instead of NULL. Also there is a use after free bug if regmap_init() fails because we free func and then dereference doing the return. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/drivers/misc/vexpress-syscfg.c

Re: [patch v2] mfd: vexpress: fix error handling vexpress_syscfg_regmap_init()

2014-06-11 Thread Pawel Moll
On Wed, 2014-06-11 at 11:17 +0100, Dan Carpenter wrote: This function should be returning an ERR_PTR() on failure instead of NULL. Also there is a use after free bug if regmap_init() fails because we free func and then dereference doing the return. Signed-off-by: Dan Carpenter

Re: [patch v2] mfd: vexpress: fix error handling vexpress_syscfg_regmap_init()

2014-06-11 Thread Greg Kroah-Hartman
On Wed, Jun 11, 2014 at 11:33:20AM +0100, Pawel Moll wrote: On Wed, 2014-06-11 at 11:17 +0100, Dan Carpenter wrote: This function should be returning an ERR_PTR() on failure instead of NULL. Also there is a use after free bug if regmap_init() fails because we free func and then dereference

Re: [patch v2] mfd: vexpress: fix error handling vexpress_syscfg_regmap_init()

2014-06-11 Thread Pawel Moll
On Wed, 2014-06-11 at 18:12 +0100, Greg Kroah-Hartman wrote: I can queue it up. Cool, thanks! Pawel -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html