Re: [patch v2] net: hip04: Make tx coalesce timer actually work

2015-04-15 Thread David Miller
From: Thomas Gleixner Date: Tue, 14 Apr 2015 21:42:42 +0200 (CEST) > The code sets the expiry value of the timer to a relative value and > starts it with hrtimer_start_expires. That's fine, but that only works > once. The timer is started in relative mode, so the expiry value gets > overwritten w

Re: [patch v2] net: hip04: Make tx coalesce timer actually work

2015-04-15 Thread Arnd Bergmann
On Tuesday 14 April 2015 21:42:42 Thomas Gleixner wrote: > The code sets the expiry value of the timer to a relative value and > starts it with hrtimer_start_expires. That's fine, but that only works > once. The timer is started in relative mode, so the expiry value gets > overwritten with the abso

Re: [patch v2] net: hip04: Make tx coalesce timer actually work

2015-04-14 Thread Ding Tianhong
On 2015/4/15 3:42, Thomas Gleixner wrote: > The code sets the expiry value of the timer to a relative value and > starts it with hrtimer_start_expires. That's fine, but that only works > once. The timer is started in relative mode, so the expiry value gets > overwritten with the absolut expiry time

[patch v2] net: hip04: Make tx coalesce timer actually work

2015-04-14 Thread Thomas Gleixner
The code sets the expiry value of the timer to a relative value and starts it with hrtimer_start_expires. That's fine, but that only works once. The timer is started in relative mode, so the expiry value gets overwritten with the absolut expiry time (now + expiry). So once the timer expired, a new