Re: [patch v2] x86, UV: integer wrap bug in uv_hub_ipi_value()

2012-12-02 Thread walter harms
Am 02.12.2012 11:44, schrieb Dan Carpenter: > This is a static checker fix. The problem is that we store the bits > from "uv_apicid_hibits" into "apicid" (the high 16 bits) but then we > shift it 16 bit to the left. "apicid" is an int so it wraps and we lose > them. > > Signed-off-by: Dan Carp

[patch v2] x86, UV: integer wrap bug in uv_hub_ipi_value()

2012-12-02 Thread Dan Carpenter
This is a static checker fix. The problem is that we store the bits from "uv_apicid_hibits" into "apicid" (the high 16 bits) but then we shift it 16 bit to the left. "apicid" is an int so it wraps and we lose them. Signed-off-by: Dan Carpenter --- v2: Style fix. Don't use ulong. I don't have