Re: [patch v2 5/6] memcg: further simplify mem_cgroup_iter

2012-11-30 Thread Michal Hocko
On Fri 30-11-12 13:08:35, Glauber Costa wrote: > On 11/26/2012 10:47 PM, Michal Hocko wrote: > > The code would be much more easier to follow if we move the iteration > > outside of the function (to __mem_cgrou_iter_next) so the distinction > > is more clear. > totally nit: Why is it call __mem_cgr

Re: [patch v2 5/6] memcg: further simplify mem_cgroup_iter

2012-11-30 Thread Glauber Costa
On 11/26/2012 10:47 PM, Michal Hocko wrote: > The code would be much more easier to follow if we move the iteration > outside of the function (to __mem_cgrou_iter_next) so the distinction > is more clear. totally nit: Why is it call __mem_cgrou ? What happened to your p ? -- To unsubscribe from t

Re: [patch v2 5/6] memcg: further simplify mem_cgroup_iter

2012-11-29 Thread Kamezawa Hiroyuki
(2012/11/27 3:47), Michal Hocko wrote: > mem_cgroup_iter basically does two things currently. It takes care of > the house keeping (reference counting, raclaim cookie) and it iterates > through a hierarchy tree (by using cgroup generic tree walk). > The code would be much more easier to follow if w

[patch v2 5/6] memcg: further simplify mem_cgroup_iter

2012-11-26 Thread Michal Hocko
mem_cgroup_iter basically does two things currently. It takes care of the house keeping (reference counting, raclaim cookie) and it iterates through a hierarchy tree (by using cgroup generic tree walk). The code would be much more easier to follow if we move the iteration outside of the function (t