Re: [patch v6 6/8] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task

2013-05-15 Thread Alex Shi
On 05/16/2013 01:49 PM, Michael Wang wrote: > On 05/14/2013 03:27 PM, Alex Shi wrote: > [snip] >> > } >> > diff --git a/kernel/sched/proc.c b/kernel/sched/proc.c > This patch seems to be based on 3.10-rc1, while below one > > [patch v6 3/8] sched: set initial value of runnable avg for new forked

Re: [patch v6 6/8] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task

2013-05-15 Thread Michael Wang
Hi, Alex On 05/14/2013 03:27 PM, Alex Shi wrote: [snip] > } > diff --git a/kernel/sched/proc.c b/kernel/sched/proc.c This patch seems to be based on 3.10-rc1, while below one [patch v6 3/8] sched: set initial value of runnable avg for new forked task is conflict with 3.10-rc1... I think it may

Re: [patch v6 6/8] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task

2013-05-14 Thread Alex Shi
On 05/13/2013 10:06 PM, Peter Zijlstra wrote: >> > * See the mess around update_idle_cpu_load() / update_cpu_load_nohz(). > This just smells like you want a helper function... :-) > > Also it doesn't apply anymore due to Paul Gortemaker moving some of this > stuff about. > > patch updated.

Re: [patch v6 6/8] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task

2013-05-13 Thread Alex Shi
On 05/13/2013 10:06 PM, Peter Zijlstra wrote: >> > static void update_cpu_load_active(struct rq *this_rq) >> > { >> > + unsigned long load; >> > + >> > +#ifdef CONFIG_SMP >> > + load = this_rq->cfs.runnable_load_avg; >> > +#else >> > + load = this_rq->load.weight; >> > +#endif >> >/* >> >

Re: [patch v6 6/8] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task

2013-05-13 Thread Peter Zijlstra
On Fri, May 10, 2013 at 11:17:27PM +0800, Alex Shi wrote: > They are the base values in load balance, update them with rq runnable > load average, then the load balance will consider runnable load avg > naturally. > > We also try to include the blocked_load_avg as cpu load in balancing, > but that

[patch v6 6/8] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task

2013-05-10 Thread Alex Shi
They are the base values in load balance, update them with rq runnable load average, then the load balance will consider runnable load avg naturally. We also try to include the blocked_load_avg as cpu load in balancing, but that cause kbuild/aim7/oltp benchmark performance drop. Signed-off-by: Al