Re: [patches] [PATCH] [4/12] x86_64: Disable CLFLUSH support again

On Thu, Aug 09, 2007 at 02:29:58PM +0100, Jan Beulich wrote: > The issue here is not with clflush by itself, but with what pages it > is being applied to. Here, it gets used on page table pages when > flushing really is needed on what one or more page table entries in > that page table page point(

Re: [patches] [PATCH] [4/12] x86_64: Disable CLFLUSH support again

>>> Muli Ben-Yehuda <[EMAIL PROTECTED]> 09.08.07 15:11 >>> >On Thu, Aug 09, 2007 at 02:41:31PM +0200, Andi Kleen wrote: >> >> It turns out CLFLUSH support is still not complete; we >> flush the wrong pages. Again disable it for the release. >> Noticed by Jan Beulich. >> >> Signed-off-by: Andi Kl

Re: [patches] [PATCH] [4/12] x86_64: Disable CLFLUSH support again

The 64-bit conditional seems wrong to me, I'd assume you mean if (1 || !cpu_has_clflush) Jan >>> Andi Kleen <[EMAIL PROTECTED]> 09.08.07 14:41 >>> It turns out CLFLUSH support is still not complete; we flush the wrong pages. Again disable it for the release. Noticed by Jan Beulich. Si