Re: [rfc patch 2/2] rt/locking/hotplug: Fix rt_spin_lock_slowlock() migrate_disable() bug

2016-04-07 Thread Mike Galbraith
On Thu, 2016-04-07 at 18:48 +0200, Sebastian Andrzej Siewior wrote: > On 04/07/2016 06:37 AM, Mike Galbraith wrote: > > On Wed, 2016-04-06 at 14:00 +0200, Mike Galbraith wrote: > > > It'll take a hotplug beating seemingly as well as any non-rt kernel, > > > but big box NAKed it due to jitter, which

Re: [rfc patch 2/2] rt/locking/hotplug: Fix rt_spin_lock_slowlock() migrate_disable() bug

2016-04-07 Thread Sebastian Andrzej Siewior
On 04/07/2016 06:37 AM, Mike Galbraith wrote: > On Wed, 2016-04-06 at 14:00 +0200, Mike Galbraith wrote: >> It'll take a hotplug beating seemingly as well as any non-rt kernel, >> but big box NAKed it due to jitter, which can mean 1.0 things.. duh. > > FWIW, the below turned big box NAK into ACK.

Re: [rfc patch 2/2] rt/locking/hotplug: Fix rt_spin_lock_slowlock() migrate_disable() bug

2016-04-06 Thread Mike Galbraith
On Wed, 2016-04-06 at 14:00 +0200, Mike Galbraith wrote: > It'll take a hotplug beating seemingly as well as any non-rt kernel, > but big box NAKed it due to jitter, which can mean 1.0 things.. duh. FWIW, the below turned big box NAK into ACK. Stressing hotplug over night, iteration completion ti

Re: [rfc patch 2/2] rt/locking/hotplug: Fix rt_spin_lock_slowlock() migrate_disable() bug

2016-04-06 Thread Mike Galbraith
It'll take a hotplug beating seemingly as well as any non-rt kernel, but big box NAKed it due to jitter, which can mean 1.0 things.. duh. -Mike

[rfc patch 2/2] rt/locking/hotplug: Fix rt_spin_lock_slowlock() migrate_disable() bug

2016-04-05 Thread Mike Galbraith
I met a problem while testing shiny new hotplug machinery. migrate_disable() -> pin_current_cpu() -> hotplug_lock() leads to.. BUG_ON(rt_mutex_real_waiter(task->pi_blocked_on)); With hotplug_lock()/hotplug_unlock() now gone, there is no lock added by the CPU pinning code, thus we're free