Re: [rtc] 4cd8adb100: WARNING: CPU: 0 PID: 1 at lib/kobject.c:690 kobject_put

2017-03-16 Thread Greg Kroah-Hartman
On Fri, Mar 17, 2017 at 03:11:37PM +0900, Greg Kroah-Hartman wrote: > On Thu, Mar 16, 2017 at 11:23:26PM -0600, Logan Gunthorpe wrote: > > Hey, > > > > I think I see the issue here: in a couple of error conditions, the RTC > > code will not initialize and ask for the cdev. However, my change will

Re: [rtc] 4cd8adb100: WARNING: CPU: 0 PID: 1 at lib/kobject.c:690 kobject_put

2017-03-16 Thread Greg Kroah-Hartman
On Thu, Mar 16, 2017 at 11:23:26PM -0600, Logan Gunthorpe wrote: > Hey, > > I think I see the issue here: in a couple of error conditions, the RTC > code will not initialize and ask for the cdev. However, my change will > always call cdev_add and cdev_del even though the rtc code did not call > cd

Re: [rtc] 4cd8adb100: WARNING: CPU: 0 PID: 1 at lib/kobject.c:690 kobject_put

2017-03-16 Thread Logan Gunthorpe
Hey, I think I see the issue here: in a couple of error conditions, the RTC code will not initialize and ask for the cdev. However, my change will always call cdev_add and cdev_del even though the rtc code did not call cdev_init. I'll have to add a guard around dev->devt in the new cdev_device fun