Re: [sched] Out of memory: Kill process 2999 (rc) score 9 or sacrifice child

2014-08-10 Thread Kirill Tkhai
10.08.2014, 19:31, "Oleg Nesterov" : > On 08/09, Peter Zijlstra wrote: >>  That would suggest we're failing to do the TASK_DEAD thing properly, and >>  ARGH! bloody obvious why, see the this_rq() comment right before the >>  finish_task_switch() call in context_switch(). > > Off-topic, but perhap

Re: [sched] Out of memory: Kill process 2999 (rc) score 9 or sacrifice child

2014-08-10 Thread Oleg Nesterov
On 08/09, Peter Zijlstra wrote: > > That would suggest we're failing to do the TASK_DEAD thing properly, and > ARGH! bloody obvious why, see the this_rq() comment right before the > finish_task_switch() call in context_switch(). Off-topic, but perhaps we can make this a bit more clear? Hmm. But a

Re: [sched] Out of memory: Kill process 2999 (rc) score 9 or sacrifice child

2014-08-09 Thread Oleg Nesterov
On 08/09, Peter Zijlstra wrote: > > That would suggest we're failing to do the TASK_DEAD thing properly, and > ARGH! bloody obvious why, see the this_rq() comment right before the > finish_task_switch() call in context_switch(). Heh ;) and a similar comment in __schedule() after context_switch().

Re: [sched] Out of memory: Kill process 2999 (rc) score 9 or sacrifice child

2014-08-09 Thread Peter Zijlstra
On Sat, Aug 09, 2014 at 10:30:34PM +0800, Fengguang Wu wrote: > Hi Peter, > > We noticed the below changes on > > git://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git sched/wait > commit d58d631b474c552dce72da2dce9dd276d731b79a ("sched: Fix > finish_task_switch vs prev_state") > > tes

[sched] Out of memory: Kill process 2999 (rc) score 9 or sacrifice child

2014-08-09 Thread Fengguang Wu
Hi Peter, We noticed the below changes on git://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git sched/wait commit d58d631b474c552dce72da2dce9dd276d731b79a ("sched: Fix finish_task_switch vs prev_state") test case: vm-vp-quantal-x86_64/boot/1 9e6e6179961e8dd d58d631b474c552dce72da2dc