Re: [RFC/PATCH 2.6.32.y 0/3] Re: [stable 2.6.32..2.6.34] x86, ioapic: initialize nr_ioapic_registers early in mp_register_ioapic()

2012-11-01 Thread Willy Tarreau
On Wed, Oct 24, 2012 at 06:25:20PM -0700, Eric W. Biederman wrote: > Jonathan Nieder writes: > > > Suresh Siddha wrote: > > > >> Here is the updated patch with just some > >> more text added to the changelog. > > > > Yes, that's clearer. For what it's worth, > >

Re: [RFC/PATCH 2.6.32.y 0/3] Re: [stable 2.6.32..2.6.34] x86, ioapic: initialize nr_ioapic_registers early in mp_register_ioapic()

2012-11-01 Thread Willy Tarreau
On Wed, Oct 24, 2012 at 06:25:20PM -0700, Eric W. Biederman wrote: Jonathan Nieder jrnie...@gmail.com writes: Suresh Siddha wrote: Here is the updated patch with just some more text added to the changelog. Yes, that's clearer. For what it's worth,

Re: [RFC/PATCH 2.6.32.y 0/3] Re: [stable 2.6.32..2.6.34] x86, ioapic: initialize nr_ioapic_registers early in mp_register_ioapic()

2012-10-24 Thread Eric W. Biederman
Jonathan Nieder writes: > Suresh Siddha wrote: > >> Here is the updated patch with just some >> more text added to the changelog. > > Yes, that's clearer. For what it's worth, > Reviewed-by: Jonathan Nieder > > Thanks for your patience. The strange days when code

Re: [RFC/PATCH 2.6.32.y 0/3] Re: [stable 2.6.32..2.6.34] x86, ioapic: initialize nr_ioapic_registers early in mp_register_ioapic()

2012-10-24 Thread Jonathan Nieder
Suresh Siddha wrote: > Here is the updated patch with just some > more text added to the changelog. Yes, that's clearer. For what it's worth, Reviewed-by: Jonathan Nieder Thanks for your patience. -- To unsubscribe from this list: send the line "unsubscribe

Re: [RFC/PATCH 2.6.32.y 0/3] Re: [stable 2.6.32..2.6.34] x86, ioapic: initialize nr_ioapic_registers early in mp_register_ioapic()

2012-10-24 Thread Suresh Siddha
On Wed, 2012-10-24 at 12:41 -0700, Jonathan Nieder wrote: > Suresh Siddha wrote: > > On Wed, 2012-10-24 at 11:25 -0700, Jonathan Nieder wrote: > > >> Why not cherry-pick 7716a5c4ff5 in full? > > > > As that depends on the other commits like: > > commit 4b6b19a1c7302477653d799a53d48063dd53d555 >

[RFC/PATCH 2.6.32.y 0/3] Re: [stable 2.6.32..2.6.34] x86, ioapic: initialize nr_ioapic_registers early in mp_register_ioapic()

2012-10-24 Thread Jonathan Nieder
Suresh Siddha wrote: > On Wed, 2012-10-24 at 11:25 -0700, Jonathan Nieder wrote: >> Why not cherry-pick 7716a5c4ff5 in full? > > As that depends on the other commits like: > commit 4b6b19a1c7302477653d799a53d48063dd53d555 More importantly, if I understand correctly it might depend on commit

Re: [stable 2.6.32..2.6.34] x86, ioapic: initialize nr_ioapic_registers early in mp_register_ioapic()

2012-10-24 Thread Jonathan Nieder
Suresh Siddha wrote: > commit 4b6b19a1c7302477653d799a53d48063dd53d555 Oh, yuck. If that commit had changed io_apic_get_redir_entries()'s name, it would have avoided some trouble. Thanks for pointing it out. > Wanted to keep the changes as minimal as possible. I don't see how this is

Re: [stable 2.6.32..2.6.34] x86, ioapic: initialize nr_ioapic_registers early in mp_register_ioapic()

2012-10-24 Thread Suresh Siddha
On Wed, 2012-10-24 at 11:25 -0700, Jonathan Nieder wrote: > Hi Suresh, > > Suresh Siddha wrote: > > [...] > > This problem doesn't happen with more recent kernels and closer > > look at the 2.6.32 kernel shows that the code which masks > > the IO-APIC RTE's is not working as expected as the

Re: [stable 2.6.32..2.6.34] x86, ioapic: initialize nr_ioapic_registers early in mp_register_ioapic()

2012-10-24 Thread Jonathan Nieder
Hi Suresh, Suresh Siddha wrote: [...] > This problem doesn't happen with more recent kernels and closer > look at the 2.6.32 kernel shows that the code which masks > the IO-APIC RTE's is not working as expected as the nr_ioapic_registers > for each IO-APIC is not yet initialized at this point.

[stable 2.6.32..2.6.34] x86, ioapic: initialize nr_ioapic_registers early in mp_register_ioapic()

2012-10-24 Thread Suresh Siddha
Lin Bao reported that one of the HP platforms failed to boot 2.6.32 kernel, when the BIOS enabled interrupt-remapping and x2apic before handing over the control to the Linux kernel. During boot, Linux kernel masks all the interrupt sources (8259, IO-APIC RTE's), setup the interrupt-remapping

[stable 2.6.32..2.6.34] x86, ioapic: initialize nr_ioapic_registers early in mp_register_ioapic()

2012-10-24 Thread Suresh Siddha
Lin Bao reported that one of the HP platforms failed to boot 2.6.32 kernel, when the BIOS enabled interrupt-remapping and x2apic before handing over the control to the Linux kernel. During boot, Linux kernel masks all the interrupt sources (8259, IO-APIC RTE's), setup the interrupt-remapping

Re: [stable 2.6.32..2.6.34] x86, ioapic: initialize nr_ioapic_registers early in mp_register_ioapic()

2012-10-24 Thread Jonathan Nieder
Hi Suresh, Suresh Siddha wrote: [...] This problem doesn't happen with more recent kernels and closer look at the 2.6.32 kernel shows that the code which masks the IO-APIC RTE's is not working as expected as the nr_ioapic_registers for each IO-APIC is not yet initialized at this point. In

Re: [stable 2.6.32..2.6.34] x86, ioapic: initialize nr_ioapic_registers early in mp_register_ioapic()

2012-10-24 Thread Suresh Siddha
On Wed, 2012-10-24 at 11:25 -0700, Jonathan Nieder wrote: Hi Suresh, Suresh Siddha wrote: [...] This problem doesn't happen with more recent kernels and closer look at the 2.6.32 kernel shows that the code which masks the IO-APIC RTE's is not working as expected as the

Re: [stable 2.6.32..2.6.34] x86, ioapic: initialize nr_ioapic_registers early in mp_register_ioapic()

2012-10-24 Thread Jonathan Nieder
Suresh Siddha wrote: commit 4b6b19a1c7302477653d799a53d48063dd53d555 Oh, yuck. If that commit had changed io_apic_get_redir_entries()'s name, it would have avoided some trouble. Thanks for pointing it out. Wanted to keep the changes as minimal as possible. I don't see how this is

[RFC/PATCH 2.6.32.y 0/3] Re: [stable 2.6.32..2.6.34] x86, ioapic: initialize nr_ioapic_registers early in mp_register_ioapic()

2012-10-24 Thread Jonathan Nieder
Suresh Siddha wrote: On Wed, 2012-10-24 at 11:25 -0700, Jonathan Nieder wrote: Why not cherry-pick 7716a5c4ff5 in full? As that depends on the other commits like: commit 4b6b19a1c7302477653d799a53d48063dd53d555 More importantly, if I understand correctly it might depend on commit

Re: [RFC/PATCH 2.6.32.y 0/3] Re: [stable 2.6.32..2.6.34] x86, ioapic: initialize nr_ioapic_registers early in mp_register_ioapic()

2012-10-24 Thread Suresh Siddha
On Wed, 2012-10-24 at 12:41 -0700, Jonathan Nieder wrote: Suresh Siddha wrote: On Wed, 2012-10-24 at 11:25 -0700, Jonathan Nieder wrote: Why not cherry-pick 7716a5c4ff5 in full? As that depends on the other commits like: commit 4b6b19a1c7302477653d799a53d48063dd53d555 More

Re: [RFC/PATCH 2.6.32.y 0/3] Re: [stable 2.6.32..2.6.34] x86, ioapic: initialize nr_ioapic_registers early in mp_register_ioapic()

2012-10-24 Thread Jonathan Nieder
Suresh Siddha wrote: Here is the updated patch with just some more text added to the changelog. Yes, that's clearer. For what it's worth, Reviewed-by: Jonathan Nieder jrnie...@gmail.com Thanks for your patience. -- To unsubscribe from this list: send the line

Re: [RFC/PATCH 2.6.32.y 0/3] Re: [stable 2.6.32..2.6.34] x86, ioapic: initialize nr_ioapic_registers early in mp_register_ioapic()

2012-10-24 Thread Eric W. Biederman
Jonathan Nieder jrnie...@gmail.com writes: Suresh Siddha wrote: Here is the updated patch with just some more text added to the changelog. Yes, that's clearer. For what it's worth, Reviewed-by: Jonathan Nieder jrnie...@gmail.com Thanks for your patience.