Re: [tip: locking/core] lockdep: Fix usage_traceoverflow

2020-10-30 Thread Peter Zijlstra
On Fri, Oct 30, 2020 at 10:38:06AM +0100, Peter Zijlstra wrote: > > if (!chain_head && ret != 2) { > > if (!check_prevs_add(curr, hlock)) > > I'm not entirely sure that doesn't still trigger the problem. Consider > @chain_head := true. Urgh, clearly my brain

Re: [tip: locking/core] lockdep: Fix usage_traceoverflow

2020-10-30 Thread Peter Zijlstra
On Fri, Oct 30, 2020 at 11:51:18AM +0800, Boqun Feng wrote: > On Wed, Oct 28, 2020 at 08:59:10PM +0100, Peter Zijlstra wrote: > Sorry for the late response. No worries, glad you could have a look. > > So that's commit f611e8cf98ec ("lockdep: Take read/write status in > > consideration when

Re: [tip: locking/core] lockdep: Fix usage_traceoverflow

2020-10-29 Thread Boqun Feng
Hi Peter, On Wed, Oct 28, 2020 at 08:59:10PM +0100, Peter Zijlstra wrote: > On Wed, Oct 28, 2020 at 08:42:09PM +0100, Peter Zijlstra wrote: > > On Wed, Oct 28, 2020 at 05:40:48PM +, Chris Wilson wrote: > > > Quoting Chris Wilson (2020-10-27 16:34:53) > > > > Quoting Peter Zijlstra (2020-10-27

Re: [tip: locking/core] lockdep: Fix usage_traceoverflow

2020-10-28 Thread Chris Wilson
Quoting Chris Wilson (2020-10-28 17:40:48) > Quoting Chris Wilson (2020-10-27 16:34:53) > > Quoting Peter Zijlstra (2020-10-27 15:45:33) > > > On Tue, Oct 27, 2020 at 01:29:10PM +, Chris Wilson wrote: > > > > > > > <4> [304.908891] hm#2, depth: 6 [6], 3425cfea6ff31f7f != > > > >

Re: [tip: locking/core] lockdep: Fix usage_traceoverflow

2020-10-28 Thread Chris Wilson
Quoting Chris Wilson (2020-10-27 16:34:53) > Quoting Peter Zijlstra (2020-10-27 15:45:33) > > On Tue, Oct 27, 2020 at 01:29:10PM +, Chris Wilson wrote: > > > > > <4> [304.908891] hm#2, depth: 6 [6], 3425cfea6ff31f7f != 547d92e9ec2ab9af > > > <4> [304.908897] WARNING: CPU: 0 PID: 5658 at > >

Re: [tip: locking/core] lockdep: Fix usage_traceoverflow

2020-10-28 Thread Peter Zijlstra
On Wed, Oct 28, 2020 at 08:42:09PM +0100, Peter Zijlstra wrote: > On Wed, Oct 28, 2020 at 05:40:48PM +, Chris Wilson wrote: > > Quoting Chris Wilson (2020-10-27 16:34:53) > > > Quoting Peter Zijlstra (2020-10-27 15:45:33) > > > > On Tue, Oct 27, 2020 at 01:29:10PM +, Chris Wilson wrote: >

Re: [tip: locking/core] lockdep: Fix usage_traceoverflow

2020-10-28 Thread Peter Zijlstra
On Wed, Oct 28, 2020 at 05:40:48PM +, Chris Wilson wrote: > Quoting Chris Wilson (2020-10-27 16:34:53) > > Quoting Peter Zijlstra (2020-10-27 15:45:33) > > > On Tue, Oct 27, 2020 at 01:29:10PM +, Chris Wilson wrote: > > > > > > > <4> [304.908891] hm#2, depth: 6 [6], 3425cfea6ff31f7f != >

Re: [tip: locking/core] lockdep: Fix usage_traceoverflow

2020-10-27 Thread Chris Wilson
Quoting Peter Zijlstra (2020-10-27 12:48:34) > On Tue, Oct 27, 2020 at 01:30:56PM +0100, Peter Zijlstra wrote: > > This seems to make it happy. Not quite sure that's the best solution. > > > > diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c > > index 3e99dfef8408..81295bc760fe

Re: [tip: locking/core] lockdep: Fix usage_traceoverflow

2020-10-27 Thread Chris Wilson
Quoting Peter Zijlstra (2020-10-27 15:45:33) > On Tue, Oct 27, 2020 at 01:29:10PM +, Chris Wilson wrote: > > > <4> [304.908891] hm#2, depth: 6 [6], 3425cfea6ff31f7f != 547d92e9ec2ab9af > > <4> [304.908897] WARNING: CPU: 0 PID: 5658 at kernel/locking/lockdep.c:3679 > >

Re: [tip: locking/core] lockdep: Fix usage_traceoverflow

2020-10-27 Thread Peter Zijlstra
On Tue, Oct 27, 2020 at 01:29:10PM +, Chris Wilson wrote: > <4> [304.908891] hm#2, depth: 6 [6], 3425cfea6ff31f7f != 547d92e9ec2ab9af > <4> [304.908897] WARNING: CPU: 0 PID: 5658 at kernel/locking/lockdep.c:3679 > check_chain_key+0x1a4/0x1f0 Urgh, I don't think I've _ever_ seen that warning

Re: [tip: locking/core] lockdep: Fix usage_traceoverflow

2020-10-27 Thread Chris Wilson
Quoting Peter Zijlstra (2020-10-27 12:30:56) > On Tue, Oct 27, 2020 at 12:59:55PM +0100, Peter Zijlstra wrote: > > On Tue, Oct 27, 2020 at 11:29:35AM +, Chris Wilson wrote: > > > Quoting tip-bot2 for Peter Zijlstra (2020-10-07 17:20:13) > > > > The following commit has been merged into the

Re: [tip: locking/core] lockdep: Fix usage_traceoverflow

2020-10-27 Thread Peter Zijlstra
On Tue, Oct 27, 2020 at 01:30:56PM +0100, Peter Zijlstra wrote: > This seems to make it happy. Not quite sure that's the best solution. > > diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c > index 3e99dfef8408..81295bc760fe 100644 > --- a/kernel/locking/lockdep.c > +++

Re: [tip: locking/core] lockdep: Fix usage_traceoverflow

2020-10-27 Thread Peter Zijlstra
On Tue, Oct 27, 2020 at 12:59:55PM +0100, Peter Zijlstra wrote: > On Tue, Oct 27, 2020 at 11:29:35AM +, Chris Wilson wrote: > > Quoting tip-bot2 for Peter Zijlstra (2020-10-07 17:20:13) > > > The following commit has been merged into the locking/core branch of tip: > > > > > > Commit-ID:

Re: [tip: locking/core] lockdep: Fix usage_traceoverflow

2020-10-27 Thread Peter Zijlstra
On Tue, Oct 27, 2020 at 11:29:35AM +, Chris Wilson wrote: > Quoting tip-bot2 for Peter Zijlstra (2020-10-07 17:20:13) > > The following commit has been merged into the locking/core branch of tip: > > > > Commit-ID: 24d5a3bffef117ed90685f285c6c9d2faa3a02b4 > > Gitweb: > >

Re: [tip: locking/core] lockdep: Fix usage_traceoverflow

2020-10-27 Thread Chris Wilson
Quoting tip-bot2 for Peter Zijlstra (2020-10-07 17:20:13) > The following commit has been merged into the locking/core branch of tip: > > Commit-ID: 24d5a3bffef117ed90685f285c6c9d2faa3a02b4 > Gitweb: > https://git.kernel.org/tip/24d5a3bffef117ed90685f285c6c9d2faa3a02b4 > Author:

[tip: locking/core] lockdep: Fix usage_traceoverflow

2020-10-09 Thread tip-bot2 for Peter Zijlstra
The following commit has been merged into the locking/core branch of tip: Commit-ID: 2bb8945bcc1a768f2bc402a16c9610bba8d5187d Gitweb: https://git.kernel.org/tip/2bb8945bcc1a768f2bc402a16c9610bba8d5187d Author:Peter Zijlstra AuthorDate:Wed, 30 Sep 2020 11:49:37 +02:00

[tip: locking/core] lockdep: Fix usage_traceoverflow

2020-10-07 Thread tip-bot2 for Peter Zijlstra
The following commit has been merged into the locking/core branch of tip: Commit-ID: 24d5a3bffef117ed90685f285c6c9d2faa3a02b4 Gitweb: https://git.kernel.org/tip/24d5a3bffef117ed90685f285c6c9d2faa3a02b4 Author:Peter Zijlstra AuthorDate:Wed, 30 Sep 2020 11:49:37 +02:00