Re: [tip: objtool/urgent] objtool: Fix seg fault with Clang non-section symbols

2021-02-15 Thread Steven Rostedt
On Mon, 15 Feb 2021 09:58:06 -0600 Josh Poimboeuf wrote: > On Mon, Feb 15, 2021 at 09:53:07AM -0500, Steven Rostedt wrote: > > On Sun, 14 Feb 2021 09:51:47 -0600 > > Josh Poimboeuf wrote: > > > > > Steve, looks like recordmcount avoids referencing weak symbols directly > > > by their function

Re: [tip: objtool/urgent] objtool: Fix seg fault with Clang non-section symbols

2021-02-15 Thread Josh Poimboeuf
On Mon, Feb 15, 2021 at 09:53:07AM -0500, Steven Rostedt wrote: > On Sun, 14 Feb 2021 09:51:47 -0600 > Josh Poimboeuf wrote: > > > Steve, looks like recordmcount avoids referencing weak symbols directly > > by their function symbol. Maybe it can just skip weak symbols which > > don't have a sect

Re: [tip: objtool/urgent] objtool: Fix seg fault with Clang non-section symbols

2021-02-15 Thread Steven Rostedt
On Sun, 14 Feb 2021 09:51:47 -0600 Josh Poimboeuf wrote: > Steve, looks like recordmcount avoids referencing weak symbols directly > by their function symbol. Maybe it can just skip weak symbols which > don't have a section symbol, since this seems like a rare scenario. When does the .text.unli

Re: [tip: objtool/urgent] objtool: Fix seg fault with Clang non-section symbols

2021-02-14 Thread Josh Poimboeuf
On Sat, Feb 13, 2021 at 05:25:18PM +0100, Greg Kroah-Hartman wrote: > On Sat, Feb 13, 2021 at 09:52:03AM -0600, Josh Poimboeuf wrote: > > On Sat, Feb 13, 2021 at 09:13:04AM -0500, Steven Rostedt wrote: > > > On Sat, 13 Feb 2021 15:09:02 +0100 > > > Greg Kroah-Hartman wrote: > > > > > > > Thanks f

Re: [tip: objtool/urgent] objtool: Fix seg fault with Clang non-section symbols

2021-02-13 Thread Greg Kroah-Hartman
On Sat, Feb 13, 2021 at 09:52:03AM -0600, Josh Poimboeuf wrote: > On Sat, Feb 13, 2021 at 09:13:04AM -0500, Steven Rostedt wrote: > > On Sat, 13 Feb 2021 15:09:02 +0100 > > Greg Kroah-Hartman wrote: > > > > > Thanks for the patch, but no, still fails with: > > > > > > Cannot find symbol for sect

Re: [tip: objtool/urgent] objtool: Fix seg fault with Clang non-section symbols

2021-02-13 Thread Josh Poimboeuf
On Sat, Feb 13, 2021 at 09:13:04AM -0500, Steven Rostedt wrote: > On Sat, 13 Feb 2021 15:09:02 +0100 > Greg Kroah-Hartman wrote: > > > Thanks for the patch, but no, still fails with: > > > > Cannot find symbol for section 8: .text.unlikely. > > kernel/kexec_file.o: failed > > make[1]: *** [scrip

Re: [tip: objtool/urgent] objtool: Fix seg fault with Clang non-section symbols

2021-02-13 Thread Steven Rostedt
On Sat, 13 Feb 2021 15:09:02 +0100 Greg Kroah-Hartman wrote: > Thanks for the patch, but no, still fails with: > > Cannot find symbol for section 8: .text.unlikely. > kernel/kexec_file.o: failed > make[1]: *** [scripts/Makefile.build:277: kernel/kexec_file.o] Error 1 > make[1]: *** Deleting file

Re: [tip: objtool/urgent] objtool: Fix seg fault with Clang non-section symbols

2021-02-13 Thread Greg Kroah-Hartman
On Fri, Feb 12, 2021 at 12:45:47PM -0500, Steven Rostedt wrote: > On Fri, 12 Feb 2021 11:07:50 -0600 > Josh Poimboeuf wrote: > > > > > Any ideas are appreciated. > > > > [ Adding Steve Rostedt ] > > > > This error message comes from recordmcount. It probably can't handle > > the missing STT

Re: [tip: objtool/urgent] objtool: Fix seg fault with Clang non-section symbols

2021-02-13 Thread Greg Kroah-Hartman
On Thu, Feb 11, 2021 at 09:32:03PM +0800, Xi Ruoyao wrote: > Hi all, > > The latest GNU assembler (binutils-2.36.1) is removing unused section symbols > like Clang [1]. So linux-5.10.15 can't be built with binutils-2.36.1 now. It > has been reported as https://bugzilla.kernel.org/show_bug.cgi?id

Re: [tip: objtool/urgent] objtool: Fix seg fault with Clang non-section symbols

2021-02-12 Thread Steven Rostedt
On Fri, 12 Feb 2021 11:07:50 -0600 Josh Poimboeuf wrote: > > Any ideas are appreciated. > > [ Adding Steve Rostedt ] > > This error message comes from recordmcount. It probably can't handle > the missing STT_SECTION symbols which are getting stripped by the new > binutils. (Objtool also ha

Re: [tip: objtool/urgent] objtool: Fix seg fault with Clang non-section symbols

2021-02-12 Thread Josh Poimboeuf
On Fri, Feb 12, 2021 at 04:30:49PM +0100, Greg Kroah-Hartman wrote: > On Thu, Feb 11, 2021 at 10:46:05AM -0800, Nick Desaulniers wrote: > > On Thu, Feb 11, 2021 at 5:55 AM Greg Kroah-Hartman > > wrote: > > > > > > On Thu, Feb 11, 2021 at 09:32:03PM +0800, Xi Ruoyao wrote: > > > > Hi all, > > > > >

Re: [tip: objtool/urgent] objtool: Fix seg fault with Clang non-section symbols

2021-02-12 Thread Greg Kroah-Hartman
On Thu, Feb 11, 2021 at 10:46:05AM -0800, Nick Desaulniers wrote: > On Thu, Feb 11, 2021 at 5:55 AM Greg Kroah-Hartman > wrote: > > > > On Thu, Feb 11, 2021 at 09:32:03PM +0800, Xi Ruoyao wrote: > > > Hi all, > > > > > > The latest GNU assembler (binutils-2.36.1) is removing unused section > > >

Re: [tip: objtool/urgent] objtool: Fix seg fault with Clang non-section symbols

2021-02-12 Thread Xi Ruoyao
Hi Greg and Nick, On 2021-02-11 10:46 -0800, Nick Desaulniers wrote: > On Thu, Feb 11, 2021 at 5:55 AM Greg Kroah-Hartman > wrote: > > > > On Thu, Feb 11, 2021 at 09:32:03PM +0800, Xi Ruoyao wrote: > > > Hi all, > > > > > > The latest GNU assembler (binutils-2.36.1) is removing unused section >

Re: [tip: objtool/urgent] objtool: Fix seg fault with Clang non-section symbols

2021-02-11 Thread Nick Desaulniers
On Thu, Feb 11, 2021 at 5:55 AM Greg Kroah-Hartman wrote: > > On Thu, Feb 11, 2021 at 09:32:03PM +0800, Xi Ruoyao wrote: > > Hi all, > > > > The latest GNU assembler (binutils-2.36.1) is removing unused section > > symbols > > like Clang [1]. So linux-5.10.15 can't be built with binutils-2.36.1

Re: [tip: objtool/urgent] objtool: Fix seg fault with Clang non-section symbols

2021-02-11 Thread Greg Kroah-Hartman
On Thu, Feb 11, 2021 at 09:32:03PM +0800, Xi Ruoyao wrote: > Hi all, > > The latest GNU assembler (binutils-2.36.1) is removing unused section symbols > like Clang [1]. So linux-5.10.15 can't be built with binutils-2.36.1 now. It > has been reported as https://bugzilla.kernel.org/show_bug.cgi?id

Re: [tip: objtool/urgent] objtool: Fix seg fault with Clang non-section symbols

2021-02-11 Thread Xi Ruoyao
Hi all, The latest GNU assembler (binutils-2.36.1) is removing unused section symbols like Clang [1]. So linux-5.10.15 can't be built with binutils-2.36.1 now. It has been reported as https://bugzilla.kernel.org/show_bug.cgi?id=211693. I can confirm this commit fixes the issue. It should be ch

[tip: objtool/urgent] objtool: Fix seg fault with Clang non-section symbols

2020-12-16 Thread tip-bot2 for Josh Poimboeuf
The following commit has been merged into the objtool/urgent branch of tip: Commit-ID: 44f6a7c0755d8dd453c70557e11687bb080a6f21 Gitweb: https://git.kernel.org/tip/44f6a7c0755d8dd453c70557e11687bb080a6f21 Author:Josh Poimboeuf AuthorDate:Mon, 14 Dec 2020 16:04:20 -06:00 Com