Re: [tip: x86/cache] x86/resctrl: Fix incorrect local bandwidth when mba_sc is enabled

2020-12-10 Thread Borislav Petkov
On Fri, Dec 11, 2020 at 12:40:46AM +0800, Xiaochen Shen wrote: > I plan to do backporting for all -stable trees after this patch is merged > into upstream. Ok, you can do that when Greg sends the mails that it cannot apply to the respective trees. Lemme queue this one to urgent now. Thx. --

Re: [tip: x86/cache] x86/resctrl: Fix incorrect local bandwidth when mba_sc is enabled

2020-12-10 Thread Xiaochen Shen
Hi Boris, On 12/10/2020 18:26, Borislav Petkov wrote: On Thu, Dec 10, 2020 at 12:45:11PM +0800, Xiaochen Shen wrote: Thank you for clarifying this issue. It is not a 0-DAY CI issue. Which begs the question: this patch should be Cc: stable and should go in now, shouldn't it? Because then the

Re: [tip: x86/cache] x86/resctrl: Fix incorrect local bandwidth when mba_sc is enabled

2020-12-10 Thread Borislav Petkov
On Thu, Dec 10, 2020 at 12:45:11PM +0800, Xiaochen Shen wrote: > Thank you for clarifying this issue. It is not a 0-DAY CI issue. Which begs the question: this patch should be Cc: stable and should go in now, shouldn't it? Because then the first submission applies cleanly ontop of

Re: [tip: x86/cache] x86/resctrl: Fix incorrect local bandwidth when mba_sc is enabled

2020-12-09 Thread Xiaochen Shen
Hi Boris, On 12/10/2020 6:23, Borislav Petkov wrote: And then it didn't apply cleanly: $ test-apply.sh /tmp/xiaochen.01 checking file arch/x86/kernel/cpu/resctrl/monitor.c Hunk #1 FAILED at 279. Hunk #2 succeeded at 514 (offset 64 lines). 1 out of 2 hunks FAILED I wiggled it in but it ended

Re: [tip: x86/cache] x86/resctrl: Fix incorrect local bandwidth when mba_sc is enabled

2020-12-09 Thread Borislav Petkov
On Wed, Dec 09, 2020 at 07:06:58PM -, tip-bot2 for Xiaochen Shen wrote: > diff --git a/arch/x86/kernel/cpu/resctrl/monitor.c > b/arch/x86/kernel/cpu/resctrl/monitor.c > index 622073f..93a33b7 100644 > --- a/arch/x86/kernel/cpu/resctrl/monitor.c > +++ b/arch/x86/kernel/cpu/resctrl/monitor.c >

Re: [tip: x86/cache] x86/resctrl: Fix incorrect local bandwidth when mba_sc is enabled

2020-12-09 Thread Borislav Petkov
On Wed, Dec 09, 2020 at 11:23:28PM +0100, Borislav Petkov wrote: > and you should remove the chunks assignment too. Yah, ignore that part - mbm_bw_count() does need chunks for cur_bw. Oh well. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette

[tip: x86/cache] x86/resctrl: Fix incorrect local bandwidth when mba_sc is enabled

2020-12-09 Thread tip-bot2 for Xiaochen Shen
The following commit has been merged into the x86/cache branch of tip: Commit-ID: 2ba836dbe2467d31fffb439258c2f454c6f1a317 Gitweb: https://git.kernel.org/tip/2ba836dbe2467d31fffb439258c2f454c6f1a317 Author:Xiaochen Shen AuthorDate:Fri, 04 Dec 2020 14:27:59 +08:00