Re: [tip:efi/core] efibc: Add EFI Bootloader Control module

On Mon, 02 May, at 09:56:09AM, Jeremy Compostella wrote: > > Please find the updated patch in attachment. Thanks Jeremy. Applied.

Re: [tip:efi/core] efibc: Add EFI Bootloader Control module

On Mon, 02 May, at 09:56:09AM, Jeremy Compostella wrote: > > Please find the updated patch in attachment. Thanks Jeremy. Applied.

Re: [tip:efi/core] efibc: Add EFI Bootloader Control module

Matt Fleming writes: > On Fri, 29 Apr, at 03:53:39PM, Jeremy Compostella wrote: >> From ef3a2941769e59b11d1ec36117209dc4c90c7cf9 Mon Sep 17 00:00:00 2001 >> From: Jeremy Compostella >> Date: Fri, 29 Apr 2016 15:29:59 +0200 >> Subject:

Re: [tip:efi/core] efibc: Add EFI Bootloader Control module

Matt Fleming writes: > On Fri, 29 Apr, at 03:53:39PM, Jeremy Compostella wrote: >> From ef3a2941769e59b11d1ec36117209dc4c90c7cf9 Mon Sep 17 00:00:00 2001 >> From: Jeremy Compostella >> Date: Fri, 29 Apr 2016 15:29:59 +0200 >> Subject: [PATCH] efibc: fix excessive stack footprint warning >> >>

Re: [tip:efi/core] efibc: Add EFI Bootloader Control module

On Sun, 01 May, at 10:03:55AM, Ard Biesheuvel wrote: > > Apologies for only mentioning this now, but I wonder why we need this > in the kernel in the first place? The UEFI spec defines 'BootNext' as > the way to set the boot entry for the next boot only, and this could > also be set from

Re: [tip:efi/core] efibc: Add EFI Bootloader Control module

On Sun, 01 May, at 10:03:55AM, Ard Biesheuvel wrote: > > Apologies for only mentioning this now, but I wonder why we need this > in the kernel in the first place? The UEFI spec defines 'BootNext' as > the way to set the boot entry for the next boot only, and this could > also be set from

Re: [tip:efi/core] efibc: Add EFI Bootloader Control module

On 29 April 2016 at 11:53, Ingo Molnar wrote: > > * tip-bot for Compostella, Jeremy wrote: > >> Commit-ID: 06f7d4a1618dbb086e738c93cd1ef416ab01027d >> Gitweb: >> http://git.kernel.org/tip/06f7d4a1618dbb086e738c93cd1ef416ab01027d >> Author:

Re: [tip:efi/core] efibc: Add EFI Bootloader Control module

On 29 April 2016 at 11:53, Ingo Molnar wrote: > > * tip-bot for Compostella, Jeremy wrote: > >> Commit-ID: 06f7d4a1618dbb086e738c93cd1ef416ab01027d >> Gitweb: >> http://git.kernel.org/tip/06f7d4a1618dbb086e738c93cd1ef416ab01027d >> Author: Compostella, Jeremy >> AuthorDate: Mon, 25

Re: [tip:efi/core] efibc: Add EFI Bootloader Control module

On Fri, 29 Apr, at 03:53:39PM, Jeremy Compostella wrote: > From ef3a2941769e59b11d1ec36117209dc4c90c7cf9 Mon Sep 17 00:00:00 2001 > From: Jeremy Compostella > Date: Fri, 29 Apr 2016 15:29:59 +0200 > Subject: [PATCH] efibc: fix excessive stack footprint warning > >

Re: [tip:efi/core] efibc: Add EFI Bootloader Control module

On Fri, 29 Apr, at 03:53:39PM, Jeremy Compostella wrote: > From ef3a2941769e59b11d1ec36117209dc4c90c7cf9 Mon Sep 17 00:00:00 2001 > From: Jeremy Compostella > Date: Fri, 29 Apr 2016 15:29:59 +0200 > Subject: [PATCH] efibc: fix excessive stack footprint warning > > Use dynamic memory allocation

Re: [tip:efi/core] efibc: Add EFI Bootloader Control module

On Sat, 30 Apr, at 10:33:32AM, Jeremy Compostella wrote: > Ingo Molnar writes: > > > > Hm, can reboot notifiers do non-atomic allocations? > The reboot notifier chain is a blocking notifier chain. AFAIK, it > allows non-atomic allocation, right ? I would assume so, yes. > >

Re: [tip:efi/core] efibc: Add EFI Bootloader Control module

On Sat, 30 Apr, at 10:33:32AM, Jeremy Compostella wrote: > Ingo Molnar writes: > > > > Hm, can reboot notifiers do non-atomic allocations? > The reboot notifier chain is a blocking notifier chain. AFAIK, it > allows non-atomic allocation, right ? I would assume so, yes. > > Why is efivar_entry

Re: [tip:efi/core] efibc: Add EFI Bootloader Control module

Ingo Molnar writes: > * Compostella, Jeremy wrote: > >> -static void efibc_set_variable(const char *name, const char *value) >> +static int efibc_set_variable(const char *name, const char *value) >> { >> int ret; >> efi_guid_t guid =

Re: [tip:efi/core] efibc: Add EFI Bootloader Control module

Ingo Molnar writes: > * Compostella, Jeremy wrote: > >> -static void efibc_set_variable(const char *name, const char *value) >> +static int efibc_set_variable(const char *name, const char *value) >> { >> int ret; >> efi_guid_t guid = LINUX_EFI_LOADER_ENTRY_GUID; >> -struct

Re: [tip:efi/core] efibc: Add EFI Bootloader Control module

* Compostella, Jeremy wrote: > -static void efibc_set_variable(const char *name, const char *value) > +static int efibc_set_variable(const char *name, const char *value) > { > int ret; > efi_guid_t guid = LINUX_EFI_LOADER_ENTRY_GUID; > - struct

Re: [tip:efi/core] efibc: Add EFI Bootloader Control module

* Compostella, Jeremy wrote: > -static void efibc_set_variable(const char *name, const char *value) > +static int efibc_set_variable(const char *name, const char *value) > { > int ret; > efi_guid_t guid = LINUX_EFI_LOADER_ENTRY_GUID; > - struct efivar_entry entry; > +

Re: [tip:efi/core] efibc: Add EFI Bootloader Control module

Matt Fleming writes: > On Fri, 29 Apr, at 01:36:01PM, Jeremy Compostella wrote: >> I would go for this last proposal because it fixes the issue, it works >> with the potential race condition you mentioned and it is a simple >> solution. Yet, it means that if we really

Re: [tip:efi/core] efibc: Add EFI Bootloader Control module

Matt Fleming writes: > On Fri, 29 Apr, at 01:36:01PM, Jeremy Compostella wrote: >> I would go for this last proposal because it fixes the issue, it works >> with the potential race condition you mentioned and it is a simple >> solution. Yet, it means that if we really run into a race condition,

Re: [tip:efi/core] efibc: Add EFI Bootloader Control module

On Fri, 29 Apr, at 01:36:01PM, Jeremy Compostella wrote: > I would go for this last proposal because it fixes the issue, it works > with the potential race condition you mentioned and it is a simple > solution. Yet, it means that if we really run into a race condition, > the LoaderEntryOneShot

Re: [tip:efi/core] efibc: Add EFI Bootloader Control module

On Fri, 29 Apr, at 01:36:01PM, Jeremy Compostella wrote: > I would go for this last proposal because it fixes the issue, it works > with the potential race condition you mentioned and it is a simple > solution. Yet, it means that if we really run into a race condition, > the LoaderEntryOneShot

Re: [tip:efi/core] efibc: Add EFI Bootloader Control module

Matt Fleming writes: > On Fri, 29 Apr, at 11:53:56AM, Ingo Molnar wrote: >> >> * tip-bot for Compostella, Jeremy wrote: >> >> > Commit-ID: 06f7d4a1618dbb086e738c93cd1ef416ab01027d >> > Gitweb: >> >

Re: [tip:efi/core] efibc: Add EFI Bootloader Control module

Matt Fleming writes: > On Fri, 29 Apr, at 11:53:56AM, Ingo Molnar wrote: >> >> * tip-bot for Compostella, Jeremy wrote: >> >> > Commit-ID: 06f7d4a1618dbb086e738c93cd1ef416ab01027d >> > Gitweb: >> > http://git.kernel.org/tip/06f7d4a1618dbb086e738c93cd1ef416ab01027d >> > Author:

Re: [tip:efi/core] efibc: Add EFI Bootloader Control module

On Fri, 29 Apr, at 11:53:56AM, Ingo Molnar wrote: > > * tip-bot for Compostella, Jeremy wrote: > > > Commit-ID: 06f7d4a1618dbb086e738c93cd1ef416ab01027d > > Gitweb: > > http://git.kernel.org/tip/06f7d4a1618dbb086e738c93cd1ef416ab01027d > > Author: Compostella, Jeremy

Re: [tip:efi/core] efibc: Add EFI Bootloader Control module

On Fri, 29 Apr, at 11:53:56AM, Ingo Molnar wrote: > > * tip-bot for Compostella, Jeremy wrote: > > > Commit-ID: 06f7d4a1618dbb086e738c93cd1ef416ab01027d > > Gitweb: > > http://git.kernel.org/tip/06f7d4a1618dbb086e738c93cd1ef416ab01027d > > Author: Compostella, Jeremy > > AuthorDate:

Re: [tip:efi/core] efibc: Add EFI Bootloader Control module

* tip-bot for Compostella, Jeremy wrote: > Commit-ID: 06f7d4a1618dbb086e738c93cd1ef416ab01027d > Gitweb: http://git.kernel.org/tip/06f7d4a1618dbb086e738c93cd1ef416ab01027d > Author: Compostella, Jeremy > AuthorDate: Mon, 25 Apr 2016

Re: [tip:efi/core] efibc: Add EFI Bootloader Control module

* tip-bot for Compostella, Jeremy wrote: > Commit-ID: 06f7d4a1618dbb086e738c93cd1ef416ab01027d > Gitweb: http://git.kernel.org/tip/06f7d4a1618dbb086e738c93cd1ef416ab01027d > Author: Compostella, Jeremy > AuthorDate: Mon, 25 Apr 2016 21:06:57 +0100 > Committer: Ingo Molnar >

[tip:efi/core] efibc: Add EFI Bootloader Control module

Commit-ID: 06f7d4a1618dbb086e738c93cd1ef416ab01027d Gitweb: http://git.kernel.org/tip/06f7d4a1618dbb086e738c93cd1ef416ab01027d Author: Compostella, Jeremy AuthorDate: Mon, 25 Apr 2016 21:06:57 +0100 Committer: Ingo Molnar CommitDate: Thu,

[tip:efi/core] efibc: Add EFI Bootloader Control module

Commit-ID: 06f7d4a1618dbb086e738c93cd1ef416ab01027d Gitweb: http://git.kernel.org/tip/06f7d4a1618dbb086e738c93cd1ef416ab01027d Author: Compostella, Jeremy AuthorDate: Mon, 25 Apr 2016 21:06:57 +0100 Committer: Ingo Molnar CommitDate: Thu, 28 Apr 2016 11:34:02 +0200 efibc: Add EFI