Re: [tip:perf/core] perf: Fix broken union in ' struct perf_event_mmap_page'

2013-09-19 Thread Ingo Molnar
* Stephane Eranian wrote: > On Thu, Sep 19, 2013 at 10:43 AM, Peter Zijlstra wrote: > > On Wed, Sep 18, 2013 at 08:33:53PM +0200, Stephane Eranian wrote: > >> On Wed, Sep 18, 2013 at 5:42 PM, Peter Zijlstra > >> wrote: > >> > On Wed, Sep 18, 2013 at 10:19:32AM -0400, Vince Weaver wrote: > >>

Re: [tip:perf/core] perf: Fix broken union in ' struct perf_event_mmap_page'

2013-09-19 Thread Stephane Eranian
On Thu, Sep 19, 2013 at 10:43 AM, Peter Zijlstra wrote: > On Wed, Sep 18, 2013 at 08:33:53PM +0200, Stephane Eranian wrote: >> On Wed, Sep 18, 2013 at 5:42 PM, Peter Zijlstra wrote: >> > On Wed, Sep 18, 2013 at 10:19:32AM -0400, Vince Weaver wrote: >> >> Can you point to any code that is fixed

Re: [tip:perf/core] perf: Fix broken union in ' struct perf_event_mmap_page'

2013-09-19 Thread Peter Zijlstra
On Wed, Sep 18, 2013 at 08:33:53PM +0200, Stephane Eranian wrote: > On Wed, Sep 18, 2013 at 5:42 PM, Peter Zijlstra wrote: > > On Wed, Sep 18, 2013 at 10:19:32AM -0400, Vince Weaver wrote: > >> Can you point to any code that is fixed by the commit? > > > > I have some, but I don't think a lot of

Re: [tip:perf/core] perf: Fix broken union in ' struct perf_event_mmap_page'

2013-09-19 Thread Ingo Molnar
* Vince Weaver wrote: > On Tue, 17 Sep 2013, Vince Weaver wrote: > > > > > This patch somehow breaks the perf-ABI. > > > > If I take a program that reads "mmap->cap_usr_rdpmc" and compile it > > against the new header with this change (say from 3.12-rc1) > > and then run it on an old kernel

Re: [tip:perf/core] perf: Fix broken union in ' struct perf_event_mmap_page'

2013-09-19 Thread Peter Zijlstra
On Wed, Sep 18, 2013 at 04:07:52PM -0400, Vince Weaver wrote: > It would be nice if there was some way to detect this change; I liked the > idea of a "cap_usr_fixed" bit. How about we start using the version field for this? Arguably we should have incremented that value every time we changed the

Re: [tip:perf/core] perf: Fix broken union in ' struct perf_event_mmap_page'

2013-09-19 Thread Peter Zijlstra
On Wed, Sep 18, 2013 at 04:07:52PM -0400, Vince Weaver wrote: It would be nice if there was some way to detect this change; I liked the idea of a cap_usr_fixed bit. How about we start using the version field for this? Arguably we should have incremented that value every time we changed the

Re: [tip:perf/core] perf: Fix broken union in ' struct perf_event_mmap_page'

2013-09-19 Thread Ingo Molnar
* Vince Weaver vi...@deater.net wrote: On Tue, 17 Sep 2013, Vince Weaver wrote: This patch somehow breaks the perf-ABI. If I take a program that reads mmap-cap_usr_rdpmc and compile it against the new header with this change (say from 3.12-rc1) and then run it on an old kernel

Re: [tip:perf/core] perf: Fix broken union in ' struct perf_event_mmap_page'

2013-09-19 Thread Peter Zijlstra
On Wed, Sep 18, 2013 at 08:33:53PM +0200, Stephane Eranian wrote: On Wed, Sep 18, 2013 at 5:42 PM, Peter Zijlstra pet...@infradead.org wrote: On Wed, Sep 18, 2013 at 10:19:32AM -0400, Vince Weaver wrote: Can you point to any code that is fixed by the commit? I have some, but I don't think

Re: [tip:perf/core] perf: Fix broken union in ' struct perf_event_mmap_page'

2013-09-19 Thread Stephane Eranian
On Thu, Sep 19, 2013 at 10:43 AM, Peter Zijlstra pet...@infradead.org wrote: On Wed, Sep 18, 2013 at 08:33:53PM +0200, Stephane Eranian wrote: On Wed, Sep 18, 2013 at 5:42 PM, Peter Zijlstra pet...@infradead.org wrote: On Wed, Sep 18, 2013 at 10:19:32AM -0400, Vince Weaver wrote: Can you

Re: [tip:perf/core] perf: Fix broken union in ' struct perf_event_mmap_page'

2013-09-19 Thread Ingo Molnar
* Stephane Eranian eran...@googlemail.com wrote: On Thu, Sep 19, 2013 at 10:43 AM, Peter Zijlstra pet...@infradead.org wrote: On Wed, Sep 18, 2013 at 08:33:53PM +0200, Stephane Eranian wrote: On Wed, Sep 18, 2013 at 5:42 PM, Peter Zijlstra pet...@infradead.org wrote: On Wed, Sep 18,

Re: [tip:perf/core] perf: Fix broken union in ' struct perf_event_mmap_page'

2013-09-18 Thread Vince Weaver
On Wed, 18 Sep 2013, Peter Zijlstra wrote: > On Wed, Sep 18, 2013 at 10:19:32AM -0400, Vince Weaver wrote: > > Can you point to any code that is fixed by the commit? > > I have some, but I don't think a lot of people use it. > > Would you be ok with something like the below? It should preserve

Re: [tip:perf/core] perf: Fix broken union in ' struct perf_event_mmap_page'

2013-09-18 Thread Stephane Eranian
On Wed, Sep 18, 2013 at 5:42 PM, Peter Zijlstra wrote: > On Wed, Sep 18, 2013 at 10:19:32AM -0400, Vince Weaver wrote: >> Can you point to any code that is fixed by the commit? > > I have some, but I don't think a lot of people use it. > > Would you be ok with something like the below? It should

Re: [tip:perf/core] perf: Fix broken union in ' struct perf_event_mmap_page'

2013-09-18 Thread Peter Zijlstra
On Wed, Sep 18, 2013 at 10:19:32AM -0400, Vince Weaver wrote: > Can you point to any code that is fixed by the commit? I have some, but I don't think a lot of people use it. Would you be ok with something like the below? It should preserve functionality for code that only cares about

Re: [tip:perf/core] perf: Fix broken union in ' struct perf_event_mmap_page'

2013-09-18 Thread Vince Weaver
On Wed, 18 Sep 2013, Peter Zijlstra wrote: > > This patch somehow breaks the perf-ABI. > > Difficult call that.. OK, let me rephrase. This change broke existing working code. Can you point to any code that is fixed by the commit? If not, I think the rule is you revert the changeset. Or you

Re: [tip:perf/core] perf: Fix broken union in ' struct perf_event_mmap_page'

2013-09-18 Thread Vince Weaver
On Wed, 18 Sep 2013, Adrian Hunter wrote: > On 17/09/13 23:23, Vince Weaver wrote: > > > > This patch somehow breaks the perf-ABI. > > > > If I take a program that reads "mmap->cap_usr_rdpmc" and compile it > > against the new header with this change (say from 3.12-rc1) > > and then run it on

Re: [tip:perf/core] perf: Fix broken union in ' struct perf_event_mmap_page'

2013-09-18 Thread Adrian Hunter
On 17/09/13 23:23, Vince Weaver wrote: > > This patch somehow breaks the perf-ABI. > > If I take a program that reads "mmap->cap_usr_rdpmc" and compile it > against the new header with this change (say from 3.12-rc1) > and then run it on an old kernel (say 3.11) then I get "0" for >

Re: [tip:perf/core] perf: Fix broken union in ' struct perf_event_mmap_page'

2013-09-18 Thread Peter Zijlstra
On Tue, Sep 17, 2013 at 04:23:25PM -0400, Vince Weaver wrote: > > include/uapi/linux/perf_event.h | 8 +--- > > 1 file changed, 5 insertions(+), 3 deletions(-) > > > > diff --git a/include/uapi/linux/perf_event.h > > b/include/uapi/linux/perf_event.h > > index 00d8274..0041aed 100644 > >

Re: [tip:perf/core] perf: Fix broken union in ' struct perf_event_mmap_page'

2013-09-18 Thread Peter Zijlstra
On Tue, Sep 17, 2013 at 04:23:25PM -0400, Vince Weaver wrote: include/uapi/linux/perf_event.h | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h index 00d8274..0041aed 100644 ---

Re: [tip:perf/core] perf: Fix broken union in ' struct perf_event_mmap_page'

2013-09-18 Thread Adrian Hunter
On 17/09/13 23:23, Vince Weaver wrote: This patch somehow breaks the perf-ABI. If I take a program that reads mmap-cap_usr_rdpmc and compile it against the new header with this change (say from 3.12-rc1) and then run it on an old kernel (say 3.11) then I get 0 for cap_usr_rdpmc. If I

Re: [tip:perf/core] perf: Fix broken union in ' struct perf_event_mmap_page'

2013-09-18 Thread Vince Weaver
On Wed, 18 Sep 2013, Adrian Hunter wrote: On 17/09/13 23:23, Vince Weaver wrote: This patch somehow breaks the perf-ABI. If I take a program that reads mmap-cap_usr_rdpmc and compile it against the new header with this change (say from 3.12-rc1) and then run it on an old kernel

Re: [tip:perf/core] perf: Fix broken union in ' struct perf_event_mmap_page'

2013-09-18 Thread Vince Weaver
On Wed, 18 Sep 2013, Peter Zijlstra wrote: This patch somehow breaks the perf-ABI. Difficult call that.. OK, let me rephrase. This change broke existing working code. Can you point to any code that is fixed by the commit? If not, I think the rule is you revert the changeset. Or you can

Re: [tip:perf/core] perf: Fix broken union in ' struct perf_event_mmap_page'

2013-09-18 Thread Peter Zijlstra
On Wed, Sep 18, 2013 at 10:19:32AM -0400, Vince Weaver wrote: Can you point to any code that is fixed by the commit? I have some, but I don't think a lot of people use it. Would you be ok with something like the below? It should preserve functionality for code that only cares about

Re: [tip:perf/core] perf: Fix broken union in ' struct perf_event_mmap_page'

2013-09-18 Thread Stephane Eranian
On Wed, Sep 18, 2013 at 5:42 PM, Peter Zijlstra pet...@infradead.org wrote: On Wed, Sep 18, 2013 at 10:19:32AM -0400, Vince Weaver wrote: Can you point to any code that is fixed by the commit? I have some, but I don't think a lot of people use it. Would you be ok with something like the

Re: [tip:perf/core] perf: Fix broken union in ' struct perf_event_mmap_page'

2013-09-18 Thread Vince Weaver
On Wed, 18 Sep 2013, Peter Zijlstra wrote: On Wed, Sep 18, 2013 at 10:19:32AM -0400, Vince Weaver wrote: Can you point to any code that is fixed by the commit? I have some, but I don't think a lot of people use it. Would you be ok with something like the below? It should preserve

Re: [tip:perf/core] perf: Fix broken union in ' struct perf_event_mmap_page'

2013-09-17 Thread Vince Weaver
On Tue, 17 Sep 2013, Vince Weaver wrote: > > This patch somehow breaks the perf-ABI. > > If I take a program that reads "mmap->cap_usr_rdpmc" and compile it > against the new header with this change (say from 3.12-rc1) > and then run it on an old kernel (say 3.11) then I get "0" for >

Re: [tip:perf/core] perf: Fix broken union in ' struct perf_event_mmap_page'

2013-09-17 Thread Vince Weaver
This patch somehow breaks the perf-ABI. If I take a program that reads "mmap->cap_usr_rdpmc" and compile it against the new header with this change (say from 3.12-rc1) and then run it on an old kernel (say 3.11) then I get "0" for cap_usr_rdpmc. If I take the same program and recompile against

Re: [tip:perf/core] perf: Fix broken union in ' struct perf_event_mmap_page'

2013-09-17 Thread Vince Weaver
This patch somehow breaks the perf-ABI. If I take a program that reads mmap-cap_usr_rdpmc and compile it against the new header with this change (say from 3.12-rc1) and then run it on an old kernel (say 3.11) then I get 0 for cap_usr_rdpmc. If I take the same program and recompile against the

Re: [tip:perf/core] perf: Fix broken union in ' struct perf_event_mmap_page'

2013-09-17 Thread Vince Weaver
On Tue, 17 Sep 2013, Vince Weaver wrote: This patch somehow breaks the perf-ABI. If I take a program that reads mmap-cap_usr_rdpmc and compile it against the new header with this change (say from 3.12-rc1) and then run it on an old kernel (say 3.11) then I get 0 for cap_usr_rdpmc. If

[tip:perf/core] perf: Fix broken union in ' struct perf_event_mmap_page'

2013-07-23 Thread tip-bot for Adrian Hunter
Commit-ID: 860f085b74e9f0075de8140ed3a1e5b5e3e39aa8 Gitweb: http://git.kernel.org/tip/860f085b74e9f0075de8140ed3a1e5b5e3e39aa8 Author: Adrian Hunter AuthorDate: Fri, 28 Jun 2013 16:22:17 +0300 Committer: Ingo Molnar CommitDate: Tue, 23 Jul 2013 12:17:10 +0200 perf: Fix broken union in

[tip:perf/core] perf: Fix broken union in ' struct perf_event_mmap_page'

2013-07-23 Thread tip-bot for Adrian Hunter
Commit-ID: 860f085b74e9f0075de8140ed3a1e5b5e3e39aa8 Gitweb: http://git.kernel.org/tip/860f085b74e9f0075de8140ed3a1e5b5e3e39aa8 Author: Adrian Hunter adrian.hun...@intel.com AuthorDate: Fri, 28 Jun 2013 16:22:17 +0300 Committer: Ingo Molnar mi...@kernel.org CommitDate: Tue, 23 Jul 2013