Re: [tip:sched/core] sched/numa: Move task_numa_free() to __put_task_struct()

2014-04-13 Thread Govindarajulu Varadarajan
On Mon, 7 Apr 2014, Mike Galbraith wrote: On Mon, 2014-04-07 at 10:16 +0200, Peter Zijlstra wrote: On Mon, Apr 07, 2014 at 09:30:30AM +0200, Mike Galbraith wrote: - double_lock(_grp->lock, >lock); + BUG_ON(irqs_disabled()); + double_lock_irq(_grp->lock, >lock); So either

Re: [tip:sched/core] sched/numa: Move task_numa_free() to __put_task_struct()

2014-04-13 Thread Govindarajulu Varadarajan
On Mon, 7 Apr 2014, Mike Galbraith wrote: On Mon, 2014-04-07 at 10:16 +0200, Peter Zijlstra wrote: On Mon, Apr 07, 2014 at 09:30:30AM +0200, Mike Galbraith wrote: - double_lock(my_grp-lock, grp-lock); + BUG_ON(irqs_disabled()); + double_lock_irq(my_grp-lock, grp-lock);

Re: [tip:sched/core] sched/numa: Move task_numa_free() to __put_task_struct()

2014-04-07 Thread Mike Galbraith
On Mon, 2014-04-07 at 10:16 +0200, Peter Zijlstra wrote: > On Mon, Apr 07, 2014 at 09:30:30AM +0200, Mike Galbraith wrote: > > - double_lock(_grp->lock, >lock); > > + BUG_ON(irqs_disabled()); > > + double_lock_irq(_grp->lock, >lock); > > So either make this: > > local_irq_disable();

Re: [tip:sched/core] sched/numa: Move task_numa_free() to __put_task_struct()

2014-04-07 Thread Mike Galbraith
On Mon, 2014-04-07 at 10:16 +0200, Peter Zijlstra wrote: > On Mon, Apr 07, 2014 at 09:30:30AM +0200, Mike Galbraith wrote: > > - double_lock(_grp->lock, >lock); > > + BUG_ON(irqs_disabled()); > > + double_lock_irq(_grp->lock, >lock); > > So either make this: > > local_irq_disable();

Re: [tip:sched/core] sched/numa: Move task_numa_free() to __put_task_struct()

2014-04-07 Thread Peter Zijlstra
On Mon, Apr 07, 2014 at 09:30:30AM +0200, Mike Galbraith wrote: > - double_lock(_grp->lock, >lock); > + BUG_ON(irqs_disabled()); > + double_lock_irq(_grp->lock, >lock); So either make this: local_irq_disable(); double_lock(); or > > for (i = 0; i <

Re: [tip:sched/core] sched/numa: Move task_numa_free() to __put_task_struct()

2014-04-07 Thread Mike Galbraith
On Mon, 2014-04-07 at 07:29 +0200, Mike Galbraith wrote: > I'm not getting it. > > I moved task_numa_free() from one interrupts enabled spot to another. > But, with numa=fake=4 and lockdep enabled, not only does lockdep gripe, > my little box locks up on splat. Saying spin_lock/unlock_irq() did

Re: [tip:sched/core] sched/numa: Move task_numa_free() to __put_task_struct()

2014-04-07 Thread Mike Galbraith
On Mon, 2014-04-07 at 07:29 +0200, Mike Galbraith wrote: I'm not getting it. I moved task_numa_free() from one interrupts enabled spot to another. But, with numa=fake=4 and lockdep enabled, not only does lockdep gripe, my little box locks up on splat. Saying spin_lock/unlock_irq() did the

Re: [tip:sched/core] sched/numa: Move task_numa_free() to __put_task_struct()

2014-04-07 Thread Peter Zijlstra
On Mon, Apr 07, 2014 at 09:30:30AM +0200, Mike Galbraith wrote: - double_lock(my_grp-lock, grp-lock); + BUG_ON(irqs_disabled()); + double_lock_irq(my_grp-lock, grp-lock); So either make this: local_irq_disable(); double_lock(); or for (i = 0; i

Re: [tip:sched/core] sched/numa: Move task_numa_free() to __put_task_struct()

2014-04-07 Thread Mike Galbraith
On Mon, 2014-04-07 at 10:16 +0200, Peter Zijlstra wrote: On Mon, Apr 07, 2014 at 09:30:30AM +0200, Mike Galbraith wrote: - double_lock(my_grp-lock, grp-lock); + BUG_ON(irqs_disabled()); + double_lock_irq(my_grp-lock, grp-lock); So either make this: local_irq_disable();

Re: [tip:sched/core] sched/numa: Move task_numa_free() to __put_task_struct()

2014-04-07 Thread Mike Galbraith
On Mon, 2014-04-07 at 10:16 +0200, Peter Zijlstra wrote: On Mon, Apr 07, 2014 at 09:30:30AM +0200, Mike Galbraith wrote: - double_lock(my_grp-lock, grp-lock); + BUG_ON(irqs_disabled()); + double_lock_irq(my_grp-lock, grp-lock); So either make this: local_irq_disable();

Re: [tip:sched/core] sched/numa: Move task_numa_free() to __put_task_struct()

2014-04-06 Thread Mike Galbraith
On Sun, 2014-04-06 at 15:17 -0400, Sasha Levin wrote: > On 03/11/2014 08:40 AM, tip-bot for Mike Galbraith wrote: > > Commit-ID: 156654f491dd8d52687a5fbe1637f472a52ce75b > > Gitweb: > > http://git.kernel.org/tip/156654f491dd8d52687a5fbe1637f472a52ce75b > > Author: Mike Galbraith > >

Re: [tip:sched/core] sched/numa: Move task_numa_free() to __put_task_struct()

2014-04-06 Thread Sasha Levin
On 03/11/2014 08:40 AM, tip-bot for Mike Galbraith wrote: > Commit-ID: 156654f491dd8d52687a5fbe1637f472a52ce75b > Gitweb: http://git.kernel.org/tip/156654f491dd8d52687a5fbe1637f472a52ce75b > Author: Mike Galbraith > AuthorDate: Fri, 28 Feb 2014 07:23:11 +0100 > Committer: Ingo Molnar >

Re: [tip:sched/core] sched/numa: Move task_numa_free() to __put_task_struct()

2014-04-06 Thread Sasha Levin
On 03/11/2014 08:40 AM, tip-bot for Mike Galbraith wrote: Commit-ID: 156654f491dd8d52687a5fbe1637f472a52ce75b Gitweb: http://git.kernel.org/tip/156654f491dd8d52687a5fbe1637f472a52ce75b Author: Mike Galbraith bitbuc...@online.de AuthorDate: Fri, 28 Feb 2014 07:23:11 +0100 Committer:

Re: [tip:sched/core] sched/numa: Move task_numa_free() to __put_task_struct()

2014-04-06 Thread Mike Galbraith
On Sun, 2014-04-06 at 15:17 -0400, Sasha Levin wrote: On 03/11/2014 08:40 AM, tip-bot for Mike Galbraith wrote: Commit-ID: 156654f491dd8d52687a5fbe1637f472a52ce75b Gitweb: http://git.kernel.org/tip/156654f491dd8d52687a5fbe1637f472a52ce75b Author: Mike Galbraith

[tip:sched/core] sched/numa: Move task_numa_free() to __put_task_struct()

2014-03-11 Thread tip-bot for Mike Galbraith
Commit-ID: 156654f491dd8d52687a5fbe1637f472a52ce75b Gitweb: http://git.kernel.org/tip/156654f491dd8d52687a5fbe1637f472a52ce75b Author: Mike Galbraith AuthorDate: Fri, 28 Feb 2014 07:23:11 +0100 Committer: Ingo Molnar CommitDate: Tue, 11 Mar 2014 12:05:43 +0100 sched/numa: Move

[tip:sched/core] sched/numa: Move task_numa_free() to __put_task_struct()

2014-03-11 Thread tip-bot for Mike Galbraith
Commit-ID: 156654f491dd8d52687a5fbe1637f472a52ce75b Gitweb: http://git.kernel.org/tip/156654f491dd8d52687a5fbe1637f472a52ce75b Author: Mike Galbraith bitbuc...@online.de AuthorDate: Fri, 28 Feb 2014 07:23:11 +0100 Committer: Ingo Molnar mi...@kernel.org CommitDate: Tue, 11 Mar 2014