Re: [tip:x86/mm] kdump, proc/vmcore: Enable kdumping encrypted memory with SME enabled

2018-10-08 Thread lijiang
在 2018年10月08日 21:43, Borislav Petkov 写道: > On Mon, Oct 08, 2018 at 10:59:09AM +0200, Borislav Petkov wrote: >> On Mon, Oct 08, 2018 at 04:47:34PM +0800, lijiang wrote: >>> It looks like a good way to avoid the 'ifdefined', and it's also good >>> enough for i386. >>> >>> But for other architectures

Re: [tip:x86/mm] kdump, proc/vmcore: Enable kdumping encrypted memory with SME enabled

2018-10-08 Thread Borislav Petkov
On Mon, Oct 08, 2018 at 10:59:09AM +0200, Borislav Petkov wrote: > On Mon, Oct 08, 2018 at 04:47:34PM +0800, lijiang wrote: > > It looks like a good way to avoid the 'ifdefined', and it's also good > > enough for i386. > > > > But for other architectures, such as POWERPC/ARM..., we will also have

Re: [tip:x86/mm] kdump, proc/vmcore: Enable kdumping encrypted memory with SME enabled

2018-10-08 Thread Borislav Petkov
On Mon, Oct 08, 2018 at 04:47:34PM +0800, lijiang wrote: > It looks like a good way to avoid the 'ifdefined', and it's also good enough > for i386. > > But for other architectures, such as POWERPC/ARM..., we will also have to add > the same > function for every architecture. Otherwise, i guess

Re: [tip:x86/mm] kdump, proc/vmcore: Enable kdumping encrypted memory with SME enabled

2018-10-08 Thread lijiang
在 2018年10月08日 16:00, Borislav Petkov 写道: > On Mon, Oct 08, 2018 at 03:11:56PM +0800, lijiang wrote: >> I used this ".config" to compile kernel in the attachment, and got a compile >> error. >> Would you like to have a try? >> >> [root@hp-dl385g10-03 linux]# make ARCH=i386 -j32 >> .. >> LD

Re: [tip:x86/mm] kdump, proc/vmcore: Enable kdumping encrypted memory with SME enabled

2018-10-08 Thread Borislav Petkov
On Mon, Oct 08, 2018 at 03:11:56PM +0800, lijiang wrote: > I used this ".config" to compile kernel in the attachment, and got a compile > error. > Would you like to have a try? > > [root@hp-dl385g10-03 linux]# make ARCH=i386 -j32 > .. > LD vmlinux.o > MODPOST vmlinux.o > fs/proc/vm

Re: [tip:x86/mm] kdump, proc/vmcore: Enable kdumping encrypted memory with SME enabled

2018-10-08 Thread lijiang
在 2018年10月08日 13:37, Borislav Petkov 写道: > On Mon, Oct 08, 2018 at 11:30:56AM +0800, lijiang wrote: >> Yes. As previously mentioned, the correct patch is this one: > > No, that chunk is not needed and I removed it. But I'd leave it as > an exercise to you to figure out why... or to prove me wrong

Re: [tip:x86/mm] kdump, proc/vmcore: Enable kdumping encrypted memory with SME enabled

2018-10-07 Thread Borislav Petkov
On Mon, Oct 08, 2018 at 11:30:56AM +0800, lijiang wrote: > Yes. As previously mentioned, the correct patch is this one: No, that chunk is not needed and I removed it. But I'd leave it as an exercise to you to figure out why... or to prove me wrong with a .config. :-) -- Regards/Gruss, Boris

Re: [tip:x86/mm] kdump, proc/vmcore: Enable kdumping encrypted memory with SME enabled

2018-10-07 Thread lijiang
在 2018年10月07日 16:47, Borislav Petkov 写道: > On Sun, Oct 07, 2018 at 01:55:33PM +0800, lijiang wrote: >> Here, it may be have a compile error. > > Are you sure? The configs I tried worked fine but I'm open to being > shown configs which fail the build. > Yes. As previously mentioned, the correct p

Re: [tip:x86/mm] kdump, proc/vmcore: Enable kdumping encrypted memory with SME enabled

2018-10-07 Thread Borislav Petkov
On Sun, Oct 07, 2018 at 01:55:33PM +0800, lijiang wrote: > Here, it may be have a compile error. Are you sure? The configs I tried worked fine but I'm open to being shown configs which fail the build. -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Nor

Re: [tip:x86/mm] kdump, proc/vmcore: Enable kdumping encrypted memory with SME enabled

2018-10-06 Thread lijiang
在 2018年10月06日 19:47, tip-bot for Lianbo Jiang 写道: > Commit-ID: 992b649a3f013465d8128da02e5449def662a4c3 > Gitweb: > https://git.kernel.org/tip/992b649a3f013465d8128da02e5449def662a4c3 > Author: Lianbo Jiang > AuthorDate: Sun, 30 Sep 2018 16:37:41 +0800 > Committer: Borislav Petkov > Co

[tip:x86/mm] kdump, proc/vmcore: Enable kdumping encrypted memory with SME enabled

2018-10-06 Thread tip-bot for Lianbo Jiang
Commit-ID: 992b649a3f013465d8128da02e5449def662a4c3 Gitweb: https://git.kernel.org/tip/992b649a3f013465d8128da02e5449def662a4c3 Author: Lianbo Jiang AuthorDate: Sun, 30 Sep 2018 16:37:41 +0800 Committer: Borislav Petkov CommitDate: Sat, 6 Oct 2018 12:09:26 +0200 kdump, proc/vmcore: Ena