Re: [tip:x86/platform] x86/intel/quark: Switch off CR4.PGE so TLB flush uses CR3 instead

2014-09-24 Thread Bryan O'Donoghue
Well, we need a comment at least. And certainly we don't need an if/else as we can just do it. -hpa OK. No problem. BOD -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://

Re: [tip:x86/platform] x86/intel/quark: Switch off CR4.PGE so TLB flush uses CR3 instead

2014-09-24 Thread H. Peter Anvin
On 09/24/2014 11:42 AM, H. Peter Anvin wrote: > On 09/24/2014 09:07 AM, Bryan O'Donoghue wrote: >>> >>> So __flush_tlb_all(); will do nothing but that's OK since load_cr3() >>> already flushed the TLB - including any PTE with PGE set >> >> I take your point though. >> >> It's probably better to be

Re: [tip:x86/platform] x86/intel/quark: Switch off CR4.PGE so TLB flush uses CR3 instead

2014-09-24 Thread H. Peter Anvin
On 09/24/2014 09:07 AM, Bryan O'Donoghue wrote: >> >> So __flush_tlb_all(); will do nothing but that's OK since load_cr3() >> already flushed the TLB - including any PTE with PGE set > > I take your point though. > > It's probably better to be explicit and do the whole > > if (quark) > __flu

Re: [tip:x86/platform] x86/intel/quark: Switch off CR4.PGE so TLB flush uses CR3 instead

2014-09-24 Thread Bryan O'Donoghue
On 24/09/14 16:58, Bryan O'Donoghue wrote: I believe there is one more change needed: there is a __flush_tlb_all() in the early code which gets executed before the above code runs; the easiest fix is to just add a __flush_tlb() immediately after it. This should have been pushed upstream, and

Re: [tip:x86/platform] x86/intel/quark: Switch off CR4.PGE so TLB flush uses CR3 instead

2014-09-24 Thread Bryan O'Donoghue
I believe there is one more change needed: there is a __flush_tlb_all() in the early code which gets executed before the above code runs; the easiest fix is to just add a __flush_tlb() immediately after it. This should have been pushed upstream, and not stayed in the BSP kernel. Peter. You'

Re: [tip:x86/platform] x86/intel/quark: Switch off CR4.PGE so TLB flush uses CR3 instead

2014-09-24 Thread H. Peter Anvin
On 09/24/2014 08:01 AM, tip-bot for Bryan O'Donoghue wrote: Commit-ID: ee1b5b165c0a2f04d2107e634e51f05d0eb107de Gitweb: http://git.kernel.org/tip/ee1b5b165c0a2f04d2107e634e51f05d0eb107de Author: Bryan O'Donoghue AuthorDate: Wed, 24 Sep 2014 00:26:24 +0100 Committer: Ingo Molnar Commit

[tip:x86/platform] x86/intel/quark: Switch off CR4.PGE so TLB flush uses CR3 instead

2014-09-24 Thread tip-bot for Bryan O'Donoghue
Commit-ID: ee1b5b165c0a2f04d2107e634e51f05d0eb107de Gitweb: http://git.kernel.org/tip/ee1b5b165c0a2f04d2107e634e51f05d0eb107de Author: Bryan O'Donoghue AuthorDate: Wed, 24 Sep 2014 00:26:24 +0100 Committer: Ingo Molnar CommitDate: Wed, 24 Sep 2014 15:06:15 +0200 x86/intel/quark: Switch