Re: Re: [tpmdd-devel] [PATCH] base/platform: fix panic when probe function is NULL

On Tue, Dec 01, 2015 at 07:54:59PM +0100, Peter Huewe wrote: > Can you point to that discussion or was it offline? Apparently it was brought up at the most recent kernel summit http://www.spinics.net/lists/linux-rdma/msg29985.html Jason -- To unsubscribe from this list: send the line

Aw: Re: [tpmdd-devel] [PATCH] base/platform: fix panic when probe function is NULL

> > >That fixes tpm_tis, but there are other ancient TPM drivers that use > > >the old, now broken way. > > > > > >So, we still need to do something here. Either fixup b8b2c7d845d5 as > > >you have proposed, remove the now broken obsolete TPM drivers, or try > > >and fix them.. > > > > How broken

Re: [tpmdd-devel] [PATCH] base/platform: fix panic when probe function is NULL

On Tue, Dec 01, 2015 at 10:26:17AM -0800, Peter Huewe wrote: > > > Am 1. Dezember 2015 09:25:37 PST, schrieb Jason Gunthorpe > : > >On Tue, Dec 01, 2015 at 04:19:25PM +0100, Wilck, Martin wrote: > >> > > > tpm_tis_init calls tpmm_chip_alloc which barfs when pdev (i.e. > >the return value > >> >

Re: [tpmdd-devel] [PATCH] base/platform: fix panic when probe function is NULL

Am 1. Dezember 2015 09:25:37 PST, schrieb Jason Gunthorpe : >On Tue, Dec 01, 2015 at 04:19:25PM +0100, Wilck, Martin wrote: >> > > > tpm_tis_init calls tpmm_chip_alloc which barfs when pdev (i.e. >the return value >> > > > of platform_device_register_simple above) isn't bound. It is >not

Re: [tpmdd-devel] [PATCH] base/platform: fix panic when probe function is NULL

On Tue, Dec 01, 2015 at 04:19:25PM +0100, Wilck, Martin wrote: > > > > tpm_tis_init calls tpmm_chip_alloc which barfs when pdev (i.e. the > > > > return value > > > > of platform_device_register_simple above) isn't bound. It is not allowed > > > > to assume that the device is bound after the

Re: [tpmdd-devel] [PATCH] base/platform: fix panic when probe function is NULL

On Tue, Dec 01, 2015 at 04:19:25PM +0100, Wilck, Martin wrote: > > > > tpm_tis_init calls tpmm_chip_alloc which barfs when pdev (i.e. the > > > > return value > > > > of platform_device_register_simple above) isn't bound. It is not allowed > > > > to assume that the device is bound after the

Re: [tpmdd-devel] [PATCH] base/platform: fix panic when probe function is NULL

Am 1. Dezember 2015 09:25:37 PST, schrieb Jason Gunthorpe : >On Tue, Dec 01, 2015 at 04:19:25PM +0100, Wilck, Martin wrote: >> > > > tpm_tis_init calls tpmm_chip_alloc which barfs when pdev (i.e. >the return value >> > > > of platform_device_register_simple

Aw: Re: [tpmdd-devel] [PATCH] base/platform: fix panic when probe function is NULL

> > >That fixes tpm_tis, but there are other ancient TPM drivers that use > > >the old, now broken way. > > > > > >So, we still need to do something here. Either fixup b8b2c7d845d5 as > > >you have proposed, remove the now broken obsolete TPM drivers, or try > > >and fix them.. > > > > How broken

Re: [tpmdd-devel] [PATCH] base/platform: fix panic when probe function is NULL

On Tue, Dec 01, 2015 at 10:26:17AM -0800, Peter Huewe wrote: > > > Am 1. Dezember 2015 09:25:37 PST, schrieb Jason Gunthorpe > : > >On Tue, Dec 01, 2015 at 04:19:25PM +0100, Wilck, Martin wrote: > >> > > > tpm_tis_init calls tpmm_chip_alloc which barfs when pdev

Re: Re: [tpmdd-devel] [PATCH] base/platform: fix panic when probe function is NULL

On Tue, Dec 01, 2015 at 07:54:59PM +0100, Peter Huewe wrote: > Can you point to that discussion or was it offline? Apparently it was brought up at the most recent kernel summit http://www.spinics.net/lists/linux-rdma/msg29985.html Jason -- To unsubscribe from this list: send the line

Re: [tpmdd-devel] [PATCH] base/platform: fix panic when probe function is NULL

On Mon, Nov 30, 2015 at 02:56:31PM +0200, Jarkko Sakkinen wrote: > Hi Uwe, > > On Sun, Nov 29, 2015 at 10:54:11AM +0100, Uwe Kleine-König wrote: > > Hello Jarkko, > > > > On Sat, Nov 28, 2015 at 06:34:47PM +0200, Jarkko Sakkinen wrote: > > > On Thu, Nov 26, 2015 at 08:01:34PM +0100,

Re: [tpmdd-devel] [PATCH] base/platform: fix panic when probe function is NULL

Hi Uwe, On Sun, Nov 29, 2015 at 10:54:11AM +0100, Uwe Kleine-König wrote: > Hello Jarkko, > > On Sat, Nov 28, 2015 at 06:34:47PM +0200, Jarkko Sakkinen wrote: > > On Thu, Nov 26, 2015 at 08:01:34PM +0100, martin.wi...@ts.fujitsu.com wrote: > > > From: Martin Wilck > > > > > > Since

Re: [tpmdd-devel] [PATCH] base/platform: fix panic when probe function is NULL

On Sat, Nov 28, 2015 at 03:52:51PM -0700, Jason Gunthorpe wrote: > On Sat, Nov 28, 2015 at 06:40:03PM +0200, Jarkko Sakkinen wrote: > > > I have some patches to do this that are part of my OF enablement > > > series, but I can make something simpler that would deal with this > > > fairly quickly

Re: [tpmdd-devel] [PATCH] base/platform: fix panic when probe function is NULL

On Sat, Nov 28, 2015 at 03:52:51PM -0700, Jason Gunthorpe wrote: > On Sat, Nov 28, 2015 at 06:40:03PM +0200, Jarkko Sakkinen wrote: > > > I have some patches to do this that are part of my OF enablement > > > series, but I can make something simpler that would deal with this > > > fairly quickly

Re: [tpmdd-devel] [PATCH] base/platform: fix panic when probe function is NULL

Hi Uwe, On Sun, Nov 29, 2015 at 10:54:11AM +0100, Uwe Kleine-König wrote: > Hello Jarkko, > > On Sat, Nov 28, 2015 at 06:34:47PM +0200, Jarkko Sakkinen wrote: > > On Thu, Nov 26, 2015 at 08:01:34PM +0100, martin.wi...@ts.fujitsu.com wrote: > > > From: Martin Wilck >

Re: [tpmdd-devel] [PATCH] base/platform: fix panic when probe function is NULL

On Mon, Nov 30, 2015 at 02:56:31PM +0200, Jarkko Sakkinen wrote: > Hi Uwe, > > On Sun, Nov 29, 2015 at 10:54:11AM +0100, Uwe Kleine-König wrote: > > Hello Jarkko, > > > > On Sat, Nov 28, 2015 at 06:34:47PM +0200, Jarkko Sakkinen wrote: > > > On Thu, Nov 26, 2015 at 08:01:34PM +0100,

Re: [tpmdd-devel] [PATCH] base/platform: fix panic when probe function is NULL

Hello Jarkko, On Sat, Nov 28, 2015 at 06:34:47PM +0200, Jarkko Sakkinen wrote: > On Thu, Nov 26, 2015 at 08:01:34PM +0100, martin.wi...@ts.fujitsu.com wrote: > > From: Martin Wilck > > > > Since b8b2c7d845d5, platform_drv_probe() is called for all platform > > devices. If drv->probe is NULL,

Re: [tpmdd-devel] [PATCH] base/platform: fix panic when probe function is NULL

Hello Jarkko, On Sat, Nov 28, 2015 at 06:34:47PM +0200, Jarkko Sakkinen wrote: > On Thu, Nov 26, 2015 at 08:01:34PM +0100, martin.wi...@ts.fujitsu.com wrote: > > From: Martin Wilck > > > > Since b8b2c7d845d5, platform_drv_probe() is called for all platform > >

Re: [tpmdd-devel] [PATCH] base/platform: fix panic when probe function is NULL

On Sat, Nov 28, 2015 at 06:40:03PM +0200, Jarkko Sakkinen wrote: > > I have some patches to do this that are part of my OF enablement > > series, but I can make something simpler that would deal with this > > fairly quickly if you can test. > > Does the patch set that you sent include the fix or

Re: [tpmdd-devel] [PATCH] base/platform: fix panic when probe function is NULL

On Sat, Nov 28, 2015 at 06:40:03PM +0200, Jarkko Sakkinen wrote: > On Thu, Nov 26, 2015 at 01:30:31PM -0700, Jason Gunthorpe wrote: > > On Thu, Nov 26, 2015 at 08:01:34PM +0100, martin.wi...@ts.fujitsu.com wrote: > > > From: Martin Wilck > > > > > > Since b8b2c7d845d5, platform_drv_probe() is

Re: [tpmdd-devel] [PATCH] base/platform: fix panic when probe function is NULL

On Thu, Nov 26, 2015 at 01:30:31PM -0700, Jason Gunthorpe wrote: > On Thu, Nov 26, 2015 at 08:01:34PM +0100, martin.wi...@ts.fujitsu.com wrote: > > From: Martin Wilck > > > > Since b8b2c7d845d5, platform_drv_probe() is called for all platform > > devices. If drv->probe is NULL, and

Re: [tpmdd-devel] [PATCH] base/platform: fix panic when probe function is NULL

On Thu, Nov 26, 2015 at 08:01:34PM +0100, martin.wi...@ts.fujitsu.com wrote: > From: Martin Wilck > > Since b8b2c7d845d5, platform_drv_probe() is called for all platform > devices. If drv->probe is NULL, and dev_pm_domain_attach() fails, > platform_drv_probe() will return the error code from

Re: [tpmdd-devel] [PATCH] base/platform: fix panic when probe function is NULL

On Sat, Nov 28, 2015 at 06:40:03PM +0200, Jarkko Sakkinen wrote: > On Thu, Nov 26, 2015 at 01:30:31PM -0700, Jason Gunthorpe wrote: > > On Thu, Nov 26, 2015 at 08:01:34PM +0100, martin.wi...@ts.fujitsu.com wrote: > > > From: Martin Wilck > > > > > > Since

Re: [tpmdd-devel] [PATCH] base/platform: fix panic when probe function is NULL

On Thu, Nov 26, 2015 at 01:30:31PM -0700, Jason Gunthorpe wrote: > On Thu, Nov 26, 2015 at 08:01:34PM +0100, martin.wi...@ts.fujitsu.com wrote: > > From: Martin Wilck > > > > Since b8b2c7d845d5, platform_drv_probe() is called for all platform > > devices. If

Re: [tpmdd-devel] [PATCH] base/platform: fix panic when probe function is NULL

On Thu, Nov 26, 2015 at 08:01:34PM +0100, martin.wi...@ts.fujitsu.com wrote: > From: Martin Wilck > > Since b8b2c7d845d5, platform_drv_probe() is called for all platform > devices. If drv->probe is NULL, and dev_pm_domain_attach() fails, > platform_drv_probe() will

Re: [tpmdd-devel] [PATCH] base/platform: fix panic when probe function is NULL

On Sat, Nov 28, 2015 at 06:40:03PM +0200, Jarkko Sakkinen wrote: > > I have some patches to do this that are part of my OF enablement > > series, but I can make something simpler that would deal with this > > fairly quickly if you can test. > > Does the patch set that you sent include the fix or

Re: [tpmdd-devel] [PATCH] base/platform: fix panic when probe function is NULL

On Do, 2015-11-26 at 13:30 -0700, Jason Gunthorpe wrote: > On Thu, Nov 26, 2015 at 08:01:34PM +0100, martin.wi...@ts.fujitsu.com wrote: > > From: Martin Wilck > > > > Since b8b2c7d845d5, platform_drv_probe() is called for all platform > > devices. If drv->probe is NULL, and

Re: [tpmdd-devel] [PATCH] base/platform: fix panic when probe function is NULL

On Thu, Nov 26, 2015 at 08:01:34PM +0100, martin.wi...@ts.fujitsu.com wrote: > From: Martin Wilck > > Since b8b2c7d845d5, platform_drv_probe() is called for all platform > devices. If drv->probe is NULL, and dev_pm_domain_attach() fails, > platform_drv_probe() will return the error code from

Re: [tpmdd-devel] [PATCH] base/platform: fix panic when probe function is NULL

On Thu, Nov 26, 2015 at 08:01:34PM +0100, martin.wi...@ts.fujitsu.com wrote: > From: Martin Wilck > > Since b8b2c7d845d5, platform_drv_probe() is called for all platform > devices. If drv->probe is NULL, and dev_pm_domain_attach() fails, > platform_drv_probe() will

Re: [tpmdd-devel] [PATCH] base/platform: fix panic when probe function is NULL

On Do, 2015-11-26 at 13:30 -0700, Jason Gunthorpe wrote: > On Thu, Nov 26, 2015 at 08:01:34PM +0100, martin.wi...@ts.fujitsu.com wrote: > > From: Martin Wilck > > > > Since b8b2c7d845d5, platform_drv_probe() is called for all platform > > devices. If drv->probe is