Re: [tpmdd-devel] [PATCH] tpm: fix the cleanup of struct tpm_chip

2016-02-11 Thread Jarkko Sakkinen
On Thu, Feb 11, 2016 at 12:34:15PM -0700, Jason Gunthorpe wrote: > On Tue, Feb 09, 2016 at 05:30:30AM +0200, Jarkko Sakkinen wrote: > > If the initialization fails before tpm_chip_register(), put_device() > > will be not called, which causes release callback not to be called. > > This patch fixes

Re: [tpmdd-devel] [PATCH] tpm: fix the cleanup of struct tpm_chip

2016-02-11 Thread Jason Gunthorpe
On Tue, Feb 09, 2016 at 05:30:30AM +0200, Jarkko Sakkinen wrote: > If the initialization fails before tpm_chip_register(), put_device() > will be not called, which causes release callback not to be called. > This patch fixes the issue by adding put_device() to devres list of > the parent device. >

Re: [tpmdd-devel] [PATCH] tpm: fix the cleanup of struct tpm_chip

2016-02-11 Thread Jason Gunthorpe
On Tue, Feb 09, 2016 at 05:30:30AM +0200, Jarkko Sakkinen wrote: > If the initialization fails before tpm_chip_register(), put_device() > will be not called, which causes release callback not to be called. > This patch fixes the issue by adding put_device() to devres list of > the parent device. >

Re: [tpmdd-devel] [PATCH] tpm: fix the cleanup of struct tpm_chip

2016-02-11 Thread Jarkko Sakkinen
On Thu, Feb 11, 2016 at 12:34:15PM -0700, Jason Gunthorpe wrote: > On Tue, Feb 09, 2016 at 05:30:30AM +0200, Jarkko Sakkinen wrote: > > If the initialization fails before tpm_chip_register(), put_device() > > will be not called, which causes release callback not to be called. > > This patch fixes

Re: [tpmdd-devel] [PATCH] tpm: fix the cleanup of struct tpm_chip

2016-02-09 Thread Jason Gunthorpe
On Tue, Feb 09, 2016 at 08:27:35AM +0200, Jarkko Sakkinen wrote: > On Tue, Feb 09, 2016 at 08:19:51AM +0200, Jarkko Sakkinen wrote: > > On Mon, Feb 08, 2016 at 10:26:55PM -0700, Jason Gunthorpe wrote: > > > On Tue, Feb 09, 2016 at 05:30:30AM +0200, Jarkko Sakkinen wrote: > > > > If the

Re: [tpmdd-devel] [PATCH] tpm: fix the cleanup of struct tpm_chip

2016-02-09 Thread Jason Gunthorpe
On Tue, Feb 09, 2016 at 08:27:35AM +0200, Jarkko Sakkinen wrote: > On Tue, Feb 09, 2016 at 08:19:51AM +0200, Jarkko Sakkinen wrote: > > On Mon, Feb 08, 2016 at 10:26:55PM -0700, Jason Gunthorpe wrote: > > > On Tue, Feb 09, 2016 at 05:30:30AM +0200, Jarkko Sakkinen wrote: > > > > If the

Re: [tpmdd-devel] [PATCH] tpm: fix the cleanup of struct tpm_chip

2016-02-08 Thread Jarkko Sakkinen
On Tue, Feb 09, 2016 at 08:19:51AM +0200, Jarkko Sakkinen wrote: > On Mon, Feb 08, 2016 at 10:26:55PM -0700, Jason Gunthorpe wrote: > > On Tue, Feb 09, 2016 at 05:30:30AM +0200, Jarkko Sakkinen wrote: > > > If the initialization fails before tpm_chip_register(), put_device() > > > will be not

Re: [tpmdd-devel] [PATCH] tpm: fix the cleanup of struct tpm_chip

2016-02-08 Thread Jarkko Sakkinen
On Mon, Feb 08, 2016 at 10:26:55PM -0700, Jason Gunthorpe wrote: > On Tue, Feb 09, 2016 at 05:30:30AM +0200, Jarkko Sakkinen wrote: > > If the initialization fails before tpm_chip_register(), put_device() > > will be not called, which causes release callback not to be called. > > This patch fixes

Re: [tpmdd-devel] [PATCH] tpm: fix the cleanup of struct tpm_chip

2016-02-08 Thread Jason Gunthorpe
On Tue, Feb 09, 2016 at 05:30:30AM +0200, Jarkko Sakkinen wrote: > If the initialization fails before tpm_chip_register(), put_device() > will be not called, which causes release callback not to be called. > This patch fixes the issue by adding put_device() to devres list of > the parent device.

Re: [tpmdd-devel] [PATCH] tpm: fix the cleanup of struct tpm_chip

2016-02-08 Thread Jason Gunthorpe
On Tue, Feb 09, 2016 at 05:30:30AM +0200, Jarkko Sakkinen wrote: > If the initialization fails before tpm_chip_register(), put_device() > will be not called, which causes release callback not to be called. > This patch fixes the issue by adding put_device() to devres list of > the parent device.

Re: [tpmdd-devel] [PATCH] tpm: fix the cleanup of struct tpm_chip

2016-02-08 Thread Jarkko Sakkinen
On Mon, Feb 08, 2016 at 10:26:55PM -0700, Jason Gunthorpe wrote: > On Tue, Feb 09, 2016 at 05:30:30AM +0200, Jarkko Sakkinen wrote: > > If the initialization fails before tpm_chip_register(), put_device() > > will be not called, which causes release callback not to be called. > > This patch fixes

Re: [tpmdd-devel] [PATCH] tpm: fix the cleanup of struct tpm_chip

2016-02-08 Thread Jarkko Sakkinen
On Tue, Feb 09, 2016 at 08:19:51AM +0200, Jarkko Sakkinen wrote: > On Mon, Feb 08, 2016 at 10:26:55PM -0700, Jason Gunthorpe wrote: > > On Tue, Feb 09, 2016 at 05:30:30AM +0200, Jarkko Sakkinen wrote: > > > If the initialization fails before tpm_chip_register(), put_device() > > > will be not