as Leblanc
From: Peter Hüwe [peterhu...@gmx.de]
Sent: 16 May 2013 21:03
To: tpmdd-de...@lists.sourceforge.net
Cc: Mathias LEBLANC; Jean-Luc BLANC; linux-kernel@vger.kernel.org; Rajiv
Andrade; Sirrix AG
Subject: Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI
H
Hi Matthias:
> Regarding the while loop, I don't see how can I check the number of dummy
> byte differently?
Checking the number of dummy bytes is fine -
in line #144 you check it with a while loop which looks fine
in line #198 you check it with a for loop with an empty body, which in my
opinio
rge.net
Cc: Mathias LEBLANC; Kent Yoder; Rajiv Andrade; Marcel Selhorst; Sirrix AG;
Jean-Luc BLANC; linux-kernel@vger.kernel.org
Subject: Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI
Hi Matthias,
Am Mittwoch, 15. Mai 2013, 15:53:19 schrieb Matthias Leblanc:
> +stat
Hi Matthias,
Am Mittwoch, 15. Mai 2013, 15:53:19 schrieb Matthias Leblanc:
> +static inline int spi_read_write(struct spi_device *spi,
> + struct spi_transfer xfer) {
> + struct spi_message msg;
> + spi_message_init(&msg);
> + spi_message_add_tail(&xfer, &msg);
> + return spi
May, 2013 17:07
> To: Mathias LEBLANC
> Cc: Kent Yoder; Rajiv Andrade; Marcel Selhorst; Sirrix AG; TPM Device Driver
> List; Jean-Luc BLANC; linux-kernel@vger.kernel.org
> Subject: Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI
>
> On Fri, May 10, 2013 at
Kent Yoder [mailto:shpedoi...@gmail.com]
Sent: 10 May, 2013 17:07
To: Mathias LEBLANC
Cc: Kent Yoder; Rajiv Andrade; Marcel Selhorst; Sirrix AG; TPM Device Driver
List; Jean-Luc BLANC; linux-kernel@vger.kernel.org
Subject: Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI
On Fri, May 10, 20
On Fri, May 10, 2013 at 8:38 AM, Kent Yoder wrote:
> Hi Mathias,
Sorry, this note got sent before I was done somehow...
A few compile warnings left:
drivers/char/tpm/tpm_spi_stm_st33.c: In function ‘tpm_stm_spi_status’:
drivers/char/tpm/tpm_spi_stm_st33.c:289:2: error: ‘data’ is used
uninitiali
On Sun, Apr 28, 2013 at 03:16:33AM +0200, Peter Hüwe wrote:
> Hi Matthias,
>
> it's nice to see that you consider most of the comments, unfortunately I
> still
> have some left ;)
>
> > +/*
> > + * tpm_st33_spi_init initialize driver
> > + * @return: 0 if successful, else non zero value.
> > +
Hi Matthias,
it's nice to see that you consider most of the comments, unfortunately I still
have some left ;)
> +/*
> + * tpm_st33_spi_init initialize driver
> + * @return: 0 if successful, else non zero value.
> + */
> +static int __init tpm_st33_spi_init(void)
> +{
> + return spi_register_
an-Luc BLANC;
> linux-kernel@vger.kernel.org
> Subject: Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI
>
> On Mon, Apr 22, 2013 at 06:32:05PM +0200, Mathias LEBLANC wrote:
> > Hi Kent,
> >
> > > + while (size < count &&
>
; Jean-Luc BLANC; linux-kernel@vger.kernel.org
Subject: Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI
On Mon, Apr 22, 2013 at 06:32:05PM +0200, Mathias LEBLANC wrote:
> Hi Kent,
>
> > + while (size < count &&
> > +
> Sent: 22 April, 2013 17:26
> To: Mathias LEBLANC
> Cc: Kent Yoder; Rajiv Andrade; Marcel Selhorst; Sirrix AG;
> tpmdd-de...@lists.sourceforge.net; Jean-Luc BLANC;
> linux-kernel@vger.kernel.org
> Subject: Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI
>
know if the device
is BUSY.
Regards,
Mathias Leblanc
-Original Message-
From: Kent Yoder [mailto:shpedoi...@gmail.com]
Sent: 22 April, 2013 17:26
To: Mathias LEBLANC
Cc: Kent Yoder; Rajiv Andrade; Marcel Selhorst; Sirrix AG;
tpmdd-de...@lists.sourceforge.net; Jean-Luc BLANC; linux-kernel@vge
On Mon, Apr 22, 2013 at 10:50:06AM +0200, Mathias Leblanc wrote:
> * STMicroelectronics version 1.2.0, Copyright (C) 2010
> * STMicroelectronics comes with ABSOLUTELY NO WARRANTY.
> * This is free software, and you are welcome to redistribute it
> * under certain conditions.
>
> This is the dr
n-Luc BLANC; linux-kernel@vger.kernel.org
Subject: Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI
Hi Matthias,
On Fri, Apr 12, 2013 at 10:44:11AM +0200, Matthias Leblanc wrote:
> From: Mathias Leblanc
>
> * STMicroelectronics version 1.2.0, Copyright (C) 2010
>
Hi Matthias,
On Fri, Apr 12, 2013 at 10:44:11AM +0200, Matthias Leblanc wrote:
> From: Mathias Leblanc
>
> * STMicroelectronics version 1.2.0, Copyright (C) 2010
> * STMicroelectronics comes with ABSOLUTELY NO WARRANTY.
> * This is free software, and you are welcome to redistribute it
> * un
Hi Matthias,
Am Donnerstag, 11. April 2013, 10:58:59 schrieb Mathias LEBLANC:
> Hi Peter,
>
> Yes, you have right, these error are generated by #ifndef
> __STM_ST33_TPM_SPI_H__ Just remove it and the #endif next the structure.
Yes, I know that - for the submission to be included this has to be cha
]
Sent: 10 April, 2013 22:32
To: tpmdd-de...@lists.sourceforge.net; Mathias LEBLANC; Kent Yoder; Jean-Luc
BLANC
Cc: linux-kernel@vger.kernel.org; Mathias leblanc
Subject: Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI
Hi Matthias,
Am Dienstag, 9. April 2013, 16:42:42 schrieb
Hi Matthias,
Am Dienstag, 9. April 2013, 16:42:42 schrieb Matthias Leblanc:
> From: Mathias leblanc
>
> * STMicroelectronics version 1.2.0, Copyright (C) 2010
> * STMicroelectronics comes with ABSOLUTELY NO WARRANTY.
> * This is free software, and you are welcome to redistribute it
> * under
...@lists.sourceforge.net; Jean-Luc BLANC; linux-kernel@vger.kernel.org
Subject: Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI
On Mon, Mar 25, 2013 at 10:08 AM, Matthias Leblanc
wrote:
> From: admin01
>
> * STMicroelectronics version 1.2.0, Copyright
On Mon, Mar 25, 2013 at 10:08 AM, Matthias Leblanc
wrote:
> From: admin01
>
> * STMicroelectronics version 1.2.0, Copyright (C) 2010
> * STMicroelectronics comes with ABSOLUTELY NO WARRANTY.
> * This is free software, and you are welcome to redistribute it
> * under certain conditions.
>
> Th
21 matches
Mail list logo
