Re: [tpmdd-devel] [PATCH RFC 2/2] tpm: refactor tpm2_get_tpm_pt to tpm2_getcap_cmd

2016-11-25 Thread Jarkko Sakkinen
On Thu, Nov 24, 2016 at 07:12:57PM +0530, Nayna wrote: > > > On 11/15/2016 05:18 AM, Jarkko Sakkinen wrote: > > On Fri, Nov 11, 2016 at 04:02:43PM -0800, Jarkko Sakkinen wrote: > > > On Fri, Nov 11, 2016 at 09:51:45AM +0530, Nayna wrote: > > > > > > > > > > > > On 10/09/2016 03:44 PM, Jarkko Sa

Re: [tpmdd-devel] [PATCH RFC 2/2] tpm: refactor tpm2_get_tpm_pt to tpm2_getcap_cmd

2016-11-24 Thread Nayna
On 11/15/2016 05:18 AM, Jarkko Sakkinen wrote: On Fri, Nov 11, 2016 at 04:02:43PM -0800, Jarkko Sakkinen wrote: On Fri, Nov 11, 2016 at 09:51:45AM +0530, Nayna wrote: On 10/09/2016 03:44 PM, Jarkko Sakkinen wrote: Refactored tpm2_get_tpm_pt to tpm2_getcap_cmd, which means that it also take

Re: [tpmdd-devel] [PATCH RFC 2/2] tpm: refactor tpm2_get_tpm_pt to tpm2_getcap_cmd

2016-11-22 Thread Jarkko Sakkinen
On Tue, Nov 22, 2016 at 02:38:21PM +0530, Nayna wrote: > > > On 11/18/2016 09:43 PM, Jarkko Sakkinen wrote: > > On Fri, Nov 18, 2016 at 05:42:01PM +0530, Nayna wrote: > > > > > > > > > On 11/17/2016 11:12 PM, Jarkko Sakkinen wrote: > > > > On Thu, Nov 17, 2016 at 05:20:36PM +0530, Nayna wrote:

Re: [tpmdd-devel] [PATCH RFC 2/2] tpm: refactor tpm2_get_tpm_pt to tpm2_getcap_cmd

2016-11-22 Thread Nayna
On 11/18/2016 09:43 PM, Jarkko Sakkinen wrote: On Fri, Nov 18, 2016 at 05:42:01PM +0530, Nayna wrote: On 11/17/2016 11:12 PM, Jarkko Sakkinen wrote: On Thu, Nov 17, 2016 at 05:20:36PM +0530, Nayna wrote: I tested this for capability TPM2_CAP_PCRS. It seems TPM2_CAP_PCRS capability always

Re: [tpmdd-devel] [PATCH RFC 2/2] tpm: refactor tpm2_get_tpm_pt to tpm2_getcap_cmd

2016-11-18 Thread Jarkko Sakkinen
On Fri, Nov 18, 2016 at 05:42:01PM +0530, Nayna wrote: > > > On 11/17/2016 11:12 PM, Jarkko Sakkinen wrote: > > On Thu, Nov 17, 2016 at 05:20:36PM +0530, Nayna wrote: > > > > > I tested this for capability TPM2_CAP_PCRS. It seems TPM2_CAP_PCRS > > > capability always returns full PCR allocation,

Re: [tpmdd-devel] [PATCH RFC 2/2] tpm: refactor tpm2_get_tpm_pt to tpm2_getcap_cmd

2016-11-18 Thread Nayna
On 11/17/2016 11:12 PM, Jarkko Sakkinen wrote: On Thu, Nov 17, 2016 at 05:20:36PM +0530, Nayna wrote: I tested this for capability TPM2_CAP_PCRS. It seems TPM2_CAP_PCRS capability always returns full PCR allocation, and more_data as 0, So, I think the idea of looping over based on more_data m

Re: [tpmdd-devel] [PATCH RFC 2/2] tpm: refactor tpm2_get_tpm_pt to tpm2_getcap_cmd

2016-11-17 Thread Jarkko Sakkinen
On Thu, Nov 17, 2016 at 05:20:36PM +0530, Nayna wrote: > I tested this for capability TPM2_CAP_PCRS. It seems TPM2_CAP_PCRS > capability always returns full PCR allocation, and more_data as 0, So, I > think the idea of looping over based on more_data may not work for this > capability. You can a

Re: [tpmdd-devel] [PATCH RFC 2/2] tpm: refactor tpm2_get_tpm_pt to tpm2_getcap_cmd

2016-11-17 Thread Nayna
On 11/12/2016 05:32 AM, Jarkko Sakkinen wrote: On Fri, Nov 11, 2016 at 09:51:45AM +0530, Nayna wrote: On 10/09/2016 03:44 PM, Jarkko Sakkinen wrote: Refactored tpm2_get_tpm_pt to tpm2_getcap_cmd, which means that it also takes capability ID as input. This is required to access TPM_CAP_HANDL

Re: [tpmdd-devel] [PATCH RFC 2/2] tpm: refactor tpm2_get_tpm_pt to tpm2_getcap_cmd

2016-11-14 Thread Jarkko Sakkinen
On Fri, Nov 11, 2016 at 04:02:43PM -0800, Jarkko Sakkinen wrote: > On Fri, Nov 11, 2016 at 09:51:45AM +0530, Nayna wrote: > > > > > > On 10/09/2016 03:44 PM, Jarkko Sakkinen wrote: > > > Refactored tpm2_get_tpm_pt to tpm2_getcap_cmd, which means that it also > > > takes capability ID as input. Th

Re: [tpmdd-devel] [PATCH RFC 2/2] tpm: refactor tpm2_get_tpm_pt to tpm2_getcap_cmd

2016-11-11 Thread Jarkko Sakkinen
On Fri, Nov 11, 2016 at 09:51:45AM +0530, Nayna wrote: > > > On 10/09/2016 03:44 PM, Jarkko Sakkinen wrote: > > Refactored tpm2_get_tpm_pt to tpm2_getcap_cmd, which means that it also > > takes capability ID as input. This is required to access > > TPM_CAP_HANDLES, which contains metadata needed

Re: [tpmdd-devel] [PATCH RFC 2/2] tpm: refactor tpm2_get_tpm_pt to tpm2_getcap_cmd

2016-11-10 Thread Nayna
On 10/09/2016 03:44 PM, Jarkko Sakkinen wrote: Refactored tpm2_get_tpm_pt to tpm2_getcap_cmd, which means that it also takes capability ID as input. This is required to access TPM_CAP_HANDLES, which contains metadata needed for swapping transient data. Signed-off-by: Jarkko Sakkinen --- dri