Re: [tpmdd-devel] tpm: read burstcount from TPM_STS in one 32-bit transaction

2017-08-01 Thread George Wilson
On Tue, Jul 25, 2017 at 10:36:11AM -0700, James Bottomley wrote: > On Tue, 2017-07-25 at 15:04 +0200, Michal Suchánek wrote: > > Hello, > > > > in commit 9754d45e9970 ("tpm: read burstcount from TPM_STS in one > > 32-bit transaction") you change reading of two 8-bit values to one > > 32bit read.

Re: [tpmdd-devel] tpm: read burstcount from TPM_STS in one 32-bit transaction

2017-08-01 Thread George Wilson
On Tue, Jul 25, 2017 at 10:36:11AM -0700, James Bottomley wrote: > On Tue, 2017-07-25 at 15:04 +0200, Michal Suchánek wrote: > > Hello, > > > > in commit 9754d45e9970 ("tpm: read burstcount from TPM_STS in one > > 32-bit transaction") you change reading of two 8-bit values to one > > 32bit read.

Re: [tpmdd-devel] tpm: read burstcount from TPM_STS in one 32-bit transaction

2017-08-01 Thread Jarkko Sakkinen
On Tue, Jul 25, 2017 at 08:17:58PM +0200, Michal Suchánek wrote: > On Tue, 25 Jul 2017 10:36:11 -0700 > James Bottomley wrote: > > > On Tue, 2017-07-25 at 15:04 +0200, Michal Suchánek wrote: > > > Hello, > > > > > > in commit 9754d45e9970 ("tpm: read burstcount from

Re: [tpmdd-devel] tpm: read burstcount from TPM_STS in one 32-bit transaction

2017-08-01 Thread Jarkko Sakkinen
On Tue, Jul 25, 2017 at 08:17:58PM +0200, Michal Suchánek wrote: > On Tue, 25 Jul 2017 10:36:11 -0700 > James Bottomley wrote: > > > On Tue, 2017-07-25 at 15:04 +0200, Michal Suchánek wrote: > > > Hello, > > > > > > in commit 9754d45e9970 ("tpm: read burstcount from TPM_STS in one > > > 32-bit

Re: [tpmdd-devel] tpm: read burstcount from TPM_STS in one 32-bit transaction

2017-07-25 Thread Michal Suchánek
On Tue, 25 Jul 2017 10:36:11 -0700 James Bottomley wrote: > On Tue, 2017-07-25 at 15:04 +0200, Michal Suchánek wrote: > > Hello, > > > > in commit 9754d45e9970 ("tpm: read burstcount from TPM_STS in one > > 32-bit transaction") you change reading of two 8-bit values to

Re: [tpmdd-devel] tpm: read burstcount from TPM_STS in one 32-bit transaction

2017-07-25 Thread Michal Suchánek
On Tue, 25 Jul 2017 10:36:11 -0700 James Bottomley wrote: > On Tue, 2017-07-25 at 15:04 +0200, Michal Suchánek wrote: > > Hello, > > > > in commit 9754d45e9970 ("tpm: read burstcount from TPM_STS in one > > 32-bit transaction") you change reading of two 8-bit values to one > > 32bit read. This

Re: [tpmdd-devel] tpm: read burstcount from TPM_STS in one 32-bit transaction

2017-07-25 Thread James Bottomley
On Tue, 2017-07-25 at 15:04 +0200, Michal Suchánek wrote: > Hello, > > in commit 9754d45e9970 ("tpm: read burstcount from TPM_STS in one > 32-bit transaction") you change reading of two 8-bit values to one > 32bit read. This is obviously wrong wrt endianess unless the > underlying tpm_tis_read32

Re: [tpmdd-devel] tpm: read burstcount from TPM_STS in one 32-bit transaction

2017-07-25 Thread James Bottomley
On Tue, 2017-07-25 at 15:04 +0200, Michal Suchánek wrote: > Hello, > > in commit 9754d45e9970 ("tpm: read burstcount from TPM_STS in one > 32-bit transaction") you change reading of two 8-bit values to one > 32bit read. This is obviously wrong wrt endianess unless the > underlying tpm_tis_read32