Re: [uml-devel] [PATCH 07/15] hostfs: Remove open coded strcpy()

2015-03-16 Thread Geert Uytterhoeven
Hi Richard, On Mon, Mar 16, 2015 at 1:18 PM, Richard Weinberger wrote: > Am 16.03.2015 um 13:03 schrieb Geert Uytterhoeven: >> On Mon, Mar 16, 2015 at 12:41 PM, Richard Weinberger wrote: >>> --- a/fs/hostfs/hostfs_kern.c >>> +++ b/fs/hostfs/hostfs_kern.c >>> @@ -105,11 +105,10 @@ static char *__

Re: [uml-devel] [PATCH 07/15] hostfs: Remove open coded strcpy()

2015-03-16 Thread Richard Weinberger
Am 16.03.2015 um 13:03 schrieb Geert Uytterhoeven: > On Mon, Mar 16, 2015 at 12:41 PM, Richard Weinberger wrote: >> --- a/fs/hostfs/hostfs_kern.c >> +++ b/fs/hostfs/hostfs_kern.c >> @@ -105,11 +105,10 @@ static char *__dentry_name(struct dentry *dentry, char >> *name) > > This code looks fishy t

Re: [uml-devel] [PATCH 07/15] hostfs: Remove open coded strcpy()

2015-03-16 Thread Geert Uytterhoeven
On Mon, Mar 16, 2015 at 12:41 PM, Richard Weinberger wrote: > --- a/fs/hostfs/hostfs_kern.c > +++ b/fs/hostfs/hostfs_kern.c > @@ -105,11 +105,10 @@ static char *__dentry_name(struct dentry *dentry, char > *name) This code looks fishy to me... First we have: len = strlen(root); strlcpy(